From mboxrd@z Thu Jan 1 00:00:00 1970 Return-path: Received: from mga09.intel.com ([134.134.136.24]:14975 "EHLO mga09.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752363AbcEAWAF (ORCPT ); Sun, 1 May 2016 18:00:05 -0400 Subject: Re: [PATCH 1/2] media: exynos4-is: fix deadlock on driver probe To: Marek Szyprowski , linux-media@vger.kernel.org, linux-samsung-soc@vger.kernel.org Cc: Sylwester Nawrocki , Jacek Anaszewski , Krzysztof Kozlowski , Bartlomiej Zolnierkiewicz , Mauro Carvalho Chehab References: <1461839104-29135-1-git-send-email-m.szyprowski@samsung.com> From: Sakari Ailus Message-ID: <57267C5C.2000403@linux.intel.com> Date: Mon, 2 May 2016 00:59:56 +0300 MIME-Version: 1.0 In-Reply-To: <1461839104-29135-1-git-send-email-m.szyprowski@samsung.com> Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Sender: linux-media-owner@vger.kernel.org List-ID: Hi Marek, Marek Szyprowski wrote: > Commit 0c426c472b5585ed6e59160359c979506d45ae49 ("[media] media: Always > keep a graph walk large enough around") changed > media_device_register_entity() function to take mdev->graph_mutex. This > causes deadlock in driver probe, which calls (indirectly) this function > with ->graph_mutex taken. This patch removes taking ->graph_mutex in > driver probe to avoid deadlock. Other drivers don't take ->graph_mutex > for entity registration, so this change should be safe. > > Signed-off-by: Marek Szyprowski Acked-by: Sakari Ailus You could also add: Fixes: 0c426c472b55 ("[media] media: Always keep a graph walk large enough around") I guess these should go to fixes, the patches in question are already heading for v4.6. Cc Mauro. -- Kind regards, Sakari Ailus sakari.ailus@linux.intel.com