public inbox for linux-media@vger.kernel.org
 help / color / mirror / Atom feed
From: Lars-Peter Clausen <lars@metafoo.de>
To: Dragos Bogdan <dragos.bogdan@analog.com>,
	Hans Verkuil <hans.verkuil@cisco.com>,
	Mauro Carvalho Chehab <mchehab@osg.samsung.com>
Cc: linux-media@vger.kernel.org
Subject: Re: [PATCH] [media] adv7604: Add support for hardware reset
Date: Tue, 24 May 2016 11:18:19 +0200	[thread overview]
Message-ID: <57441C5B.6000305@metafoo.de> (raw)
In-Reply-To: <1464081202-25043-1-git-send-email-dragos.bogdan@analog.com>

On 05/24/2016 11:13 AM, Dragos Bogdan wrote:
> The part can be reset by a low pulse on the RESET pin (i.e. a hardware reset) with a minimum width of 5 ms. It is recommended to wait 5 ms after the low pulse before an I2C write is performed to the part.
> For safety reasons, the delays will be 10 ms.
> The RESET pin can be tied high, so the GPIO is optional.
> 
> Signed-off-by: Dragos Bogdan <dragos.bogdan@analog.com>

Patch looks OK. One comment about the commit message, usually this should be
line-wrapped at around 75 characters.

Reviewed-by: Lars-Peter Clausen <lars@metafoo.de>

Thanks.

  reply	other threads:[~2016-05-24  9:18 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-05-24  9:13 [PATCH] [media] adv7604: Add support for hardware reset Dragos Bogdan
2016-05-24  9:18 ` Lars-Peter Clausen [this message]
2016-05-24 12:23 ` Laurent Pinchart

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=57441C5B.6000305@metafoo.de \
    --to=lars@metafoo.de \
    --cc=dragos.bogdan@analog.com \
    --cc=hans.verkuil@cisco.com \
    --cc=linux-media@vger.kernel.org \
    --cc=mchehab@osg.samsung.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox