From: Hans Verkuil <hverkuil@xs4all.nl>
To: Sakari Ailus <sakari.ailus@linux.intel.com>, linux-media@vger.kernel.org
Cc: g.liakhovetski@gmx.de
Subject: Re: [PATCH 6/6] v4l: Add packed Bayer raw14 pixel formats
Date: Mon, 20 Jun 2016 17:29:31 +0200 [thread overview]
Message-ID: <57680BDB.7070608@xs4all.nl> (raw)
In-Reply-To: <1464353080-18300-7-git-send-email-sakari.ailus@linux.intel.com>
On 05/27/2016 02:44 PM, Sakari Ailus wrote:
> These formats are compressed 14-bit raw bayer formats with four different
> pixel orders. They are similar to 10-bit variants. The formats added by
> this patch are
>
> V4L2_PIX_FMT_SBGGR14P
> V4L2_PIX_FMT_SGBRG14P
> V4L2_PIX_FMT_SGRBG14P
> V4L2_PIX_FMT_SRGGB14P
>
> Signed-off-by: Sakari Ailus <sakari.ailus@linux.intel.com>
> ---
> .../DocBook/media/v4l/pixfmt-srggb14p.xml | 118 +++++++++++++++++++++
> Documentation/DocBook/media/v4l/pixfmt.xml | 1 +
> include/uapi/linux/videodev2.h | 5 +
> 3 files changed, 124 insertions(+)
> create mode 100644 Documentation/DocBook/media/v4l/pixfmt-srggb14p.xml
>
> diff --git a/Documentation/DocBook/media/v4l/pixfmt-srggb14p.xml b/Documentation/DocBook/media/v4l/pixfmt-srggb14p.xml
> new file mode 100644
> index 0000000..ecb06ef
> --- /dev/null
> +++ b/Documentation/DocBook/media/v4l/pixfmt-srggb14p.xml
> @@ -0,0 +1,118 @@
> + <refentry id="pixfmt-srggb14p">
> + <refmeta>
> + <refentrytitle>V4L2_PIX_FMT_SRGGB14P ('pREE'),
> + V4L2_PIX_FMT_SGRBG14P ('pgEE'),
> + V4L2_PIX_FMT_SGBRG14P ('pGEE'),
> + V4L2_PIX_FMT_SBGGR14P ('pBEE'),
Again comma too many.
> + </refentrytitle>
> + &manvol;
> + </refmeta>
> + <refnamediv>
> + <refname id="V4L2-PIX-FMT-SRGGB14P"><constant>V4L2_PIX_FMT_SRGGB14P</constant></refname>
> + <refname id="V4L2-PIX-FMT-SGRBG14P"><constant>V4L2_PIX_FMT_SGRBG14P</constant></refname>
> + <refname id="V4L2-PIX-FMT-SGBRG14P"><constant>V4L2_PIX_FMT_SGBRG14P</constant></refname>
> + <refname id="V4L2-PIX-FMT-SBGGR14P"><constant>V4L2_PIX_FMT_SBGGR14P</constant></refname>
> + <refpurpose>14-bit packed Bayer formats</refpurpose>
> + </refnamediv>
> + <refsect1>
> + <title>Description</title>
> +
> + <para>These four pixel formats are packed raw sRGB / Bayer
> + formats with 14 bits per colour. Every four consecutive colour
> + components are packed into 7 bytes. Each of the first 4 bytes
> + contain the 8 high order bits of the pixels, and the fifth, sixth
> + and seventh bytes contains the six least significants bits of each
s/significants/significant/
After fixing this:
Acked-by: Hans Verkuil <hans.verkuil@cisco.com>
Regards,
Hans
> + pixel, in the same order.</para>
> +
> + <para>Each n-pixel row contains n/2 green samples and n/2 blue
> + or red samples, with alternating green-red and green-blue
> + rows. They are conventionally described as GRGR... BGBG...,
> + RGRG... GBGB..., etc. Below is an example of one of these
> + formats:</para>
> +
> + <example>
> + <title><constant>V4L2_PIX_FMT_SBGGR14P</constant> 4 × 4
> + pixel image</title>
> +
> + <formalpara>
> + <title>Byte Order.</title>
> + <para>Each cell is one byte. The bits in subscript denote bits
> + of the sample. The bits of the cell byte can be found in
> + parentheses.
> +
> + <informaltable frame="topbot" colsep="1" rowsep="1">
> + <tgroup cols="7" align="center">
> + <colspec align="left" colwidth="2*" />
> + <tbody valign="top">
> + <row>
> + <entry>start + 0:</entry>
> + <entry>B<subscript>00 bits 13--8</subscript></entry>
> + <entry>G<subscript>01 bits 13--8</subscript></entry>
> + <entry>B<subscript>02 bits 13--8</subscript></entry>
> + <entry>G<subscript>03 bits 13--8</subscript></entry>
> + <entry>G<subscript>01 bits 1--0</subscript>(bits 7--6)
> + B<subscript>00 bits 5--0</subscript>(bits 5--0)
> + </entry>
> + <entry>B<subscript>02 bits 3--0</subscript>(bits 7--4)
> + G<subscript>01 bits 5--2</subscript>(bits 3--0)
> + </entry>
> + <entry>G<subscript>03 bits 5--0</subscript>(bits 7--2)
> + B<subscript>02 bits 5--4</subscript>(bits 1--0)
> + </entry>
> + </row>
> + <row>
> + <entry>start + 7:</entry>
> + <entry>G<subscript>10 bits 13--8</subscript></entry>
> + <entry>R<subscript>11 bits 13--8</subscript></entry>
> + <entry>G<subscript>12 bits 13--8</subscript></entry>
> + <entry>R<subscript>13 bits 13--8</subscript></entry>
> + <entry>R<subscript>11 bits 1--0</subscript>(bits 7--6)
> + B<subscript>10 bits 5--0</subscript>(bits 5--0)
> + </entry>
> + <entry>R<subscript>12 bits 3--0</subscript>(bits 7--4)
> + G<subscript>11 bits 5--2</subscript>(bits 3--0)
> + </entry>
> + <entry>R<subscript>13 bits 5--0</subscript>(bits 7--2)
> + B<subscript>12 bits 5--4</subscript>(bits 1--0)
> + </entry>
> + </row>
> + <row>
> + <entry>start + 14:</entry>
> + <entry>B<subscript>20 bits 13--8</subscript></entry>
> + <entry>G<subscript>21 bits 13--8</subscript></entry>
> + <entry>B<subscript>22 bits 13--8</subscript></entry>
> + <entry>G<subscript>23 bits 13--8</subscript></entry>
> + <entry>G<subscript>21 bits 1--0</subscript>(bits 7--6)
> + B<subscript>20 bits 5--0</subscript>(bits 5--0)
> + </entry>
> + <entry>B<subscript>22 bits 3--0</subscript>(bits 7--4)
> + G<subscript>21 bits 5--2</subscript>(bits 3--0)
> + </entry>
> + <entry>G<subscript>23 bits 5--0</subscript>(bits 7--2)
> + B<subscript>22 bits 5--4</subscript>(bits 1--0)
> + </entry>
> + </row>
> + <row>
> + <entry>start + 21:</entry>
> + <entry>G<subscript>30 bits 13--8</subscript></entry>
> + <entry>R<subscript>31 bits 13--8</subscript></entry>
> + <entry>G<subscript>32 bits 13--8</subscript></entry>
> + <entry>R<subscript>33 bits 13--8</subscript></entry>
> + <entry>R<subscript>31 bits 1--0</subscript>(bits 7--6)
> + B<subscript>30 bits 5--0</subscript>(bits 5--0)
> + </entry>
> + <entry>R<subscript>32 bits 3--0</subscript>(bits 7--4)
> + G<subscript>31 bits 5--2</subscript>(bits 3--0)
> + </entry>
> + <entry>R<subscript>33 bits 5--0</subscript>(bits 7--2)
> + B<subscript>32 bits 5--4</subscript>(bits 1--0)
> + </entry>
> + </row>
> + </tbody>
> + </tgroup>
> + </informaltable>
> + </para>
> + </formalpara>
> + </example>
> + </refsect1>
> +</refentry>
> diff --git a/Documentation/DocBook/media/v4l/pixfmt.xml b/Documentation/DocBook/media/v4l/pixfmt.xml
> index 29e9d7c..296a50a 100644
> --- a/Documentation/DocBook/media/v4l/pixfmt.xml
> +++ b/Documentation/DocBook/media/v4l/pixfmt.xml
> @@ -1595,6 +1595,7 @@ access the palette, this must be done with ioctls of the Linux framebuffer API.<
> &sub-srggb12;
> &sub-srggb12p;
> &sub-srggb14;
> + &sub-srggb14p;
> </section>
>
> <section id="yuv-formats">
> diff --git a/include/uapi/linux/videodev2.h b/include/uapi/linux/videodev2.h
> index 2c4b076..63d141e 100644
> --- a/include/uapi/linux/videodev2.h
> +++ b/include/uapi/linux/videodev2.h
> @@ -585,6 +585,11 @@ struct v4l2_pix_format {
> #define V4L2_PIX_FMT_SGBRG14 v4l2_fourcc('G', 'B', '1', '4') /* 14 GBGB.. RGRG.. */
> #define V4L2_PIX_FMT_SGRBG14 v4l2_fourcc('B', 'A', '1', '4') /* 14 GRGR.. BGBG.. */
> #define V4L2_PIX_FMT_SRGGB14 v4l2_fourcc('R', 'G', '1', '4') /* 14 RGRG.. GBGB.. */
> + /* 14bit raw bayer packed, 7 bytes for every 4 pixels */
> +#define V4L2_PIX_FMT_SBGGR14P v4l2_fourcc('p', 'B', 'E', 'E')
> +#define V4L2_PIX_FMT_SGBRG14P v4l2_fourcc('p', 'G', 'E', 'E')
> +#define V4L2_PIX_FMT_SGRBG14P v4l2_fourcc('p', 'g', 'E', 'E')
> +#define V4L2_PIX_FMT_SRGGB14P v4l2_fourcc('p', 'R', 'E', 'E')
> #define V4L2_PIX_FMT_SBGGR16 v4l2_fourcc('B', 'Y', 'R', '2') /* 16 BGBG.. GRGR.. */
>
> /* compressed formats */
>
prev parent reply other threads:[~2016-06-20 15:29 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-05-27 12:44 [PATCH 0/6] New raw bayer format definitions, fixes Sakari Ailus
2016-05-27 12:44 ` [PATCH 1/6] v4l: Correct the ordering of LSBs of the 10-bit raw packed formats Sakari Ailus
2016-06-20 15:12 ` Hans Verkuil
2016-06-20 15:34 ` Sakari Ailus
2016-05-27 12:44 ` [PATCH 2/6] v4l: Fix number of zeroed high order bits in 12-bit raw format defs Sakari Ailus
2016-06-20 15:13 ` Hans Verkuil
2016-05-27 12:44 ` [PATCH 3/6] v4l: Add packed Bayer raw12 pixel formats Sakari Ailus
2016-06-20 15:21 ` Hans Verkuil
2016-06-20 15:37 ` Sakari Ailus
2016-05-27 12:44 ` [PATCH 4/6] media: Add 1X14 14-bit raw bayer media bus code definitions Sakari Ailus
2016-06-20 15:23 ` Hans Verkuil
2016-05-27 12:44 ` [PATCH 5/6] v4l: Add 14-bit raw bayer pixel format definitions Sakari Ailus
2016-06-20 15:24 ` Hans Verkuil
2016-06-20 16:03 ` Sakari Ailus
2016-06-20 16:05 ` Hans Verkuil
2016-05-27 12:44 ` [PATCH 6/6] v4l: Add packed Bayer raw14 pixel formats Sakari Ailus
2016-06-20 15:29 ` Hans Verkuil [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=57680BDB.7070608@xs4all.nl \
--to=hverkuil@xs4all.nl \
--cc=g.liakhovetski@gmx.de \
--cc=linux-media@vger.kernel.org \
--cc=sakari.ailus@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).