From: Hans Verkuil <hverkuil@xs4all.nl>
To: Sakari Ailus <sakari.ailus@linux.intel.com>, linux-media@vger.kernel.org
Subject: Re: [PATCH v2 3/7] v4l: Clean up raw bayer pixel format definitions
Date: Mon, 20 Jun 2016 18:54:33 +0200 [thread overview]
Message-ID: <57681FC9.8010505@xs4all.nl> (raw)
In-Reply-To: <1466439608-22890-4-git-send-email-sakari.ailus@linux.intel.com>
On 06/20/2016 06:20 PM, Sakari Ailus wrote:
> - Explicitly state that the most significant n bits are zeroed on 10 and
> 12 bpp formats.
> - Remove extra comma from the last entry of the format list
> - Add a missing colon before a list
>
> Signed-off-by: Sakari Ailus <sakari.ailus@linux.intel.com>
Acked-by: Hans Verkuil <hans.verkuil@cisco.com>
Hans
> ---
> Documentation/DocBook/media/v4l/pixfmt-srggb10.xml | 5 +++--
> Documentation/DocBook/media/v4l/pixfmt-srggb10p.xml | 2 +-
> Documentation/DocBook/media/v4l/pixfmt-srggb12.xml | 5 +++--
> 3 files changed, 7 insertions(+), 5 deletions(-)
>
> diff --git a/Documentation/DocBook/media/v4l/pixfmt-srggb10.xml b/Documentation/DocBook/media/v4l/pixfmt-srggb10.xml
> index f34d03e..cd3f915 100644
> --- a/Documentation/DocBook/media/v4l/pixfmt-srggb10.xml
> +++ b/Documentation/DocBook/media/v4l/pixfmt-srggb10.xml
> @@ -23,7 +23,7 @@ unused high bits filled with zeros. Each n-pixel row contains n/2 green samples
> and n/2 blue or red samples, with alternating red and blue rows. Bytes are
> stored in memory in little endian order. They are conventionally described
> as GRGR... BGBG..., RGRG... GBGB..., etc. Below is an example of one of these
> -formats</para>
> +formats:</para>
>
> <example>
> <title><constant>V4L2_PIX_FMT_SBGGR10</constant> 4 × 4
> @@ -31,7 +31,8 @@ pixel image</title>
>
> <formalpara>
> <title>Byte Order.</title>
> - <para>Each cell is one byte, high 6 bits in high bytes are 0.
> + <para>Each cell is one byte, the 6 most significant bits in the high
> + bytes are 0.
> <informaltable frame="none">
> <tgroup cols="5" align="center">
> <colspec align="left" colwidth="2*" />
> diff --git a/Documentation/DocBook/media/v4l/pixfmt-srggb10p.xml b/Documentation/DocBook/media/v4l/pixfmt-srggb10p.xml
> index 747822b..18bb722 100644
> --- a/Documentation/DocBook/media/v4l/pixfmt-srggb10p.xml
> +++ b/Documentation/DocBook/media/v4l/pixfmt-srggb10p.xml
> @@ -3,7 +3,7 @@
> <refentrytitle>V4L2_PIX_FMT_SRGGB10P ('pRAA'),
> V4L2_PIX_FMT_SGRBG10P ('pgAA'),
> V4L2_PIX_FMT_SGBRG10P ('pGAA'),
> - V4L2_PIX_FMT_SBGGR10P ('pBAA'),
> + V4L2_PIX_FMT_SBGGR10P ('pBAA')
> </refentrytitle>
> &manvol;
> </refmeta>
> diff --git a/Documentation/DocBook/media/v4l/pixfmt-srggb12.xml b/Documentation/DocBook/media/v4l/pixfmt-srggb12.xml
> index 4394101..2d8efeb 100644
> --- a/Documentation/DocBook/media/v4l/pixfmt-srggb12.xml
> +++ b/Documentation/DocBook/media/v4l/pixfmt-srggb12.xml
> @@ -23,7 +23,7 @@ unused high bits filled with zeros. Each n-pixel row contains n/2 green samples
> and n/2 blue or red samples, with alternating red and blue rows. Bytes are
> stored in memory in little endian order. They are conventionally described
> as GRGR... BGBG..., RGRG... GBGB..., etc. Below is an example of one of these
> -formats</para>
> +formats:</para>
>
> <example>
> <title><constant>V4L2_PIX_FMT_SBGGR12</constant> 4 × 4
> @@ -31,7 +31,8 @@ pixel image</title>
>
> <formalpara>
> <title>Byte Order.</title>
> - <para>Each cell is one byte, high 4 bits in high bytes are 0.
> + <para>Each cell is one byte, the 4 most significant bits in the high
> + bytes are 0.
> <informaltable frame="none">
> <tgroup cols="5" align="center">
> <colspec align="left" colwidth="2*" />
>
next prev parent reply other threads:[~2016-06-20 16:57 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-06-20 16:20 [PATCH v2 0/7] New raw bayer format definitions, fixes Sakari Ailus
2016-06-20 16:20 ` [PATCH v2 1/7] v4l: Correct the ordering of LSBs of the 10-bit raw packed formats Sakari Ailus
2016-06-20 17:03 ` Hans Verkuil
2016-06-20 20:38 ` Dave Stevenson
2016-06-21 6:24 ` Hans Verkuil
2016-06-20 16:20 ` [PATCH v2 2/7] v4l: Fix number of zeroed high order bits in 12-bit raw format defs Sakari Ailus
2016-06-20 16:54 ` Hans Verkuil
2016-06-20 16:20 ` [PATCH v2 3/7] v4l: Clean up raw bayer pixel format definitions Sakari Ailus
2016-06-20 16:54 ` Hans Verkuil [this message]
2016-06-20 16:20 ` [PATCH v2 4/7] v4l: Add packed Bayer raw12 pixel formats Sakari Ailus
2016-06-20 16:20 ` [PATCH v2 5/7] media: Add 1X14 14-bit raw bayer media bus code definitions Sakari Ailus
2016-06-20 16:20 ` [PATCH v2 6/7] v4l: Add 14-bit raw bayer pixel format definitions Sakari Ailus
2016-06-27 14:45 ` [PATCH v2.1 6/9] " Sakari Ailus
2016-07-08 9:24 ` Hans Verkuil
2016-06-20 16:20 ` [PATCH v2 7/7] v4l: Add packed Bayer raw14 pixel formats Sakari Ailus
2016-06-27 14:57 ` [PATCH v2.1 8/9] media: Add 1X16 16-bit raw bayer media bus code definitions Sakari Ailus
2016-06-27 14:57 ` [PATCH v2.1 9/9] v4l: Add 16-bit raw bayer pixel format definitions Sakari Ailus
2016-07-07 6:48 ` [PATCH v2.2 09/10] v4l: 16-bit BGGR is always 16 bits Sakari Ailus
2016-07-07 6:48 ` [PATCH v2.2 10/10] v4l: Add 16-bit raw bayer pixel format definitions Sakari Ailus
2016-07-13 13:48 ` Lad, Prabhakar
2016-07-13 13:47 ` [PATCH v2.2 09/10] v4l: 16-bit BGGR is always 16 bits Lad, Prabhakar
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=57681FC9.8010505@xs4all.nl \
--to=hverkuil@xs4all.nl \
--cc=linux-media@vger.kernel.org \
--cc=sakari.ailus@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox