From: Lars-Peter Clausen <lars@metafoo.de>
To: Steve Longerbeam <slongerbeam@gmail.com>, linux-media@vger.kernel.org
Cc: Steve Longerbeam <steve_longerbeam@mentor.com>
Subject: Re: [PATCH 03/11] media: adv7180: add power pin control
Date: Thu, 7 Jul 2016 17:35:51 +0200 [thread overview]
Message-ID: <577E76D7.9090609@metafoo.de> (raw)
In-Reply-To: <1467846004-12731-4-git-send-email-steve_longerbeam@mentor.com>
> @@ -1190,6 +1207,20 @@ out_unlock:
> return ret;
> }
>
> +static int adv7180_of_parse(struct adv7180_state *state)
Since there is nothing of specific in here anymore the name should be
changed, or maybe just inline the code directly in probe.
> +{
> + struct i2c_client *client = state->client;
> +
> + state->pwdn_gpio = devm_gpiod_get_optional(&client->dev, "pwdn",
I'd use "powerdown", vowels don't cost extra ;):
> + GPIOD_OUT_HIGH);
> + if (IS_ERR(state->pwdn_gpio)) {
> + v4l_err(client, "request for power pin failed\n");
Include the error number in the message.
> + return PTR_ERR(state->pwdn_gpio);
> + }
> +
> + return 0;
> +}
next prev parent reply other threads:[~2016-07-07 15:35 UTC|newest]
Thread overview: 55+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-07-06 22:59 [PATCH 00/11] adv7180 subdev fixes Steve Longerbeam
2016-07-06 22:59 ` [PATCH 01/11] media: adv7180: Fix broken interrupt register access Steve Longerbeam
2016-07-07 14:44 ` Tim Harvey
2016-07-07 15:37 ` Lars-Peter Clausen
2016-07-06 22:59 ` [PATCH 02/11] Revert "[media] adv7180: fix broken standards handling" Steve Longerbeam
2016-07-07 14:48 ` Tim Harvey
2016-07-07 15:45 ` Lars-Peter Clausen
2016-07-09 18:56 ` Steve Longerbeam
2016-07-06 22:59 ` [PATCH 03/11] media: adv7180: add power pin control Steve Longerbeam
2016-07-07 15:04 ` Tim Harvey
2016-07-07 15:35 ` Lars-Peter Clausen [this message]
2016-07-06 22:59 ` [PATCH 04/11] media: adv7180: implement g_parm Steve Longerbeam
2016-07-07 15:04 ` Tim Harvey
2016-07-06 22:59 ` [PATCH 05/11] media: adv7180: init chip with AD recommended register settings Steve Longerbeam
2016-07-07 15:23 ` Tim Harvey
2016-07-07 15:29 ` Lars-Peter Clausen
2016-07-06 22:59 ` [PATCH 06/11] media: adv7180: add bt.656-4 OF property Steve Longerbeam
2016-07-07 14:52 ` Lars-Peter Clausen
2016-07-09 18:59 ` Steve Longerbeam
2016-07-09 21:10 ` Steve Longerbeam
2016-07-09 21:36 ` Steve Longerbeam
2016-07-10 12:10 ` Lars-Peter Clausen
2016-07-10 12:55 ` Hans Verkuil
2016-07-10 14:17 ` Ian Arkver
2016-07-10 14:30 ` Hans Verkuil
2016-07-10 22:34 ` Steve Longerbeam
2016-07-11 7:06 ` Ian Arkver
2016-07-11 22:03 ` Steve Longerbeam
2016-07-12 10:25 ` Ian Arkver
2016-07-12 17:26 ` Steve Longerbeam
2016-07-06 23:00 ` [PATCH 07/11] media: adv7180: change mbus format to UYVY Steve Longerbeam
2016-07-07 15:18 ` Lars-Peter Clausen
2016-07-08 10:52 ` Niklas Söderlund
2016-07-07 15:25 ` Tim Harvey
2016-07-06 23:00 ` [PATCH 08/11] adv7180: send V4L2_EVENT_SOURCE_CHANGE on std change Steve Longerbeam
2016-07-07 15:27 ` Tim Harvey
2016-07-06 23:00 ` [PATCH 09/11] v4l: Add signal lock status to source change events Steve Longerbeam
2016-07-06 23:00 ` [PATCH 10/11] media: adv7180: enable lock/unlock interrupts Steve Longerbeam
2016-07-06 23:00 ` [PATCH 11/11] media: adv7180: fix field type Steve Longerbeam
2016-07-07 14:37 ` [PATCH 00/11] adv7180 subdev fixes Tim Harvey
2016-07-20 0:03 ` [PATCH v2 00/10] adv7180 subdev fixes, v2 Steve Longerbeam
2016-07-20 0:03 ` [PATCH v2 01/10] v4l: of: add "newavmode" property for Analog Devices codecs Steve Longerbeam
2016-07-20 7:37 ` Hans Verkuil
2016-07-20 17:14 ` Steve Longerbeam
2016-07-20 0:03 ` [PATCH v2 02/10] media: adv7180: Fix broken interrupt register access Steve Longerbeam
2016-07-20 0:03 ` [PATCH v2 03/10] media: adv7180: define more registers Steve Longerbeam
2016-07-20 8:54 ` Lars-Peter Clausen
2016-07-20 0:03 ` [PATCH v2 04/10] media: adv7180: add support for NEWAVMODE Steve Longerbeam
2016-07-20 0:03 ` [PATCH v2 05/10] media: adv7180: add power pin control Steve Longerbeam
2016-07-20 8:53 ` Lars-Peter Clausen
2016-07-20 0:03 ` [PATCH v2 06/10] media: adv7180: implement g_parm Steve Longerbeam
2016-07-20 0:03 ` [PATCH v2 07/10] media: adv7180: change mbus format to UYVY Steve Longerbeam
2016-07-20 0:03 ` [PATCH v2 08/10] v4l: Add signal lock status to source change events Steve Longerbeam
2016-07-20 0:03 ` [PATCH v2 09/10] media: adv7180: enable lock/unlock interrupts Steve Longerbeam
2016-07-20 0:03 ` [PATCH v2 10/10] media: adv7180: fix field type Steve Longerbeam
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=577E76D7.9090609@metafoo.de \
--to=lars@metafoo.de \
--cc=linux-media@vger.kernel.org \
--cc=slongerbeam@gmail.com \
--cc=steve_longerbeam@mentor.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).