From: Colin Ian King <colin.king@canonical.com>
To: Mauro Carvalho Chehab <mchehab@s-opensource.com>
Cc: Mauro Carvalho Chehab <mchehab@kernel.org>,
linux-media@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] [media] mb86a20s: remove redundant check if val is less than zero
Date: Fri, 15 Jul 2016 16:45:42 +0100 [thread overview]
Message-ID: <57890526.2080902@canonical.com> (raw)
In-Reply-To: <20160715122008.20c5f59d@recife.lan>
On 15/07/16 16:20, Mauro Carvalho Chehab wrote:
> Em Tue, 12 Jul 2016 10:30:51 +0100
> Colin King <colin.king@canonical.com> escreveu:
>
>> From: Colin Ian King <colin.king@canonical.com>
>>
>> The result of mb86a20s_readreg(state, 0x0a) & 0xf is always in the range
>> 0x00 to 0x0f and can never be negative, so remove the redundant check
>> of the result being less than zero.
>>
>> Signed-off-by: Colin Ian King <colin.king@canonical.com>
>> ---
>> drivers/media/dvb-frontends/mb86a20s.c | 2 --
>> 1 file changed, 2 deletions(-)
>>
>> diff --git a/drivers/media/dvb-frontends/mb86a20s.c b/drivers/media/dvb-frontends/mb86a20s.c
>> index fb88ddd..0205846 100644
>> --- a/drivers/media/dvb-frontends/mb86a20s.c
>> +++ b/drivers/media/dvb-frontends/mb86a20s.c
>> @@ -302,8 +302,6 @@ static int mb86a20s_read_status(struct dvb_frontend *fe, enum fe_status *status)
>> *status = 0;
>>
>> val = mb86a20s_readreg(state, 0x0a) & 0xf;
>> - if (val < 0)
>> - return val;
>
> Actually, mb86a20s_readreg() can return a negative value.
Oops, yep, clearly my code is stupid. I'll send a fix soon.
>
> Please change the above logic to first check for the value returned
> from mb86a20s_readreg() and then apply the bitmask.
>
> Thanks,
> Mauro
>
>>
>> if (val >= 2)
>> *status |= FE_HAS_SIGNAL;
>
>
>
> Thanks,
> Mauro
>
prev parent reply other threads:[~2016-07-15 15:46 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-07-12 9:30 [PATCH] [media] mb86a20s: remove redundant check if val is less than zero Colin King
2016-07-15 15:20 ` Mauro Carvalho Chehab
2016-07-15 15:45 ` Colin Ian King [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=57890526.2080902@canonical.com \
--to=colin.king@canonical.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-media@vger.kernel.org \
--cc=mchehab@kernel.org \
--cc=mchehab@s-opensource.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).