Re: [PATCH 01/12] dt-bindings: firmware: convert meson_sm.txt to dt-schema

Krzysztof Kozlowski
2022-11-18T14:46:38Z

On 18/11/2022 15:33, Neil Armstrong wrote:
> Convert the Amlogic Secure Monitor bindings to dt-schema.
>
> Signed-off-by: Neil Armstrong <neil.armstrong@linaro.org>
> ---
> .../bindings/firmware/amlogic,meson-gxbb-sm.yaml | 36 ++++++++++++++++++++++
> .../bindings/firmware/meson/meson_sm.txt | 15 ---------
> 2 files changed, 36 insertions(+), 15 deletions(-)
>
> diff --git a/Documentation/devicetree/bindings/firmware/amlogic,meson-gxbb-sm.yaml b/Documentation/devicetree/bindings/firmware/amlogic,meson-gxbb-sm.yaml
> new file mode 100644
> index 000000000000..33d1408610cf
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/firmware/amlogic,meson-gxbb-sm.yaml
> @@ -0,0 +1,36 @@
> +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause)
> +%YAML 1.2
> +---
> +$id: http://devicetree.org/schemas/firmware/amlogic,meson-gxbb-sm.yaml#
> +$schema: http://devicetree.org/meta-schemas/core.yaml#
> +
> +title: Amlogic Secure Monitor (SM)
> +
> +description:
> + In the Amlogic SoCs the Secure Monitor code is used to provide access to the
> + NVMEM, enable JTAG, set USB boot, etc...
> +
> +maintainers:
> + - Neil Armstrong <neil.armstrong@linaro.org>
> +
> +properties:
> + compatible:
> + const: amlogic,meson-gxbb-sm
> +
> +patternProperties:
> + "power-controller":

This looks like a property, not a pattern.

> + type: object
> + $ref: /schemas/power/amlogic,meson-sec-pwrc.yaml#

Would be nice to add it here to example and drop from
amlogic,meson-sec-pwrc.yaml (unless it will be used by more schemas?).

Best regards,
Krzysztof