Re: [PATCH 10/12] dt-bindings: mmc: convert amlogic,meson-gx.txt to dt-schema

Krzysztof Kozlowski
2022-11-18T15:00:42Z

On 18/11/2022 15:33, Neil Armstrong wrote:
> Convert the Amlogic SD / eMMC controller for S905/GXBB family SoCs
> to dt-schema.
>
> Signed-off-by: Neil Armstrong <neil.armstrong@linaro.org>
> ---
> .../bindings/mmc/amlogic,meson-gx-mmc.yaml | 78 ++++++++++++++++++++++
> .../devicetree/bindings/mmc/amlogic,meson-gx.txt | 39 -----------
> 2 files changed, 78 insertions(+), 39 deletions(-)
>
> diff --git a/Documentation/devicetree/bindings/mmc/amlogic,meson-gx-mmc.yaml b/Documentation/devicetree/bindings/mmc/amlogic,meson-gx-mmc.yaml
> new file mode 100644
> index 000000000000..c9545334fd99
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/mmc/amlogic,meson-gx-mmc.yaml
> @@ -0,0 +1,78 @@
> +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause)
> +%YAML 1.2
> +---
> +$id: http://devicetree.org/schemas/mmc/amlogic,meson-gx-mmc.yaml#
> +$schema: http://devicetree.org/meta-schemas/core.yaml#
> +
> +title: Amlogic SD / eMMC controller for S905/GXBB family SoCs
> +
> +description:
> + The MMC 5.1 compliant host controller on Amlogic provides the
> + interface for SD, eMMC and SDIO devices
> +
> +maintainers:
> + - Neil Armstrong <neil.armstrong@linaro.org>
> +
> +allOf:
> + - $ref: mmc-controller.yaml#
> +
> +properties:
> + compatible:
> + oneOf:
> + - enum:
> + - amlogic,meson-gx-mmc
> + - amlogic,meson-axg-mmc
> + - items:
> + - enum:
> + - amlogic,meson-gxbb-mmc
> + - amlogic,meson-gxl-mmc
> + - amlogic,meson-gxm-mmc
> + - const: amlogic,meson-gx-mmc

Mention changes in commit msg. Anyway this might not match existing
usage in DTS. At least amlogic,meson-gxbb-mmc has different order.

> +
> + reg:
> + maxItems: 1
> +
> + interrupts:
> + maxItems: 1
> +
> + clocks:
> + maxItems: 3
> +
> + clock-names:
> + items:
> + - const: core
> + - const: clkin0
> + - const: clkin1
> +
> + resets:
> + maxItems: 1
> +
> + amlogic,dram-access-quirk:
> + type: boolean
> + description:
> + set when controller's internal DMA engine cannot access the DRAM memory,
> + like on the G12A dedicated SDIO controller.
> +
> +required:
> + - compatible
> + - reg
> + - interrupts
> + - clocks
> + - clock-names
> + - resets
> +
> +unevaluatedProperties: false
> +
> +examples:
> + - |
> + #include <dt-bindings/interrupt-controller/irq.h>
> + #include <dt-bindings/interrupt-controller/arm-gic.h>
> + mmc@70000 {
> + compatible = "amlogic,meson-gx-mmc";
> + reg = <0x70000 0x2000>;
> + interrupts = <GIC_SPI 216 IRQ_TYPE_EDGE_RISING>;
> + clocks = <&clk_mmc>, <&xtal>, <&clk_div>;
> + clock-names = "core", "clkin0", "clkin1";
> + pinctrl-0 = <&emm_pins>;
> + resets = <&reset_mmc>;

Use 4 spaces for example indentation.

Best regards,
Krzysztof