Re: [PATCH 08/12] dt-bindings: timer: convert timer/amlogic,meson7-timer.txt to dt-schema

Krzysztof Kozlowski
2022-11-18T14:53:54Z

On 18/11/2022 15:33, Neil Armstrong wrote:
> Convert the Amlogic Meson6 SoCs Timer Controller bindings to dt-schema.
>
> Signed-off-by: Neil Armstrong <neil.armstrong@linaro.org>
> ---
> .../bindings/timer/amlogic,meson6-timer.txt | 22 ---------
> .../bindings/timer/amlogic,meson6-timer.yaml | 53 ++++++++++++++++++++++
> 2 files changed, 53 insertions(+), 22 deletions(-)
>
> diff --git a/Documentation/devicetree/bindings/timer/amlogic,meson6-timer.txt b/Documentation/devicetree/bindings/timer/amlogic,meson6-timer.txt
> deleted file mode 100644
> index a9da22bda912..000000000000
> --- a/Documentation/devicetree/bindings/timer/amlogic,meson6-timer.txt
> +++ /dev/null
> @@ -1,22 +0,0 @@
> -Amlogic Meson6 SoCs Timer Controller
> -
> -Required properties:
> -
> -- compatible : should be "amlogic,meson6-timer"
> -- reg : Specifies base physical address and size of the registers.
> -- interrupts : The four interrupts, one for each timer event
> -- clocks : phandles to the pclk (system clock) and XTAL clocks
> -- clock-names : must contain "pclk" and "xtal"
> -
> -Example:
> -
> -timer@c1109940 {
> - compatible = "amlogic,meson6-timer";
> - reg = <0xc1109940 0x14>;
> - interrupts = <GIC_SPI 10 IRQ_TYPE_EDGE_RISING>,
> - <GIC_SPI 11 IRQ_TYPE_EDGE_RISING>,
> - <GIC_SPI 6 IRQ_TYPE_EDGE_RISING>,
> - <GIC_SPI 29 IRQ_TYPE_EDGE_RISING>;
> - clocks = <&xtal>, <&clk81>;
> - clock-names = "xtal", "pclk";
> -};
> diff --git a/Documentation/devicetree/bindings/timer/amlogic,meson6-timer.yaml b/Documentation/devicetree/bindings/timer/amlogic,meson6-timer.yaml
> new file mode 100644
> index 000000000000..ffcb137e720e
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/timer/amlogic,meson6-timer.yaml
> @@ -0,0 +1,53 @@
> +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause)
> +%YAML 1.2
> +---
> +$id: http://devicetree.org/schemas/timer/amlogic,meson6-timer.yaml#
> +$schema: http://devicetree.org/meta-schemas/core.yaml#
> +
> +title: Amlogic Meson6 SoCs Timer Controller
> +
> +maintainers:
> + - Neil Armstrong <neil.armstrong@linaro.org>
> + - Martin Blumenstingl <martin.blumenstingl@googlemail.com>
> +
> +properties:
> + compatible:
> + const: amlogic,meson6-timer
> +
> + reg:
> + maxItems: 1
> +
> + interrupts:

I think it is worth to add here description, that these are per-timer
interrupts.

Reviewed-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>

Best regards,
Krzysztof