Re: [PATCH 02/12] dt-bindings: nvmem: convert amlogic-efuse.txt to dt-schema

Krzysztof Kozlowski
2022-11-18T14:48:26Z

On 18/11/2022 15:33, Neil Armstrong wrote:
> Convert the Amlogic Meson GX eFuse bindings to dt-schema.
>
> Signed-off-by: Neil Armstrong <neil.armstrong@linaro.org>
> ---
> .../bindings/nvmem/amlogic,meson-gxbb-efuse.yaml | 52 ++++++++++++++++++++++
> .../devicetree/bindings/nvmem/amlogic-efuse.txt | 48 --------------------
> 2 files changed, 52 insertions(+), 48 deletions(-)
>
> diff --git a/Documentation/devicetree/bindings/nvmem/amlogic,meson-gxbb-efuse.yaml b/Documentation/devicetree/bindings/nvmem/amlogic,meson-gxbb-efuse.yaml
> new file mode 100644
> index 000000000000..1d88f7eee840
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/nvmem/amlogic,meson-gxbb-efuse.yaml
> @@ -0,0 +1,52 @@
> +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause)
> +%YAML 1.2
> +---
> +$id: http://devicetree.org/schemas/nvmem/amlogic,meson-gxbb-efuse.yaml#
> +$schema: http://devicetree.org/meta-schemas/core.yaml#
> +
> +title: Amlogic Meson GX eFuse
> +
> +maintainers:
> + - Neil Armstrong <neil.armstrong@linaro.org>
> +
> +allOf:
> + - $ref: nvmem.yaml#
> +
> +properties:
> + compatible:
> + const: amlogic,meson-gxbb-efuse
> +
> + clocks:
> + maxItems: 1
> +
> + secure-monitor:
> + description: phandle to the secure-monitor node

This does not look like standard property, so you need the type ($ref).

> +
> +required:
> + - compatible
> + - clocks
> + - secure-monitor
> +

Best regards,
Krzysztof