Re: [PATCH v7 2/2] media: Add a driver for the ov5645 camera sensor.

[Todor Tomov <todor.tomov@linaro.org>]

Hi Laurent,

Thank you once again for the review.

On 11/14/2016 02:38 PM, Laurent Pinchart wrote:
> Hi Todor,
> 
> Thank you for the patch.
> 
> On Monday 14 Nov 2016 12:24:36 Todor Tomov wrote:
>> The ov5645 sensor from Omnivision supports up to 2592x1944
>> and CSI2 interface.
>>
>> The driver adds support for the following modes:
>> - 1280x960
>> - 1920x1080
>> - 2592x1944
>>
>> Output format is packed 8bit UYVY.
>>
>> Signed-off-by: Todor Tomov <todor.tomov@linaro.org>
>> ---
>>  drivers/media/i2c/Kconfig  |   12 +
>>  drivers/media/i2c/Makefile |    1 +
>>  drivers/media/i2c/ov5645.c | 1352 +++++++++++++++++++++++++++++++++++++++++
>>  3 files changed, 1365 insertions(+)
>>  create mode 100644 drivers/media/i2c/ov5645.c
> 
> [snip]
> 
>> diff --git a/drivers/media/i2c/ov5645.c b/drivers/media/i2c/ov5645.c
>> new file mode 100644
>> index 0000000..2b33bc6
>> --- /dev/null
>> +++ b/drivers/media/i2c/ov5645.c
> 
> [snip]
> 
>> +static const struct ov5645_mode_info *
>> +ov5645_find_nearest_mode(unsigned int width, unsigned int height)
>> +{
>> +       unsigned int i;
>> +
>> +       for (i = ARRAY_SIZE(ov5645_mode_info_data) - 1; i >= 0; i--) {
>> +               if (ov5645_mode_info_data[i].width <= width &&
>> +                   ov5645_mode_info_data[i].height <= height)
>> +                       break;
>> +       }
>> +
>> +       if (i < 0)
> 
> i needs to be int for this condition to be true.

Oops, I'll fix this for the next version. Let's wait for other feedback too until then.

> 
> Apart from that,
> 
> Reviewed-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
> 
>> +               i = 0;
>> +
>> +       return &ov5645_mode_info_data[i];
>> +}
> 

-- 
Best regards,
Todor Tomov