linux-media.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: A Sun <as1033x@comcast.net>
To: Sean Young <sean@mess.org>
Cc: linux-media@vger.kernel.org,
	Mauro Carvalho Chehab <mchehab@osg.samsung.com>
Subject: Re: [PATCH 0/3] [media] mceusb: RX -EPIPE lockup fault and more
Date: Sun, 26 Mar 2017 12:36:10 -0400	[thread overview]
Message-ID: <58D7EDFA.3090903@comcast.net> (raw)
In-Reply-To: <20170326102748.GA1672@gofer.mess.org>

On 3/26/2017 6:27 AM, Sean Young wrote:
...

>> +		status = usb_submit_urb(ir->urb_in, GFP_ATOMIC);
> 
> This can be GFP_KERNEL.
> 
...

>> +	rc_free_device(ir->rc);
> 
> That change is wrong and will cause a double free.
> 
>>  	usb_kill_urb(ir->urb_in);
>>  	usb_free_urb(ir->urb_in);
>>  	usb_free_coherent(dev, ir->len_in, ir->buf_in, ir->dma_in);
> 
> Would you be able to split this into multiple commits please?
> 
> Thanks,
> Sean
> 

Hi Sean,

Thank you for the quick reply, review, corrections, and suggestions. Please bear with me since this is my first contribution for Linux. The patch production submission/review process is entirely new to me at this time.

I'll perform the corrections in the forthcoming replies containing the split patches:
    [PATCH 1/3] [media] mceusb: RX -EPIPE (urb status = -32) lockup failure fix
    [PATCH 2/3] [media] mceusb: sporadic RX truncation corruption fix
    [PATCH 3/3] [media] mceusb: fix inaccurate debug buffer dumps and misleading debug messages

Thanks again. ..A Sun

  reply	other threads:[~2017-03-26 16:37 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-03-25 16:59 [PATCH] mceusb: RX -EPIPE lockup fault and more A Sun
2017-03-26 10:27 ` Sean Young
2017-03-26 16:36   ` A Sun [this message]
2017-03-26 18:28   ` [PATCH 1/3] [media] mceusb: RX -EPIPE (urb status = -32) lockup failure fix A Sun
2017-03-26 20:31     ` Sean Young
2017-03-27  8:18       ` A Sun
2017-03-28 20:25         ` Sean Young
2017-03-29  1:40           ` A Sun
2017-03-29 21:06             ` Sean Young
2017-03-29 22:04               ` A Sun
2017-03-30  7:12                 ` Sean Young
2017-03-30 16:35                   ` A Sun
2017-03-26 18:33   ` [PATCH 2/3] [media] mceusb: sporadic RX truncation corruption fix A Sun
2017-03-26 19:04   ` [PATCH 3/3] [media] mceusb: fix inaccurate debug buffer dumps,and misleading debug messages A Sun

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=58D7EDFA.3090903@comcast.net \
    --to=as1033x@comcast.net \
    --cc=linux-media@vger.kernel.org \
    --cc=mchehab@osg.samsung.com \
    --cc=sean@mess.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).