From: Steve Longerbeam <slongerbeam@gmail.com>
To: Cihangir Akturk <cakturk@gmail.com>
Cc: p.zabel@pengutronix.de, mchehab@kernel.org,
gregkh@linuxfoundation.org, linux-media@vger.kernel.org,
devel@driverdev.osuosl.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] [media] media: imx: depends on V4L2 sub-device userspace API
Date: Mon, 14 Aug 2017 10:57:46 -0700 [thread overview]
Message-ID: <5ac43a35-f7ec-7ffc-3e6e-c0af8f4ac497@gmail.com> (raw)
In-Reply-To: <1502708457-13344-1-git-send-email-cakturk@gmail.com>
Hi Akturk, this has already been fixed, see
4560cb4a0c ("media: imx: add VIDEO_V4L2_SUBDEV_API dependency").
Steve
On 08/14/2017 04:00 AM, Cihangir Akturk wrote:
> This driver uses various v4l2_subdev_get_try_*() functions provided by
> V4L2 sub-device userspace API. Current configuration of Kconfig file
> allows us to enable VIDEO_IMX_MEDIA without enabling this API. This
> breaks the build of driver.
>
> Depend on VIDEO_V4L2_SUBDEV_API to fix this issue.
>
> Signed-off-by: Cihangir Akturk <cakturk@gmail.com>
> ---
> drivers/staging/media/imx/Kconfig | 3 ++-
> 1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/staging/media/imx/Kconfig b/drivers/staging/media/imx/Kconfig
> index 7eff50b..d8c3890 100644
> --- a/drivers/staging/media/imx/Kconfig
> +++ b/drivers/staging/media/imx/Kconfig
> @@ -1,6 +1,7 @@
> config VIDEO_IMX_MEDIA
> tristate "i.MX5/6 V4L2 media core driver"
> - depends on MEDIA_CONTROLLER && VIDEO_V4L2 && ARCH_MXC && IMX_IPUV3_CORE
> + depends on MEDIA_CONTROLLER && VIDEO_V4L2 && VIDEO_V4L2_SUBDEV_API && \
> + ARCH_MXC && IMX_IPUV3_CORE
> select V4L2_FWNODE
> ---help---
> Say yes here to enable support for video4linux media controller
next prev parent reply other threads:[~2017-08-14 17:57 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-08-14 11:00 [PATCH] [media] media: imx: depends on V4L2 sub-device userspace API Cihangir Akturk
2017-08-14 17:57 ` Steve Longerbeam [this message]
2017-08-14 20:15 ` Cihangir Akturk
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5ac43a35-f7ec-7ffc-3e6e-c0af8f4ac497@gmail.com \
--to=slongerbeam@gmail.com \
--cc=cakturk@gmail.com \
--cc=devel@driverdev.osuosl.org \
--cc=gregkh@linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-media@vger.kernel.org \
--cc=mchehab@kernel.org \
--cc=p.zabel@pengutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox