From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-7.0 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS, URIBL_BLOCKED autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id E5D5AC28CC5 for ; Wed, 5 Jun 2019 21:08:19 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id BC4E92075B for ; Wed, 5 Jun 2019 21:08:19 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726581AbfFEVIP (ORCPT ); Wed, 5 Jun 2019 17:08:15 -0400 Received: from relay2-d.mail.gandi.net ([217.70.183.194]:36131 "EHLO relay2-d.mail.gandi.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726464AbfFEVIP (ORCPT ); Wed, 5 Jun 2019 17:08:15 -0400 X-Originating-IP: 93.29.109.196 Received: from collins (196.109.29.93.rev.sfr.net [93.29.109.196]) (Authenticated sender: paul.kocialkowski@bootlin.com) by relay2-d.mail.gandi.net (Postfix) with ESMTPSA id 9B30F40003; Wed, 5 Jun 2019 21:08:07 +0000 (UTC) Message-ID: <5c2217a4e80eaaa6a8eefd8752ce9a86933d0a80.camel@bootlin.com> Subject: Re: [PATCH 5/7] media: cedrus: Don't set chroma size for scale & rotation From: Paul Kocialkowski To: Jernej Skrabec , maxime.ripard@bootlin.com Cc: wens@csie.org, mchehab@kernel.org, gregkh@linuxfoundation.org, linux-media@vger.kernel.org, devel@driverdev.osuosl.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org Date: Wed, 05 Jun 2019 23:08:07 +0200 In-Reply-To: <20190530211516.1891-6-jernej.skrabec@siol.net> References: <20190530211516.1891-1-jernej.skrabec@siol.net> <20190530211516.1891-6-jernej.skrabec@siol.net> Content-Type: text/plain; charset="UTF-8" User-Agent: Evolution 3.32.1 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Sender: linux-media-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-media@vger.kernel.org Hi, Le jeudi 30 mai 2019 à 23:15 +0200, Jernej Skrabec a écrit : > Scale and rotation are currently not implemented, so it makes no sense to > set chroma size for it. > > Signed-off-by: Jernej Skrabec Acked-by: Paul Kocialkowski Cheers, Paul > --- > drivers/staging/media/sunxi/cedrus/cedrus_hw.c | 3 --- > 1 file changed, 3 deletions(-) > > diff --git a/drivers/staging/media/sunxi/cedrus/cedrus_hw.c b/drivers/staging/media/sunxi/cedrus/cedrus_hw.c > index 9c5819def186..9de20ae47916 100644 > --- a/drivers/staging/media/sunxi/cedrus/cedrus_hw.c > +++ b/drivers/staging/media/sunxi/cedrus/cedrus_hw.c > @@ -79,9 +79,6 @@ void cedrus_dst_format_set(struct cedrus_dev *dev, > reg = VE_PRIMARY_OUT_FMT_NV12; > cedrus_write(dev, VE_PRIMARY_OUT_FMT, reg); > > - reg = VE_CHROMA_BUF_LEN_SDRT(chroma_size / 2); > - cedrus_write(dev, VE_CHROMA_BUF_LEN, reg); > - > reg = chroma_size / 2; > cedrus_write(dev, VE_PRIMARY_CHROMA_BUF_LEN, reg); >