Linux Media Controller development
 help / color / mirror / Atom feed
From: Bingbu Cao <bingbu.cao@linux.intel.com>
To: Sakari Ailus <sakari.ailus@linux.intel.com>, linux-media@vger.kernel.org
Cc: rajmohan.mani@intel.com, tfiga@chromium.org
Subject: Re: [PATCH 1/1] ipu3-cio2: Set CSI-2 receiver sub-device entity function
Date: Tue, 19 Mar 2019 10:58:38 +0800	[thread overview]
Message-ID: <5c46f27d-3adc-c1f6-a830-cd4005b17391@linux.intel.com> (raw)
In-Reply-To: <20190318155509.29279-1-sakari.ailus@linux.intel.com>

Reviewed-by: Bingbu Cao <bingbu.cao@intel.com>

On 3/18/19 11:55 PM, Sakari Ailus wrote:
> Set the entity function for the four CSI-2 receiver sub-devices the driver
> creates. This avoids a kernel warning from each as well.
> 
> Signed-off-by: Sakari Ailus <sakari.ailus@linux.intel.com>
> ---
>  drivers/media/pci/intel/ipu3/ipu3-cio2.c | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/drivers/media/pci/intel/ipu3/ipu3-cio2.c b/drivers/media/pci/intel/ipu3/ipu3-cio2.c
> index 617fb2e944dc3..b76dff851f3d2 100644
> --- a/drivers/media/pci/intel/ipu3/ipu3-cio2.c
> +++ b/drivers/media/pci/intel/ipu3/ipu3-cio2.c
> @@ -1601,6 +1601,7 @@ static int cio2_queue_init(struct cio2_device *cio2, struct cio2_queue *q)
>  	subdev->owner = THIS_MODULE;
>  	snprintf(subdev->name, sizeof(subdev->name),
>  		 CIO2_ENTITY_NAME " %td", q - cio2->queue);
> +	subdev->entity.function = MEDIA_ENT_F_VID_IF_BRIDGE;
>  	v4l2_set_subdevdata(subdev, cio2);
>  	r = v4l2_device_register_subdev(&cio2->v4l2_dev, subdev);
>  	if (r) {
> 

      reply	other threads:[~2019-03-19  2:51 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-03-18 15:55 [PATCH 1/1] ipu3-cio2: Set CSI-2 receiver sub-device entity function Sakari Ailus
2019-03-19  2:58 ` Bingbu Cao [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=5c46f27d-3adc-c1f6-a830-cd4005b17391@linux.intel.com \
    --to=bingbu.cao@linux.intel.com \
    --cc=linux-media@vger.kernel.org \
    --cc=rajmohan.mani@intel.com \
    --cc=sakari.ailus@linux.intel.com \
    --cc=tfiga@chromium.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox