From: Steve Longerbeam <slongerbeam@gmail.com>
To: Fabio Estevam <festevam@gmail.com>,
Philipp Zabel <p.zabel@pengutronix.de>
Cc: Sakari Ailus <sakari.ailus@linux.intel.com>,
Hans Verkuil <hverkuil@xs4all.nl>,
linux-media <linux-media@vger.kernel.org>
Subject: Re: 'bad remote port parent' warnings
Date: Fri, 23 Nov 2018 14:37:54 -0800 [thread overview]
Message-ID: <5d63d8ba-94d5-ffb6-cd7c-3217138c5ad4@gmail.com> (raw)
In-Reply-To: <CAOMZO5CRWC1qbYa3wAYfd+_ig0s9Bq2Z8Hz1SmM95Zuxb6LqRw@mail.gmail.com>
Hi Fabio,
On 11/22/18 11:17 AM, Fabio Estevam wrote:
> Hi Philipp,
>
> On Thu, Nov 22, 2018 at 2:27 PM Philipp Zabel <p.zabel@pengutronix.de> wrote:
>
>> There are empty endpoint nodes (without remote-endpoint property)
>> labeled ipu1_csi[01]_mux_from_parallel_sensor in the i.MX6 device trees
>> for board DT implementers' convenience. See commit 2539f517acbdc ("ARM:
>> dts: imx6qdl: Add video multiplexers, mipi_csi, and their connections").
>>
>> We had a discussion about this issue in February when this caused a
>> probing error: https://patchwork.kernel.org/patch/10234469/
> Thanks for the clarification.
>
> We could demote the warning to a debug message, make the wording a bit
>> less misleading (there is no bad remote port parent, there is just no
>> remote endpoint at all), or we could just accept the error message for
> Something like this?
>
> --- a/drivers/media/v4l2-core/v4l2-fwnode.c
> +++ b/drivers/media/v4l2-core/v4l2-fwnode.c
> @@ -613,7 +613,7 @@ v4l2_async_notifier_fwnode_parse_endpoint(struct
> device *dev,
> asd->match.fwnode =
> fwnode_graph_get_remote_port_parent(endpoint);
> if (!asd->match.fwnode) {
> - dev_warn(dev, "bad remote port parent\n");
> + dev_dbg(dev, "no remote endpoint found\n");
> ret = -ENOTCONN;
> goto out_err;
> }
>
> And how should we treat these error probes?
>
> [ 3.449564] imx-ipuv3 2400000.ipu: driver could not parse
> port@1/endpoint@0 (-22)
> [ 3.457342] imx-ipuv3-csi: probe of imx-ipuv3-csi.1 failed with error -22
> [ 3.464498] imx-ipuv3 2800000.ipu: driver could not parse
> port@0/endpoint@0 (-22)
> [ 3.472120] imx-ipuv3-csi: probe of imx-ipuv3-csi.4 failed with error -22
Yes, this is a regression caused by the imx subdev notifier patches.
I've already sent a patch to the list for this, see
https://www.spinics.net/lists/linux-media/msg141809.html
Steve
next prev parent reply other threads:[~2018-11-24 9:24 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-11-20 12:10 'bad remote port parent' warnings Fabio Estevam
2018-11-20 12:15 ` Sakari Ailus
2018-11-20 12:21 ` Fabio Estevam
2018-11-22 16:27 ` Philipp Zabel
2018-11-22 19:17 ` Fabio Estevam
2018-11-23 12:35 ` Sakari Ailus
2018-11-23 12:54 ` Fabio Estevam
2018-11-23 22:37 ` Steve Longerbeam [this message]
2018-11-24 15:20 ` Fabio Estevam
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5d63d8ba-94d5-ffb6-cd7c-3217138c5ad4@gmail.com \
--to=slongerbeam@gmail.com \
--cc=festevam@gmail.com \
--cc=hverkuil@xs4all.nl \
--cc=linux-media@vger.kernel.org \
--cc=p.zabel@pengutronix.de \
--cc=sakari.ailus@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).