From mboxrd@z Thu Jan 1 00:00:00 1970 Return-path: Received: from mail-pg0-f68.google.com ([74.125.83.68]:43648 "EHLO mail-pg0-f68.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932250AbeAYAO0 (ORCPT ); Wed, 24 Jan 2018 19:14:26 -0500 Subject: Re: [PATCH] staging: imx-media-vdic: fix inconsistent IS_ERR and PTR_ERR To: "Gustavo A. R. Silva" , Philipp Zabel , Mauro Carvalho Chehab , Greg Kroah-Hartman , Arnd Bergmann Cc: linux-media@vger.kernel.org, devel@driverdev.osuosl.org, linux-kernel@vger.kernel.org, "Gustavo A. R. Silva" References: <20180124004340.GA25212@embeddedgus> From: Steve Longerbeam Message-ID: <5e53d6d8-d336-da37-fe12-0638904e1799@gmail.com> Date: Wed, 24 Jan 2018 16:14:19 -0800 MIME-Version: 1.0 In-Reply-To: <20180124004340.GA25212@embeddedgus> Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit Content-Language: en-US Sender: linux-media-owner@vger.kernel.org List-ID: Acked-by: Steve Longerbeam On 01/23/2018 04:43 PM, Gustavo A. R. Silva wrote: > Fix inconsistent IS_ERR and PTR_ERR in vdic_get_ipu_resources. > The proper pointer to be passed as argument is ch. > > This issue was detected with the help of Coccinelle. > > Fixes: 0b2e9e7947e7 ("media: staging/imx: remove confusing IS_ERR_OR_NULL usage") > Signed-off-by: Gustavo A. R. Silva > --- > drivers/staging/media/imx/imx-media-vdic.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/staging/media/imx/imx-media-vdic.c b/drivers/staging/media/imx/imx-media-vdic.c > index 433474d..ed35684 100644 > --- a/drivers/staging/media/imx/imx-media-vdic.c > +++ b/drivers/staging/media/imx/imx-media-vdic.c > @@ -177,7 +177,7 @@ static int vdic_get_ipu_resources(struct vdic_priv *priv) > priv->vdi_in_ch = ch; > > ch = ipu_idmac_get(priv->ipu, IPUV3_CHANNEL_MEM_VDI_NEXT); > - if (IS_ERR(priv->vdi_in_ch_n)) { > + if (IS_ERR(ch)) { > err_chan = IPUV3_CHANNEL_MEM_VDI_NEXT; > ret = PTR_ERR(ch); > goto out_err_chan;