Re: [PATCH v4 08/14] media: ipu6: Always close firmware stream

[Bingbu Cao <bingbu.cao@linux.intel.com>]

Sakari,

Thanks for the patch.
Reviewed-by: Bingbu Cao <bingbu.cao@intel.com>

On 1/8/26 4:17 PM, Sakari Ailus wrote:
> Close the firmware stream even when disabling a stream on an upstream
> sub-device fails. This allows the firmware to release resources related to
> a stream that is stopped in any case.
> 
> Suggested-by: Bingbu Cao <bingbu.cao@linux.intel.com>
> Signed-off-by: Sakari Ailus <sakari.ailus@linux.intel.com>
> ---
>  drivers/media/pci/intel/ipu6/ipu6-isys-video.c | 5 ++---
>  1 file changed, 2 insertions(+), 3 deletions(-)
> 
> diff --git a/drivers/media/pci/intel/ipu6/ipu6-isys-video.c b/drivers/media/pci/intel/ipu6/ipu6-isys-video.c
> index 919b77107cef..54d861aca008 100644
> --- a/drivers/media/pci/intel/ipu6/ipu6-isys-video.c
> +++ b/drivers/media/pci/intel/ipu6/ipu6-isys-video.c
> @@ -1036,11 +1036,10 @@ int ipu6_isys_video_set_streaming(struct ipu6_isys_video *av, int state,
>  			sd->name, r_pad->index, stream_mask);
>  		ret = v4l2_subdev_disable_streams(sd, r_pad->index,
>  						  stream_mask);
> -		if (ret) {
> +		if (ret)
>  			dev_err(dev, "stream off %s failed with %d\n", sd->name,
>  				ret);
> -			return ret;
> -		}
> +
>  		close_streaming_firmware(av);
>  	} else {
>  		ret = start_stream_firmware(av, bl);
> 

-- 
Best regards,
Bingbu Cao