From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 4D26BEE49A4 for ; Mon, 21 Aug 2023 03:17:48 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232614AbjHUDRs (ORCPT ); Sun, 20 Aug 2023 23:17:48 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:59608 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232603AbjHUDRr (ORCPT ); Sun, 20 Aug 2023 23:17:47 -0400 Received: from mgamail.intel.com (mgamail.intel.com [192.55.52.120]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 9FF389C for ; Sun, 20 Aug 2023 20:17:45 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1692587865; x=1724123865; h=subject:to:cc:references:from:message-id:date: mime-version:in-reply-to:content-transfer-encoding; bh=3bClO7m6XPtzYpBnOgLtY0G3urlr3dZBjbwYe6BWqyk=; b=nEz/ZcERG0hwIudichP12kW51JAzzHAuCBtnI2rLWoTUB93rFwzK98KR 6HOMdRzdn90bW+wqg4oEcM/yZOuUzQxV/OdC9p1uBS4h3L5jLkDA7Xr+r 2X4Mk7F6KVJ2ifZBgLOpxJGTopogFbAKiPp3FfT/K0Lsc+2BVFy4rAyF+ nnh96eCgvx/tEQf/xiT6TWVJzO9YLX2lYzG6+hVkoyIUL+ydzQVxpznQ3 gQDaCFxSrJrCPRUv5T9ZrkjVIxR9mhVzOksDvIO2C3YA0QKb5Tz1+0Gq8 yeWyDNelwqWIRj+wRte5vcK0faayzTxTW9Wiy492zSd+d8bJKnoGjoJxL w==; X-IronPort-AV: E=McAfee;i="6600,9927,10808"; a="372383672" X-IronPort-AV: E=Sophos;i="6.01,189,1684825200"; d="scan'208";a="372383672" Received: from orsmga003.jf.intel.com ([10.7.209.27]) by fmsmga104.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 20 Aug 2023 20:17:44 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6600,9927,10808"; a="685516425" X-IronPort-AV: E=Sophos;i="6.01,189,1684825200"; d="scan'208";a="685516425" Received: from ipu5-build.bj.intel.com (HELO [10.238.232.139]) ([10.238.232.139]) by orsmga003.jf.intel.com with ESMTP; 20 Aug 2023 20:17:39 -0700 Subject: Re: [PATCH 00/15] Intel IPU6 and IPU6 input system drivers To: Claus Stovgaard , bingbu.cao@intel.com, linux-media@vger.kernel.org, sakari.ailus@linux.intel.com, laurent.pinchart@ideasonboard.com Cc: ilpo.jarvinen@linux.intel.com, tfiga@chromium.org, senozhatsky@chromium.org, andriy.shevchenko@linux.intel.com, hdegoede@redhat.com, tomi.valkeinen@ideasonboard.com, tian.shu.qiu@intel.com, hongju.wang@intel.com References: <20230727071558.1148653-1-bingbu.cao@intel.com> <769ebe9f8eb88b2c07eae5910fc7d79c1ff888cb.camel@gmail.com> From: Bingbu Cao Message-ID: <5fb07c7d-390c-d7ae-c74b-8e03c75f636c@linux.intel.com> Date: Mon, 21 Aug 2023 11:14:32 +0800 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.10.0 MIME-Version: 1.0 In-Reply-To: <769ebe9f8eb88b2c07eae5910fc7d79c1ff888cb.camel@gmail.com> Content-Type: text/plain; charset=windows-1252 Content-Language: en-US Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-media@vger.kernel.org Hi, Claus, Thanks for your mail. On 8/20/23 11:09 PM, Claus Stovgaard wrote: > On Thu, 2023-07-27 at 15:15 +0800, bingbu.cao@intel.com wrote: >> From: Bingbu Cao >> >> This patch series adds a driver for Intel IPU6 input system. >> IPU6 is the sixth generation of Imaging Processing Unit, it is a PCI >> device which can be found in some Intel Client Platforms. User can >> use >> IPU6 to capture images from MIPI camera sensors. >> >> > > Hello Bingbu. > > First thanks for your work in upstreaming the IPU6 isys driver, and the > updates with v1 of the patch series. > > I am trying to test it on a Dell XPS 9320 (0AF3) laptop > > First - The patch series does not apply cleanly on linus 6.5-rc6, nor > the linux-media master. I think it is caused by some media changes was queued after I send this patch - such as ipu-bridge, ivsc, v4l2-async, etc. So it needs some rebase work. > > For v6.5-rc6 I have an issue with > > Patch failed at 0012 media: add Kconfig and Makefile for IPU6 > When you have resolved this problem, run "git am --continue". > If you prefer to skip this patch, run "git am --skip" instead. > To restore the original branch and stop patching, run "git am --abort". > error: drivers/media/pci/intel/Kconfig: does not exist in index > error: patch failed: drivers/media/pci/intel/Makefile:4 > error: drivers/media/pci/intel/Makefile: patch does not apply > > For linux media it fails after commit > https://git.linuxtv.org/media_tree.git/commit/?id=dd61c2a380037166517214957790a1486ae5d348 > media: mediatek: vcodec: Consider vdecsys presence in reg range check > > As next commit is > https://git.linuxtv.org/media_tree.git/commit/?id=bda8953e8c3e7ecbbf6cb1be11790496300e3961 > media: v4l: async: Drop v4l2_async_nf_parse_fwnode_endpoints() > > It fails on the v4l parts, and of cause the newer commits regarding > v4l: async in the linux-media master branch. So the IPU6 patch series > need a refresh to fit the linux-media. > > I did a custom branch from linus tag v6.5-rc5 with the commits from > linux-media up to the "Drop v4l2_async_nf_parse_fwnode_endpoints()" and > then applied the IPU6 patches on top. > https://github.com/frosteyes/linux/tree/fe/v6.5-rc5/media_test > > With this I am able to load the IPU6 modules, but I have problems with > the sensor. > > The sensor module is loaded - named ov01a10 but the probe function is > not run - as far as I can see > > Also in /sys/kernel/debug/v4l2-async/pending_async_subdevices I have it > as pending > > ipu6: > [fwnode] dev=nil, node=\_SB.PC00.LNK1 > > Looking at the /sys/bus/acpi/devices I can see the sensor device with a > status of 15 (cat OVTI01A0\:00/status) > > Will continue investigating, but I would like any input in getting the > driver up an running and testing on this Dell laptop. I think it should > be very close to working. Do you any failure log for ov01a10? For Dell XPS 9320, the camera sensor module has a dependency on Intel IVSC driver, so please make sure you have the latest ivsc driver. I remember they are already in media tree. I will check again with latest IVSC driver, feel free to mail me or Wentong Wu meanwhile if you have any problems for camera sensor and IVSC. > > Regards > Claus Stovgaaard > -- Best regards, Bingbu Cao