From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx0b-0031df01.pphosted.com (mx0b-0031df01.pphosted.com [205.220.180.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 4F4FE2405EC for ; Tue, 18 Nov 2025 22:00:59 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.180.131 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1763503261; cv=none; b=EnIOd7fOH79DTYDh2G9JyU5kfnGjORUq+oN9bRKLKzsKjmEL8s13Zhmp7HvqieNgOI05OZoIEFpNgIFpLSSJ6um9cCqrSWKMitu1U+VcYxt8mlbCbxG+teVe6dX0MwH0o9KtFDjLK5AoVzGN1UJghszKUek5CKUxlDnKoQnhios= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1763503261; c=relaxed/simple; bh=Dih9fXevBS3u9kszVPmtQnrlg5dIJndE5uxACAe+v0Y=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=UrBvhRCeO6tZ1knwOcmCEGPnhOr5coBkLEzAw/h+kdzp1zvy/3BggFKLT7ya1CTzkQCjIAaXHXr6yVBwTFfO9RQxb4rxqOlYaHlvBDB7JOqs5VgF4jVA8GTxcbhVjiyKkJCyRaqbB/lD/G9+hxRwxPPML/OB7OQgytEf9Kbt9jY= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=aDPXMimC; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=AnG8bAUX; arc=none smtp.client-ip=205.220.180.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="aDPXMimC"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="AnG8bAUX" Received: from pps.filterd (m0279870.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 5AIHAlXR2664727 for ; Tue, 18 Nov 2025 22:00:59 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= XJ/krFdrukxS2jHjMwJ/crT5obHVqzWDf9mfKu1vzco=; b=aDPXMimC7P9Rq/2c poyupxweKVoSSLk40X7Q6skRynMwg5cAIZytxpn0XG581Q0g39luwtpWaEa0Jt3X uPVh2J4/CHv1KWAzZUxZuXC1pjNEZluQaOTbrSAZcWhrotFj619A3cwmUpUijAfl ObNq5qr99JEhx1JkBDC1Fc4ijH4I6qMH/tKtuJAVTpsOmIF6kKpQh5T7vDIYRqTm N71omRjDCWHwQfO/Odnkn69yCY1APiY+pIIJmeNcOhfdYTX/9+xD0yqSmZLt/pzt 38M50D/w3XrJ1wTWeKXyO9S2Cj8bIcq6sfef8ggCOUYmcJU9W2Q29rcv+MxZgRqJ 3SFGtQ== Received: from mail-pj1-f69.google.com (mail-pj1-f69.google.com [209.85.216.69]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4agpjka0jn-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Tue, 18 Nov 2025 22:00:59 +0000 (GMT) Received: by mail-pj1-f69.google.com with SMTP id 98e67ed59e1d1-3416dc5752aso18288517a91.1 for ; Tue, 18 Nov 2025 14:00:58 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1763503258; x=1764108058; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=XJ/krFdrukxS2jHjMwJ/crT5obHVqzWDf9mfKu1vzco=; b=AnG8bAUXvR9USTqKihm9yC9I4fpxrHulcRHmqeEOWfLYcAeL1B7fe2ry2XSvyoOzKP 52uMhGz6ig4S2NeU01+/0/ACCaMDpq2n6Dabqwnq+vjdYJUBymqcA87M8zJU9t26ubQ6 ZrcMySVJYD7r7+KyAwYblvIKzef3Ro0xxkG4jliCWlUPSGSUWE2yn24FHA+VB/6H90tx iKkgmcDksn9UgR8gryqlq6/lmFgehMd+VqaADiwVkktufc5HLbduMKnmT7vwKKI4F2cu QYRH2CJPIM8/AvnqOvikYgDJ/tye96W4bDnH8vY3BM9HxpreX+4BMH4dOXRsJ0loYogx k+CQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1763503258; x=1764108058; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-gg:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=XJ/krFdrukxS2jHjMwJ/crT5obHVqzWDf9mfKu1vzco=; b=setkZ5S7b5D5S/mSxxJTVax/z4E43OYD+F1Rnxo5paUSCbU2+eYfvHRQqRptpb6lCE SBfLSxppwcPeKL+iq2NYioZd8y2fjsLqvGFiDzFG7xq8tYENsgRHmCLIh/KUitoY8txy zh80jOo4buSVUNQm4OYX+UZ/mmGw8U6HCZF5NshLxxgr1FZLQ5pr5s97Z1Gdjd3jDGUa I6GXXgAfcZEvcaQj1xgpmBsiGZ5sMY3CAeEQDb9uRHJlOhe0TAghjGrcyOw+N1unCtA5 nMko7SPgzOabfKIScxKU6mUMa6f01D13hK3deDWN6//Ax+i6IFihC/HsULC2zoZEd1Fx yKIg== X-Forwarded-Encrypted: i=1; AJvYcCU8c9zjpwjHyJ9+vQPM75zXv5dcC+wMqa4oOg3feiyKU78Z3tc0ENE+vAWH4X5PIm0m1K+Lvxg5NzJMaw==@vger.kernel.org X-Gm-Message-State: AOJu0YwhEwdQl7OJ4IxSl6M4V4TQ1o21lxlF+gEU5nTiwlEgxyjYJOMV 6nnhLGwSwvlkWX4AntfRRUCYDS3b8m/ZBXdNL93NK+pLQGS8wT5fGg6Ukh0ZfBNg6vZa44PPrSD Up9F0+7sO7l+1n/v0LHu1GhB3maZtpSRExkZz0ZfNCvY9AorgRmHFBFretxbaDHWNlw== X-Gm-Gg: ASbGnctB64iKnLjUDjJGfP1UM8YCwQobSqdzakamYaEFq0F2hxmpty6SSRfulAGdM0H jDHI0TmBFNifcmBgHl81fpYf+Vq2+0oqtAuH+IfJzhyOuoKkpwChohH1P0SxBmPe3JDYT7hTMcB VVFxFQzz7Ypq2bONzwRzQuqZhw73vqbC5sRoAJwG7kzIHtklWbbi+XJwYZjJQTdbExtnH/lqY9j fCtQqGEYOH+1qywSQ87gZa7yYvI4Uc5kjxBVws4mFBw/Nguus0HEtKTecVr9OLi/Htv4H9z69ln +XvHkStsLqvmIyIByE/Zc0/4wgYRfy1FpQ3D7CISeLxqNvfH5L7zCj7F8T5a+lFMloIsoqw57OX 10PA5q9BRZPINLyIOaPY5jxXAxtlNDN4KTAU8tGLr X-Received: by 2002:a17:90b:5804:b0:343:5f43:933e with SMTP id 98e67ed59e1d1-343fa52ba9fmr18896520a91.19.1763503257912; Tue, 18 Nov 2025 14:00:57 -0800 (PST) X-Google-Smtp-Source: AGHT+IENuyMCSbnJeXHIJwaNL3s/cjdlr4lhkPOILg4vP2RvQYr6dD7lW+iuOT8xJ6HGirA+lTfVUA== X-Received: by 2002:a17:90b:5804:b0:343:5f43:933e with SMTP id 98e67ed59e1d1-343fa52ba9fmr18896496a91.19.1763503257444; Tue, 18 Nov 2025 14:00:57 -0800 (PST) Received: from [192.168.1.57] ([98.148.145.183]) by smtp.gmail.com with ESMTPSA id 98e67ed59e1d1-345bbfe30e9sm441894a91.5.2025.11.18.14.00.55 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 18 Nov 2025 14:00:57 -0800 (PST) Message-ID: <5fee98e6-019c-41f1-b13b-ce06c736147d@oss.qualcomm.com> Date: Tue, 18 Nov 2025 14:00:54 -0800 Precedence: bulk X-Mailing-List: linux-media@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v6 4/5] media: qcom: camss: csid: Add support for CSID 1080 To: Bryan O'Donoghue , Hangxiang Ma , Loic Poulain , Robert Foss , Andi Shyti , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Todor Tomov , Vladimir Zapolskiy , Mauro Carvalho Chehab Cc: linux-arm-msm@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-media@vger.kernel.org, aiqun.yu@oss.qualcomm.com, tingwei.zhang@oss.qualcomm.com, trilok.soni@oss.qualcomm.com, yijie.yang@oss.qualcomm.com, Jingyi Wang , Atiya Kailany References: <20251113-add-support-for-camss-on-kaanapali-v6-0-1e6038785a8e@oss.qualcomm.com> <20251113-add-support-for-camss-on-kaanapali-v6-4-1e6038785a8e@oss.qualcomm.com> Content-Language: en-US From: Vijay Kumar Tumati In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit X-Proofpoint-ORIG-GUID: JeEf8AQ3rMum3Q_v_dj7aDgvnOJ7dDUS X-Proofpoint-GUID: JeEf8AQ3rMum3Q_v_dj7aDgvnOJ7dDUS X-Proofpoint-Spam-Details-Enc: AW1haW4tMjUxMTE4MDE3OCBTYWx0ZWRfX919RlJ9ScoW6 pNHwq4VKmTDRDnETsfoCcKXjhHVgfYcQxT2w21KovN782PHAYQJkutrufKWq0xgd7GoYjilPoCV Ublalj2QbwccCM/gsnMZt+NJaQnKenQoe415GUGN9zEFKxzjuAzRN7BnfPuJsyr/GzzWf7UQzTi zNClBl1V69PSNmmND0Mi/OwRSxJPYUZ+b2jqWIXrf3E2viAEDzrhVigvNUwE/Z7IMv07VVkTkoq vajflTh2HAmQjyiuVSxvuyrtWODmhrERRzAr5T/7A9n+nuHdcMaoYY0c7JFkD2s+HjeJLlHHrIU b47CberajuLzrMGC3Rk8V1FSxMgfFr6O4+ki3oA10KcXV5G5Yh2N0iZq+5lw4Pqv7BlXP48dn/b alt4O+vybOQBLIxRYq45UYV7PTcqwg== X-Authority-Analysis: v=2.4 cv=N/Yk1m9B c=1 sm=1 tr=0 ts=691cec9b cx=c_pps a=vVfyC5vLCtgYJKYeQD43oA==:117 a=BiHMn5M11h/vNwziJwzFrg==:17 a=IkcTkHD0fZMA:10 a=6UeiqGixMTsA:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=GDeJsyEDr6o3VvAygAYA:9 a=3ZKOabzyN94A:10 a=QEXdDO2ut3YA:10 a=rl5im9kqc5Lf4LNbBjHf:22 X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1121,Hydra:6.1.9,FMLib:17.12.100.49 definitions=2025-11-18_03,2025-11-18_02,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 clxscore=1015 spamscore=0 bulkscore=0 adultscore=0 priorityscore=1501 phishscore=0 impostorscore=0 malwarescore=0 suspectscore=0 lowpriorityscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2510240001 definitions=main-2511180178 On 11/18/2025 1:41 AM, Bryan O'Donoghue wrote: > On 14/11/2025 03:29, Hangxiang Ma wrote: >> +    /* note: for non-RDI path, this should be format->decode_format */ >> +    val |= DECODE_FORMAT_PAYLOAD_ONLY << RDI_CFG0_DECODE_FORMAT; >> +    val |= vc << RDI_CFG0_VC; >> +    val |= format->data_type << RDI_CFG0_DT; >> +    writel(val, csid->base + CSID_RDI_CFG0(vc)); > > Why not just add that code now ? > > --- > bod Hi Bryan, I think this has been carried over from previous versions and the comment is trying to say that, for RDI path alone we can just dump the data into the buffer without any decoding and the format becomes more relevant for pixel processing as CSID needs to decode the input byte stream first. Either way, if this is a stand alone entity, we can discuss offline and push another patch series to handle this? Please advise. Thanks.