Re: [PATCH v6 4/5] media: qcom: camss: csid: Add support for CSID 1080

Vijay Kumar Tumati
2025-11-18T22:00:59Z

On 11/18/2025 1:41 AM, Bryan O'Donoghue wrote:
> On 14/11/2025 03:29, Hangxiang Ma wrote:
>> +    /* note: for non-RDI path, this should be format->decode_format */
>> +    val |= DECODE_FORMAT_PAYLOAD_ONLY << RDI_CFG0_DECODE_FORMAT;
>> +    val |= vc << RDI_CFG0_VC;
>> +    val |= format->data_type << RDI_CFG0_DT;
>> +    writel(val, csid->base + CSID_RDI_CFG0(vc));
>
> Why not just add that code now ?
>
> ---
> bod
Hi Bryan, I think this has been carried over from previous versions and
the comment is trying to say that, for RDI path alone we can just dump
the data into the buffer without any decoding and the format becomes
more relevant for pixel processing as CSID needs to decode the input
byte stream first. Either way, if this is a stand alone entity, we can
discuss offline and push another patch series to handle this? Please
advise. Thanks.