Re: [PATCH v6 1/5] media: dt-bindings: Add CAMSS device for Kaanapali

Bryan O'Donoghue
2025-11-18T15:00:23Z

On 14/11/2025 03:29, Hangxiang Ma wrote:
> + <0x0 0x0900e000 0x0 0x1000>,

Why aren't you starting @ 0x0900e000 ? seems to be omitting some of the
registers in the ICP block. Should start at +0xd000 not +0xe000 ?

> + <0x0 0x0902e000 0x0 0x1000>,

Same here.

> + <0x0 0x090d7000 0x0 0x20000>,
> + <0x0 0x0904e000 0x0 0x1000>,
> + <0x0 0x0904d000 0x0 0x1000>,
> + <0x0 0x09057000 0x0 0x40000>,
> + <0x0 0x09147000 0x0 0x580>,
> + <0x0 0x09148000 0x0 0x580>,
> + <0x0 0x09149000 0x0 0x580>,
> + <0x0 0x0914a000 0x0 0x580>,
> + <0x0 0x0914b000 0x0 0x580>,
> + <0x0 0x093fd000 0x0 0x400>,
> + <0x0 0x093fe000 0x0 0x400>,
> + <0x0 0x093ff000 0x0 0x400>;

The rest of these registers start at the defined block addresses in the
documentation.

Unless there's a very good reason for that, please amend.

---
bod