public inbox for linux-media@vger.kernel.org
 help / color / mirror / Atom feed
From: Bard Eirik Winther <bwinther@cisco.com>
To: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
Cc: linux-media@vger.kernel.org, Hans Verkuil <hansverk@cisco.com>
Subject: Re: [PATCH 4/4] qv4l2: add OpenGL video render
Date: Tue, 16 Jul 2013 14:59:04 +0200	[thread overview]
Message-ID: <6029532.8F5QMT0oxE@bwinther> (raw)
In-Reply-To: <1609457.OFIJZjqBDN@avalon>

On Tuesday, July 16, 2013 02:01:45 PM you wrote:
> Hi Bård,
> 
> Thank you for the patches.
> 
> On Tuesday 16 July 2013 13:24:08 Bård Eirik Winther wrote:
> > The qv4l2 test utility now supports OpenGL-accelerated display of video.
> > This allows for using the graphics card to render the video content to
> > screen and to performing color space conversion.
> > 
> > Signed-off-by: Bård Eirik Winther <bwinther@cisco.com>
> > ---
> >  configure.ac                |   8 +-
> >  utils/qv4l2/Makefile.am     |   9 +-
> >  utils/qv4l2/capture-win.cpp | 559 +++++++++++++++++++++++++++++++++++++++--
> >  utils/qv4l2/capture-win.h   |  81 ++++++-
> >  utils/qv4l2/qv4l2.cpp       | 173 +++++++++++---
> >  utils/qv4l2/qv4l2.h         |   8 +
> >  6 files changed, 782 insertions(+), 56 deletions(-)
> 
> Is there a chance you could split the OpenGL code to separate classes, in a 
> separate source file ? This would allow implementing other renderers, such as 
> KMS planes on embedded devices.
> 
Hi.

Do you mean to separate the GL class only or all the different shaders/renderes as well?

Bård Winther

  reply	other threads:[~2013-07-16 12:59 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-07-16 11:24 [PATCH 0/4] OpenGL render for qv4l2 Bård Eirik Winther
2013-07-16 11:24 ` [PATCH 1/4] qv4l2: move function ctrlEvent Bård Eirik Winther
2013-07-16 11:24   ` [PATCH 2/4] qv4l2: add hotkeys for common operations Bård Eirik Winther
2013-07-16 11:24   ` [PATCH 3/4] qv4l2: fix CaptureWin mimimum size to match video fram size Bård Eirik Winther
2013-07-16 11:24   ` [PATCH 4/4] qv4l2: add OpenGL video render Bård Eirik Winther
2013-07-16 12:01     ` Laurent Pinchart
2013-07-16 12:59       ` Bard Eirik Winther [this message]
2013-07-16 13:05         ` Laurent Pinchart
     [not found] <201307171303.44303.hansverk@cisco.com>
2013-07-17 12:09 ` Bård Eirik Winther

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=6029532.8F5QMT0oxE@bwinther \
    --to=bwinther@cisco.com \
    --cc=hansverk@cisco.com \
    --cc=laurent.pinchart@ideasonboard.com \
    --cc=linux-media@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox