Re: [REVIEWv1 PATCH 5/5] DocBook v4l2: update the G/S_EDID documentation

Hans Verkuil
2014-03-07T14:31:30Z

Hi Laurent,

Thanks for reviewing this series so quickly. I've added your nitpick to my
tree and I plan to post the pull request on Monday.

Regards,

Hans

On 03/07/2014 03:25 PM, Laurent Pinchart wrote:
> Hi Hans,
>
> On Friday 07 March 2014 15:19:07 Hans Verkuil wrote:
>> On 03/07/2014 03:09 PM, Laurent Pinchart wrote:
>>> Hi Hans,
>>>
>>> Thank you for the patch.
>>>
>>> On Friday 07 March 2014 11:21:19 Hans Verkuil wrote:
>>>> From: Hans Verkuil <hans.verkuil@cisco.com>
>>>>
>>>> Document that it is now possible to call G/S_EDID from video nodes, not
>>>> just sub-device nodes. Add a note that -EINVAL will be returned if
>>>> the pad does not support EDIDs.
>>>>
>>>> Signed-off-by: Hans Verkuil <hans.verkuil@cisco.com>
>>>> ---
>>>>
>>>> Documentation/DocBook/media/v4l/v4l2.xml | 2 +-
>>>> .../DocBook/media/v4l/vidioc-subdev-g-edid.xml | 152
>>>> ------------------
>>>> 2 files changed, 1 insertion(+), 153 deletions(-)
>>>> delete mode 100644
>>>> Documentation/DocBook/media/v4l/vidioc-subdev-g-edid.xml
>>>
>>> The patch just removes the EDID ioctls documentation, I highly doubt that
>>> this is what you intended :-)
>>
>> Let's try again:
>
> Much better :-)
>
> Acked-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
>
> with a minor nitpicking comment below.
>
>> Document that it is now possible to call G/S_EDID from video nodes, not
>> just sub-device nodes. Add a note that -EINVAL will be returned if
>> the pad does not support EDIDs.
>>
>> Signed-off-by: Hans Verkuil <hans.verkuil@cisco.com>
>> ---
>> Documentation/DocBook/media/v4l/v4l2.xml | 2 +-
>> ...{vidioc-subdev-g-edid.xml => vidioc-g-edid.xml} | 36 +++++++++++--------
>> 2 files changed, 24 insertions(+), 14 deletions(-)
>> rename Documentation/DocBook/media/v4l/{vidioc-subdev-g-edid.xml =>
>> vidioc-g-edid.xml} (77%)
>
> [snip]
>
>> diff --git a/Documentation/DocBook/media/v4l/vidioc-subdev-g-edid.xml
>> b/Documentation/DocBook/media/v4l/vidioc-g-edid.xml similarity index 77%
>> rename from Documentation/DocBook/media/v4l/vidioc-subdev-g-edid.xml
>> rename to Documentation/DocBook/media/v4l/vidioc-g-edid.xml
>> index bbd18f0..becd7cb 100644
>> --- a/Documentation/DocBook/media/v4l/vidioc-subdev-g-edid.xml
>> +++ b/Documentation/DocBook/media/v4l/vidioc-g-edid.xml
>
> [snip]
>
>> @@ -56,12 +56,20 @@
>>
>> <refsect1>
>> Description
>> - These ioctls can be used to get or set an EDID associated with an
>> input pad
>> - from a receiver or an output pad of a transmitter subdevice.
>> + These ioctls can be used to get or set an EDID associated with an
>> input
>> + from a receiver or an output of a transmitter device. These ioctls can
>
> I would s/These ioctls/They/ here to avoid repeating "These ioctls" at the
> beginning of the two sentences.
>
>> be
>> + used with subdevice nodes (/dev/v4l-subdevX) or with video nodes
>> (/dev/videoX).
>> +
>