From: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
To: Michael Jones <michael.jones@matrix-vision.de>
Cc: linux-media ML <linux-media@vger.kernel.org>
Subject: Re: reading config parameters of omap3-isp subdevs
Date: Tue, 20 Mar 2012 00:22:04 +0100 [thread overview]
Message-ID: <6085689.3CUf0tMs8E@avalon> (raw)
In-Reply-To: <4F6348D7.9070409@matrix-vision.de>
Hi Michael,
On Friday 16 March 2012 15:06:15 Michael Jones wrote:
> Hi all,
>
> I am playing around with some parameters in the previewer on the ISP. With
> ioctl VIDIOC_OMAP3ISP_PRV_CFG I am able to write the various parameters but
> what I'm missing is a way to read them. For example, I have no way to adjust
> only coef2 in 'struct omap3isp_prev_wbal' while leaving the others
> unchanged. If I could first read the whole omap3isp_prev_wbal structure,
> then I could change just the things I want to change. This seems like it
> would be common functionality for such ioctls. I didn't find any previous
> discussion related to this.
>
> I could imagine either adding a r/w flag to 'struct
> omap3isp_prev_update_config' or adding a new ioctl entirely. I think I
> would prefer the r/w flag. Feedback?
>
> I noticed that other ISP subdevs have similar ioctls. Perhaps a similar
> thing would be useful there, but right now I'm only looking at the
> previewer.
Adding a R/W bit to the flag argument should indeed work. However, I'm
wondering what your use case for reading parameters back is. The preview
engine parameter structures seem pretty-much self-contained to me, I'm not
sure it would make sense to only modify one of the parameters.
--
Regards,
Laurent Pinchart
next prev parent reply other threads:[~2012-03-19 23:21 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-03-16 14:06 reading config parameters of omap3-isp subdevs Michael Jones
2012-03-19 23:22 ` Laurent Pinchart [this message]
2012-03-20 10:06 ` Michael Jones
2012-03-28 15:54 ` Laurent Pinchart
-- strict thread matches above, loose matches on Subject: below --
2012-03-25 23:42 Joshua Hintze
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=6085689.3CUf0tMs8E@avalon \
--to=laurent.pinchart@ideasonboard.com \
--cc=linux-media@vger.kernel.org \
--cc=michael.jones@matrix-vision.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).