public inbox for linux-media@vger.kernel.org
 help / color / mirror / Atom feed
* Re: IMX6 ADV7180 no /dev/media
       [not found] <CAJ+vNU3DPFEc6YnEfcYAv1=beJ96W5PSt=eBfoxCXqKnbNqfMg@mail.gmail.com>
@ 2017-09-15 22:26 ` Steve Longerbeam
  2017-09-15 23:28   ` Tim Harvey
  0 siblings, 1 reply; 6+ messages in thread
From: Steve Longerbeam @ 2017-09-15 22:26 UTC (permalink / raw)
  To: Tim Harvey, linux-media, Philipp Zabel; +Cc: Stephan Bauroth

Hi Tim,

On 09/15/2017 02:26 PM, Tim Harvey wrote:
> Greetings,
>
> I'm testing Linux master built with imx_v6_v7_defconfig on a GW51xx 
> which has an ADV7180 analog video decoder and am not seeing the imx6 
> /dev/media node get created:
>
> [    0.000000] OF: fdt: Machine model: Gateworks Ventana i.MX6 
> Dual/Quad GW51XX
> ...
> [    6.089039] imx-media: Registered subdev ipu1_vdic
> [    6.094505] imx-media: Registered subdev ipu2_vdic
> [    6.099851] imx-media: Registered subdev ipu1_ic_prp
> [    6.105074] imx-media: Registered subdev ipu1_ic_prpenc
> [    6.111346] ipu1_ic_prpenc: Registered ipu1_ic_prpenc capture as 
> /dev/video0
> [    6.119007] imx-media: Registered subdev ipu1_ic_prpvf
> [    6.124733] ipu1_ic_prpvf: Registered ipu1_ic_prpvf capture as 
> /dev/video1
> [    6.131867] imx-media: Registered subdev ipu2_ic_prp
> [    6.137125] imx-media: Registered subdev ipu2_ic_prpenc
> [    6.142921] ipu2_ic_prpenc: Registered ipu2_ic_prpenc capture as 
> /dev/video2
> [    6.150226] imx-media: Registered subdev ipu2_ic_prpvf
> [    6.155934] ipu2_ic_prpvf: Registered ipu2_ic_prpvf capture as 
> /dev/video3
> [    6.164011] imx-media: Registered subdev ipu1_csi0
> [    6.169768] ipu1_csi0: Registered ipu1_csi0 capture as /dev/video4
> [    6.176281] imx-media: Registered subdev ipu1_csi1
> [    6.181681] ipu1_csi1: Registered ipu1_csi1 capture as /dev/video5
> [    6.188189] imx-media: Registered subdev ipu2_csi0
> [    6.193680] ipu2_csi0: Registered ipu2_csi0 capture as /dev/video6
> [    6.200108] imx-media: Registered subdev ipu2_csi1
> [    6.205577] ipu2_csi1: Registered ipu2_csi1 capture as /dev/video7
> ...
> [   96.981117] adv7180 2-0020: chip found @ 0x20 (21a8000.i2c)
> [   97.019674] imx-media: Registered subdev adv7180 2-0020
> [   97.019712] imx-media capture-subsystem: Entity type for entity 
> adv7180 2-0020 was not initialized!
>
> I suspect the failure of the adv7180 is causing the issue. Steve 
> mentioned some time ago that this was an error that needed to be fixed 
> upstream but I'm not clear if that is still the case.
>

That does need fixing but is not the cause.

> I haven't looked at IMX media drivers since they were accepted to 
> mainline a few months back. Perhaps I'm simply forgetting to enable 
> something in the kernel that imx_v6_v7_defconfig doesn't turn on?

Yes, it looks like you are missing the video-mux. Enable CONFIG_VIDEO_MUX
and CONFIG_MUX_MMIO.

Steve

^ permalink raw reply	[flat|nested] 6+ messages in thread

* Re: IMX6 ADV7180 no /dev/media
  2017-09-15 22:26 ` IMX6 ADV7180 no /dev/media Steve Longerbeam
@ 2017-09-15 23:28   ` Tim Harvey
  2017-09-15 23:39     ` Steve Longerbeam
  0 siblings, 1 reply; 6+ messages in thread
From: Tim Harvey @ 2017-09-15 23:28 UTC (permalink / raw)
  To: Steve Longerbeam; +Cc: linux-media, Philipp Zabel, Stephan Bauroth

On Fri, Sep 15, 2017 at 3:26 PM, Steve Longerbeam <slongerbeam@gmail.com> wrote:
> Hi Tim,
>
>
> On 09/15/2017 02:26 PM, Tim Harvey wrote:
>>
>> Greetings,
>>
>> I'm testing Linux master built with imx_v6_v7_defconfig on a GW51xx which
>> has an ADV7180 analog video decoder and am not seeing the imx6 /dev/media
>> node get created:
>>
>> [    0.000000] OF: fdt: Machine model: Gateworks Ventana i.MX6 Dual/Quad
>> GW51XX
>> ...
>> [    6.089039] imx-media: Registered subdev ipu1_vdic
>> [    6.094505] imx-media: Registered subdev ipu2_vdic
>> [    6.099851] imx-media: Registered subdev ipu1_ic_prp
>> [    6.105074] imx-media: Registered subdev ipu1_ic_prpenc
>> [    6.111346] ipu1_ic_prpenc: Registered ipu1_ic_prpenc capture as
>> /dev/video0
>> [    6.119007] imx-media: Registered subdev ipu1_ic_prpvf
>> [    6.124733] ipu1_ic_prpvf: Registered ipu1_ic_prpvf capture as
>> /dev/video1
>> [    6.131867] imx-media: Registered subdev ipu2_ic_prp
>> [    6.137125] imx-media: Registered subdev ipu2_ic_prpenc
>> [    6.142921] ipu2_ic_prpenc: Registered ipu2_ic_prpenc capture as
>> /dev/video2
>> [    6.150226] imx-media: Registered subdev ipu2_ic_prpvf
>> [    6.155934] ipu2_ic_prpvf: Registered ipu2_ic_prpvf capture as
>> /dev/video3
>> [    6.164011] imx-media: Registered subdev ipu1_csi0
>> [    6.169768] ipu1_csi0: Registered ipu1_csi0 capture as /dev/video4
>> [    6.176281] imx-media: Registered subdev ipu1_csi1
>> [    6.181681] ipu1_csi1: Registered ipu1_csi1 capture as /dev/video5
>> [    6.188189] imx-media: Registered subdev ipu2_csi0
>> [    6.193680] ipu2_csi0: Registered ipu2_csi0 capture as /dev/video6
>> [    6.200108] imx-media: Registered subdev ipu2_csi1
>> [    6.205577] ipu2_csi1: Registered ipu2_csi1 capture as /dev/video7
>> ...
>> [   96.981117] adv7180 2-0020: chip found @ 0x20 (21a8000.i2c)
>> [   97.019674] imx-media: Registered subdev adv7180 2-0020
>> [   97.019712] imx-media capture-subsystem: Entity type for entity adv7180
>> 2-0020 was not initialized!
>>
>> I suspect the failure of the adv7180 is causing the issue. Steve mentioned
>> some time ago that this was an error that needed to be fixed upstream but
>> I'm not clear if that is still the case.
>>
>
> That does need fixing but is not the cause.
>
>> I haven't looked at IMX media drivers since they were accepted to mainline
>> a few months back. Perhaps I'm simply forgetting to enable something in the
>> kernel that imx_v6_v7_defconfig doesn't turn on?
>
>
> Yes, it looks like you are missing the video-mux. Enable CONFIG_VIDEO_MUX
> and CONFIG_MUX_MMIO.
>

Steve,

Indeed that was it! What clued you into that being the missing component?

Sounds like we need to enable that for imx_v6_v7_defconfig.

Thanks!

Tim

^ permalink raw reply	[flat|nested] 6+ messages in thread

* Re: IMX6 ADV7180 no /dev/media
  2017-09-15 23:28   ` Tim Harvey
@ 2017-09-15 23:39     ` Steve Longerbeam
  2017-09-15 23:46       ` Fabio Estevam
  0 siblings, 1 reply; 6+ messages in thread
From: Steve Longerbeam @ 2017-09-15 23:39 UTC (permalink / raw)
  To: Tim Harvey; +Cc: linux-media, Philipp Zabel, Stephan Bauroth



On 09/15/2017 04:28 PM, Tim Harvey wrote:
> On Fri, Sep 15, 2017 at 3:26 PM, Steve Longerbeam <slongerbeam@gmail.com> wrote:
>> Hi Tim,
>>
>>
>> On 09/15/2017 02:26 PM, Tim Harvey wrote:
>>> Greetings,
>>>
>>> I'm testing Linux master built with imx_v6_v7_defconfig on a GW51xx which
>>> has an ADV7180 analog video decoder and am not seeing the imx6 /dev/media
>>> node get created:
>>>
>>> [    0.000000] OF: fdt: Machine model: Gateworks Ventana i.MX6 Dual/Quad
>>> GW51XX
>>> ...
>>> [    6.089039] imx-media: Registered subdev ipu1_vdic
>>> [    6.094505] imx-media: Registered subdev ipu2_vdic
>>> [    6.099851] imx-media: Registered subdev ipu1_ic_prp
>>> [    6.105074] imx-media: Registered subdev ipu1_ic_prpenc
>>> [    6.111346] ipu1_ic_prpenc: Registered ipu1_ic_prpenc capture as
>>> /dev/video0
>>> [    6.119007] imx-media: Registered subdev ipu1_ic_prpvf
>>> [    6.124733] ipu1_ic_prpvf: Registered ipu1_ic_prpvf capture as
>>> /dev/video1
>>> [    6.131867] imx-media: Registered subdev ipu2_ic_prp
>>> [    6.137125] imx-media: Registered subdev ipu2_ic_prpenc
>>> [    6.142921] ipu2_ic_prpenc: Registered ipu2_ic_prpenc capture as
>>> /dev/video2
>>> [    6.150226] imx-media: Registered subdev ipu2_ic_prpvf
>>> [    6.155934] ipu2_ic_prpvf: Registered ipu2_ic_prpvf capture as
>>> /dev/video3
>>> [    6.164011] imx-media: Registered subdev ipu1_csi0
>>> [    6.169768] ipu1_csi0: Registered ipu1_csi0 capture as /dev/video4
>>> [    6.176281] imx-media: Registered subdev ipu1_csi1
>>> [    6.181681] ipu1_csi1: Registered ipu1_csi1 capture as /dev/video5
>>> [    6.188189] imx-media: Registered subdev ipu2_csi0
>>> [    6.193680] ipu2_csi0: Registered ipu2_csi0 capture as /dev/video6
>>> [    6.200108] imx-media: Registered subdev ipu2_csi1
>>> [    6.205577] ipu2_csi1: Registered ipu2_csi1 capture as /dev/video7
>>> ...
>>> [   96.981117] adv7180 2-0020: chip found @ 0x20 (21a8000.i2c)
>>> [   97.019674] imx-media: Registered subdev adv7180 2-0020
>>> [   97.019712] imx-media capture-subsystem: Entity type for entity adv7180
>>> 2-0020 was not initialized!
>>>
>>> I suspect the failure of the adv7180 is causing the issue. Steve mentioned
>>> some time ago that this was an error that needed to be fixed upstream but
>>> I'm not clear if that is still the case.
>>>
>> That does need fixing but is not the cause.
>>
>>> I haven't looked at IMX media drivers since they were accepted to mainline
>>> a few months back. Perhaps I'm simply forgetting to enable something in the
>>> kernel that imx_v6_v7_defconfig doesn't turn on?
>>
>> Yes, it looks like you are missing the video-mux. Enable CONFIG_VIDEO_MUX
>> and CONFIG_MUX_MMIO.
>>
> Steve,
>
> Indeed that was it! What clued you into that being the missing component?

It was easy :) There needs to be the following message from imx-media:

imx-media: Registered subdev ipu1_csi0_mux
imx-media: Registered subdev ipu2_csi1_mux

for quad, and

imx-media: Registered subdev ipu1_csi0_mux
imx-media: Registered subdev ipu1_csi1_mux

for D/L.

All imx6 platforms require the video-mux for video capture.

Steve

>
> Sounds like we need to enable that for imx_v6_v7_defconfig.

Agreed, but I notice now that CONFIG_MEDIA_CONTROLLER and
CONFIG_VIDEO_V4L2_SUBDEV_API are not enabled there anymore.
I guess there was some config conflict that necessitated disabling
them, but without them there is no media platform device support at
all anyway. Those must be enabled first before getting CONFIG_VIDEO_MUX.

Steve

^ permalink raw reply	[flat|nested] 6+ messages in thread

* Re: IMX6 ADV7180 no /dev/media
  2017-09-15 23:39     ` Steve Longerbeam
@ 2017-09-15 23:46       ` Fabio Estevam
  2017-09-16  0:08         ` Steve Longerbeam
  2017-09-17  0:48         ` Fabio Estevam
  0 siblings, 2 replies; 6+ messages in thread
From: Fabio Estevam @ 2017-09-15 23:46 UTC (permalink / raw)
  To: Steve Longerbeam; +Cc: Tim Harvey, linux-media, Philipp Zabel, Stephan Bauroth

Hi Steve,

On Fri, Sep 15, 2017 at 8:39 PM, Steve Longerbeam <slongerbeam@gmail.com> wrote:

> Agreed, but I notice now that CONFIG_MEDIA_CONTROLLER and
> CONFIG_VIDEO_V4L2_SUBDEV_API are not enabled there anymore.

I do see them enabled in mainline with imx_v6_v7_defconfig.

Tim,

Care to send the patch enabling CONFIG_VIDEO_MUX?

Thanks

^ permalink raw reply	[flat|nested] 6+ messages in thread

* Re: IMX6 ADV7180 no /dev/media
  2017-09-15 23:46       ` Fabio Estevam
@ 2017-09-16  0:08         ` Steve Longerbeam
  2017-09-17  0:48         ` Fabio Estevam
  1 sibling, 0 replies; 6+ messages in thread
From: Steve Longerbeam @ 2017-09-16  0:08 UTC (permalink / raw)
  To: Fabio Estevam; +Cc: Tim Harvey, linux-media, Philipp Zabel, Stephan Bauroth



On 09/15/2017 04:46 PM, Fabio Estevam wrote:
> Hi Steve,
>
> On Fri, Sep 15, 2017 at 8:39 PM, Steve Longerbeam <slongerbeam@gmail.com> wrote:
>
>> Agreed, but I notice now that CONFIG_MEDIA_CONTROLLER and
>> CONFIG_VIDEO_V4L2_SUBDEV_API are not enabled there anymore.
> I do see them enabled in mainline with imx_v6_v7_defconfig.

Ah, I was looking at mediatree/master, the commit that
enables MEDIA_CONTROLLER hasn't hit mediatree yet.

Steve

>
> Tim,
>
> Care to send the patch enabling CONFIG_VIDEO_MUX?
>
> Thanks

^ permalink raw reply	[flat|nested] 6+ messages in thread

* Re: IMX6 ADV7180 no /dev/media
  2017-09-15 23:46       ` Fabio Estevam
  2017-09-16  0:08         ` Steve Longerbeam
@ 2017-09-17  0:48         ` Fabio Estevam
  1 sibling, 0 replies; 6+ messages in thread
From: Fabio Estevam @ 2017-09-17  0:48 UTC (permalink / raw)
  To: Steve Longerbeam; +Cc: Tim Harvey, linux-media, Philipp Zabel, Stephan Bauroth

On Fri, Sep 15, 2017 at 8:46 PM, Fabio Estevam <festevam@gmail.com> wrote:

> Tim,
>
> Care to send the patch enabling CONFIG_VIDEO_MUX?

Nevermind. I have just sent it.

^ permalink raw reply	[flat|nested] 6+ messages in thread

end of thread, other threads:[~2017-09-17  0:48 UTC | newest]

Thread overview: 6+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
     [not found] <CAJ+vNU3DPFEc6YnEfcYAv1=beJ96W5PSt=eBfoxCXqKnbNqfMg@mail.gmail.com>
2017-09-15 22:26 ` IMX6 ADV7180 no /dev/media Steve Longerbeam
2017-09-15 23:28   ` Tim Harvey
2017-09-15 23:39     ` Steve Longerbeam
2017-09-15 23:46       ` Fabio Estevam
2017-09-16  0:08         ` Steve Longerbeam
2017-09-17  0:48         ` Fabio Estevam

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox