From: Dan Scally <dan.scally@ideasonboard.com>
To: Andy Shevchenko <andy@kernel.org>, Hans de Goede <hdegoede@redhat.com>
Cc: Sakari Ailus <sakari.ailus@linux.intel.com>,
Laurent Pinchart <laurent.pinchart@ideasonboard.com>,
Mauro Carvalho Chehab <mchehab@kernel.org>,
Kate Hsuan <hpa@redhat.com>, Hao Yao <hao.yao@intel.com>,
Bingbu Cao <bingbu.cao@intel.com>,
linux-media@vger.kernel.org
Subject: Re: [PATCH 09/12] media: ipu3-cio2: Move cio2_bridge_init() code into a new shared intel-cio2-bridge.ko
Date: Wed, 28 Jun 2023 14:53:00 +0200 [thread overview]
Message-ID: <615910df-2db4-453c-249b-8d4a33bc0ca3@ideasonboard.com> (raw)
In-Reply-To: <ZJtMysrWwpKb7woL@smile.fi.intel.com>
Hello all
On 27/06/2023 22:55, Andy Shevchenko wrote:
> On Tue, Jun 27, 2023 at 07:56:39PM +0200, Hans de Goede wrote:
>> Move all the code implementing cio2_bridge_init() into a new shared
>> intel-cio2-bridge.ko, so that it can be reused by the atomisp driver
>> (and maybe also by the future IPU6 CSI2 driver).
>>
>> Note this just moves a bunch of stuff around prefixes some symbols /
>> defines with intel_ / INTEL_ no functional changes.
> ...
>
>> +EXPORT_SYMBOL(intel_cio2_bridge_init);
> Why not GPL?
> Perhaps namespace?
>
> ...
>
> Seems to me that name CIO2 in AtomISP case sounds a bit weird.
> Maybe ipu/isp should be used instead?
I agree here, since it's a specific device. But there's already some picked patches to turn the
cio2-bridge into the ipu-bridge, so probably this needs to rebase on top of that work.
next prev parent reply other threads:[~2023-06-28 12:55 UTC|newest]
Thread overview: 33+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-06-27 17:56 [PATCH 00/12] media: intel-cio2-bridge: Add shared intel-cio2-bridge code, rework VCM instantiation Hans de Goede
2023-06-27 17:56 ` [PATCH 01/12] media: ipu3-cio2: Do not use on stack memory for software_node.name field Hans de Goede
2023-06-27 17:56 ` [PATCH 02/12] media: ipu3-cio2: Move initialization of node_names.vcm to cio2_bridge_init_swnode_names() Hans de Goede
2023-06-27 17:56 ` [PATCH 03/12] media: ipu3-cio2: Make cio2_bridge_init() take a regular struct device as argument Hans de Goede
2023-06-27 17:56 ` [PATCH 04/12] media: ipu3-cio2: Store dev pointer in struct cio2_bridge Hans de Goede
2023-06-27 17:56 ` [PATCH 05/12] media: ipu3-cio2: Only keep PLD around while parsing Hans de Goede
2023-06-27 17:56 ` [PATCH 06/12] media: ipu3-cio2: Add a cio2_bridge_parse_sensor_fwnode() helper function Hans de Goede
2023-06-27 20:39 ` Andy Shevchenko
2023-06-27 17:56 ` [PATCH 07/12] media: ipu3-cio2: Add a parse_sensor_fwnode callback to cio2_bridge_init() Hans de Goede
2023-06-27 17:56 ` [PATCH 08/12] media: ipu3-cio2: Add supported_sensors parameter " Hans de Goede
2023-06-27 17:56 ` [PATCH 09/12] media: ipu3-cio2: Move cio2_bridge_init() code into a new shared intel-cio2-bridge.ko Hans de Goede
2023-06-27 20:55 ` Andy Shevchenko
2023-06-28 12:53 ` Dan Scally [this message]
2023-06-27 17:56 ` [PATCH 10/12] media: atomisp: csi2-bridge: Switch to new common cio2_bridge_init() Hans de Goede
2023-06-27 17:56 ` [PATCH 11/12] media: intel-cio2-bridge: Add a runtime-pm device-link between VCM and sensor Hans de Goede
2023-06-27 21:03 ` Andy Shevchenko
2023-10-30 8:30 ` Bingbu Cao
2023-10-30 8:55 ` Sakari Ailus
2023-10-30 8:58 ` Hans de Goede
2023-10-30 9:23 ` Sakari Ailus
2023-11-01 6:26 ` Cao, Bingbu
2023-11-01 7:12 ` Sakari Ailus
2023-11-01 7:38 ` Cao, Bingbu
2023-11-02 13:35 ` Andy Shevchenko
2023-11-02 13:54 ` Hans de Goede
2023-11-03 2:01 ` Bingbu Cao
2023-06-27 17:56 ` [PATCH 12/12] [RFC] media: dw9719: Drop hack to enable "vsio" regulator Hans de Goede
2023-06-27 21:04 ` [PATCH 00/12] media: intel-cio2-bridge: Add shared intel-cio2-bridge code, rework VCM instantiation Andy Shevchenko
2023-06-28 1:19 ` Cao, Bingbu
2023-06-28 13:57 ` Hans de Goede
2023-06-29 8:22 ` Cao, Bingbu
2023-06-29 20:45 ` Hans de Goede
2023-06-30 9:07 ` Sakari Ailus
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=615910df-2db4-453c-249b-8d4a33bc0ca3@ideasonboard.com \
--to=dan.scally@ideasonboard.com \
--cc=andy@kernel.org \
--cc=bingbu.cao@intel.com \
--cc=hao.yao@intel.com \
--cc=hdegoede@redhat.com \
--cc=hpa@redhat.com \
--cc=laurent.pinchart@ideasonboard.com \
--cc=linux-media@vger.kernel.org \
--cc=mchehab@kernel.org \
--cc=sakari.ailus@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox