public inbox for linux-media@vger.kernel.org
 help / color / mirror / Atom feed
From: Bryan O'Donoghue <bod@kernel.org>
To: Krzysztof Kozlowski <krzk@kernel.org>,
	Bryan O'Donoghue <bryan.odonoghue@linaro.org>
Cc: Bjorn Andersson <andersson@kernel.org>,
	Michael Turquette <mturquette@baylibre.com>,
	Stephen Boyd <sboyd@kernel.org>, Rob Herring <robh@kernel.org>,
	Krzysztof Kozlowski <krzk+dt@kernel.org>,
	Conor Dooley <conor+dt@kernel.org>,
	Robert Foss <rfoss@kernel.org>, Todor Tomov <todor.too@gmail.com>,
	Mauro Carvalho Chehab <mchehab@kernel.org>,
	Konrad Dybcio <konradybcio@kernel.org>,
	Vladimir Zapolskiy <vladimir.zapolskiy@linaro.org>,
	linux-arm-msm@vger.kernel.org, linux-clk@vger.kernel.org,
	devicetree@vger.kernel.org, linux-kernel@vger.kernel.org,
	linux-media@vger.kernel.org
Subject: Re: [PATCH v10 1/7] dt-bindings: media: qcom,x1e80100-camss: Add simple-mfd compatible
Date: Tue, 17 Mar 2026 16:21:31 +0000	[thread overview]
Message-ID: <61fa4409-e19c-49d9-b7fa-dc6f8413c181@kernel.org> (raw)
In-Reply-To: <1671b8ce-cbf9-45ae-947b-f35d174be93e@kernel.org>

On 17/03/2026 16:00, Krzysztof Kozlowski wrote:
>>> I actually got the idea from:
>>>
>>> commit fe6a952b567f6a771d087d2e969914f31574d6ab
>>> Author: Krzysztof Kozlowski<krzk@kernel.org>
>>> Date:   Fri Jan 27 20:40:50 2023 +0100
>> If you refer to my commits, at least read them. Do you see children
>> there? Yes. You have none.
>>
>> Plus trying to get 13 year old legacy device without dtbs_check warnings
>> is different thing than correcting a recently introduced bindings.
>> Terrible example to take... And if you find example from 20 years ago,
>> it will be even worse.
>>
> One more thing, that commit was still correct because it fulfilled the
> simple-mfd requirement of lack of dependency on the parent. I do not
> believe your code fulfills it. I am pretty sure it does not.

Yeah I take the logic of that point:

CSIPHY here depends on the GDSC, power-domains and clocks we've listed, 
its not being supplied by any of the other blocks that live inside of 
the rest.

They don't require any resources from the parent and the parent consumes 
the child phys via phandles.

To my mind that fits the criteria you've set of !depends on parent.

---
bod

  reply	other threads:[~2026-03-17 16:21 UTC|newest]

Thread overview: 25+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-03-16  1:02 [PATCH v10 0/7] Add dt-bindings and dtsi changes for CAMSS on x1e80100 silicon Bryan O'Donoghue
2026-03-16  1:02 ` [PATCH v10 1/7] dt-bindings: media: qcom,x1e80100-camss: Add simple-mfd compatible Bryan O'Donoghue
2026-03-16  2:12   ` Vladimir Zapolskiy
2026-03-16  2:39     ` Dmitry Baryshkov
2026-03-16  9:28       ` Vladimir Zapolskiy
2026-03-16  7:29   ` Krzysztof Kozlowski
2026-03-16 12:01     ` Bryan O'Donoghue
2026-03-17 15:51       ` Krzysztof Kozlowski
2026-03-17 16:00         ` Krzysztof Kozlowski
2026-03-17 16:21           ` Bryan O'Donoghue [this message]
2026-03-17 16:29             ` Krzysztof Kozlowski
2026-03-17 17:29               ` Bryan O'Donoghue
2026-03-17 17:32                 ` Krzysztof Kozlowski
2026-03-16  1:02 ` [PATCH v10 2/7] dt-bindings: media: qcom,x1e80100-camss: Add optional PHY handle definitions Bryan O'Donoghue
2026-03-16  2:07   ` Vladimir Zapolskiy
2026-03-16  2:40     ` Dmitry Baryshkov
2026-03-16  2:50   ` Rob Herring (Arm)
2026-03-16  7:31   ` Krzysztof Kozlowski
2026-03-17  5:55     ` Bryan O'Donoghue
2026-03-16  1:02 ` [PATCH v10 3/7] dt-bindings: media: qcom,x1e80100-camss: Add support for combo-mode endpoints Bryan O'Donoghue
2026-03-16  1:02 ` [PATCH v10 4/7] dt-bindings: media: qcom,x1e80100-camss: Describe iommu entries Bryan O'Donoghue
2026-03-16  7:32   ` Krzysztof Kozlowski
2026-03-16  1:02 ` [PATCH v10 5/7] media: qcom: camss: Add legacy_phy flag to SoC definition structures Bryan O'Donoghue
2026-03-16  1:02 ` [PATCH v10 6/7] media: qcom: camss: Add support for PHY API devices Bryan O'Donoghue
2026-03-16  1:02 ` [PATCH v10 7/7] media: qcom: camss: Drop legacy PHY descriptions from x1e Bryan O'Donoghue

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=61fa4409-e19c-49d9-b7fa-dc6f8413c181@kernel.org \
    --to=bod@kernel.org \
    --cc=andersson@kernel.org \
    --cc=bryan.odonoghue@linaro.org \
    --cc=conor+dt@kernel.org \
    --cc=devicetree@vger.kernel.org \
    --cc=konradybcio@kernel.org \
    --cc=krzk+dt@kernel.org \
    --cc=krzk@kernel.org \
    --cc=linux-arm-msm@vger.kernel.org \
    --cc=linux-clk@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-media@vger.kernel.org \
    --cc=mchehab@kernel.org \
    --cc=mturquette@baylibre.com \
    --cc=rfoss@kernel.org \
    --cc=robh@kernel.org \
    --cc=sboyd@kernel.org \
    --cc=todor.too@gmail.com \
    --cc=vladimir.zapolskiy@linaro.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox