From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id A440CC77B73 for ; Tue, 30 May 2023 10:56:34 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231609AbjE3K4d (ORCPT ); Tue, 30 May 2023 06:56:33 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:44468 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231405AbjE3K40 (ORCPT ); Tue, 30 May 2023 06:56:26 -0400 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 12CC8CD for ; Tue, 30 May 2023 03:55:41 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1685444141; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=hX//i7eKthHlEADvre2Ih07qiiu9glDio+QitwtEYmg=; b=cw49XX2zhU+RmQWAsgfNMSUQqwuhowP5++chxUkQemvmZDBbt+wYKWoi2tLc+pRgRR02f0 ZQ7RvbLYp6SCbgAyeIg3jyA6lhdl46kWTTE7DFE6D4UQMHrzrKVsBwwrT944kAB9G2Ynm5 T5hsMKI9PHMkJFQe9+qywHU375MeoCU= Received: from mail-ed1-f72.google.com (mail-ed1-f72.google.com [209.85.208.72]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-451-bHgGJIeJMy6vporXQ1Pnmw-1; Tue, 30 May 2023 06:55:39 -0400 X-MC-Unique: bHgGJIeJMy6vporXQ1Pnmw-1 Received: by mail-ed1-f72.google.com with SMTP id 4fb4d7f45d1cf-513f337d478so3526194a12.3 for ; Tue, 30 May 2023 03:55:39 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1685444138; x=1688036138; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=hX//i7eKthHlEADvre2Ih07qiiu9glDio+QitwtEYmg=; b=L2Ps5YcDb8mREUS+UCFTFZYzME62/ml3WvcMJHti716UgUm0Vumgk4S+TXWDR04dUL HR7/+ETh56OV0gfejW+OspNRbEdGdHMcrv9gRrbf5bpAfclbGu54NuDGpon9y7tKmwS3 dFaX9CFxXSxyyEIMRS0Eb0GnlWMSI+i2TAaSOn0IvxVe0GN4k8XgADUr9aUBhqg12Ytb nqKR2dtA+wYBP+2BDbfknT3D2n/nuVlVF/tYFkPK/pobIFJNED2O2des8fOKpNIQRuZ/ 48jAPu0Cef+4+Uj16zLmVwfhvDiRjpQcMefPKdpRvTfFzX6wY/aTGWmtQt+fTClcwpQ9 CtXA== X-Gm-Message-State: AC+VfDzptEGq3MvfM3XZqde31vePNU2kTmMvT03dbqM11VylEv47IFmw vAMO/tRb81k0Ipq4ds9HlQWGF7Bo8+DNBmyL98xDaSUptAFKjUJL9Rz836jBFC7NR/Jo4xb+1fF +efd2h8FhhLSnF2rcqzQ9adM= X-Received: by 2002:a05:6402:1358:b0:514:91e5:d622 with SMTP id y24-20020a056402135800b0051491e5d622mr1255497edw.36.1685444138729; Tue, 30 May 2023 03:55:38 -0700 (PDT) X-Google-Smtp-Source: ACHHUZ4PkmRRttQVB8w9I6OMYkcvoHyNIJj8oetmf/+CT8a+6gTVhKQgbrQ7v2N8kExN6g+V2HKMMw== X-Received: by 2002:a05:6402:1358:b0:514:91e5:d622 with SMTP id y24-20020a056402135800b0051491e5d622mr1255490edw.36.1685444138466; Tue, 30 May 2023 03:55:38 -0700 (PDT) Received: from ?IPV6:2001:1c00:c32:7800:5bfa:a036:83f0:f9ec? (2001-1c00-0c32-7800-5bfa-a036-83f0-f9ec.cable.dynamic.v6.ziggo.nl. [2001:1c00:c32:7800:5bfa:a036:83f0:f9ec]) by smtp.gmail.com with ESMTPSA id j8-20020aa7ca48000000b00514971c293asm3030260edt.11.2023.05.30.03.55.37 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 30 May 2023 03:55:38 -0700 (PDT) Message-ID: <63bb6add-51cd-b2b5-e229-82009276549c@redhat.com> Date: Tue, 30 May 2023 12:55:37 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.10.0 Subject: Re: [PATCH 00/21] media: atomisp: Use selection API info to determine sensor padding Content-Language: en-US, nl To: Andy Shevchenko Cc: Mauro Carvalho Chehab , Sakari Ailus , Andy Shevchenko , Kate Hsuan , Tsuchiya Yuto , Yury Luneff , Nable , andrey.i.trufanov@gmail.com, Fabio Aiuto , linux-media@vger.kernel.org, linux-staging@lists.linux.dev References: <20230529103741.11904-1-hdegoede@redhat.com> From: Hans de Goede In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: linux-media@vger.kernel.org Hi Andy, On 5/29/23 23:59, Andy Shevchenko wrote: > On Mon, May 29, 2023 at 1:38 PM Hans de Goede wrote: >> >> Hi All, >> >> Here is my next round of atomisp work. >> >> The atomisp wants some extra padding for processing in the data it receives >> from the sensor. E.g. For 1600x1200 it wants to receive 1616x1216 from >> the sensor. Currently the private sensor driver copies it uses give it >> e.g. 1616x1216 and the ISP2 code then substracts 16 before reporting >> the resolution to userspace. >> >> This patch series adds support for the v4l2 selections API and specifically >> the crop target so that atomisp can request the extra padding from standard >> v4l2 sensor drivers. This is implemented / tested with the atomisp_ov2680 >> driver. >> >> Besides that there is the usual cleanups / prep work. >> >> With the padding solved, the last bit of private atomisp sensor API is >> gone now. So we can start working on getting rid of its private sensor >> driver copies. >> >> As mentioned in the updated TODO file the next step is to port >> various improvements from the atomisp_ov2680 private sensor driver >> to the generic ov2680 sensor driver (such as the selections support) >> and then switch to the generic ov2680 sensor driver. > > For non-commented > Reviewed-by: Andy Shevchenko > > If others will be addressed in the suggested way, feel free to add the > tag as well. Thank you for all the reviews. I've pushed this to my media-atomisp branch now with all remarks addressed: https://git.kernel.org/pub/scm/linux/kernel/git/hansg/linux.git/log/?h=media-atomisp Regards, Hans