Re: v4l2-async: regression due to endpoint matching

[Alexander Stein <alexander.stein@ew.tq-group.com>]

Hi Jacopo,

Am Freitag, 28. April 2023, 08:31:54 CEST schrieb Jacopo Mondi:
> Hi Alexander
> 
> On Fri, Apr 28, 2023 at 08:24:22AM +0200, Alexander Stein wrote:
> > Hi Jacopo,
> > 
> > Am Donnerstag, 27. April 2023, 18:01:38 CEST schrieb Jacopo Mondi:
> > > Hi Alexander
> > > 
> > > On Thu, Apr 27, 2023 at 04:40:46PM +0200, Alexander Stein wrote:
> > > > Hi all,
> > > > 
> > > > I have a setup on my TQMa6x (imx6q-mba6a.dts) with a tc358743 attached
> > > > to
> > > > the MIPI CSI input.
> > > > I noticed that since commit 1f391df44607 ("media: v4l2-async: Use
> > > > endpoints in __v4l2_async_nf_add_fwnode_remote()") the async subdevice
> > > > probing does not work anymore. If I revert that, it is working again,
> > > > even on next-20230425.
> > > 
> > > A similar issue has been discussed at
> > > https://www.spinics.net/lists/linux-media/msg223351.html
> > > 
> > > Unfortunately there was no conclusion as far as I can tell if not that
> > > imx6 is now broken
> > 
> > Thanks for the link, seems like a non-trivial thing :(
> > 
> > From a glimpse, this series seems to deal with multiple async subdevs:
> > https://lore.kernel.org/all/20230330115853.1628216-1-sakari.ailus@linux.in
> > tel.com/
> > 
> > So imx-media-csi should be adjusted as well, no?
> 
> It would really be helpful if you can give that series a spin on imx6
> if you already have a test setup.

I tried, but it failed to apply on my current development tree. What base does 
this series apply to? Is there also a repository available I can fetch from?

Best regards,
Alexander

> > Best regards,
> > Alexander
> > 
> > > > $ cat /sys/kernel/debug/v4l2-async/pending_async_subdevices
> > > > imx-media:
> > > > ipu2_csi1:
> > > > 
> > > > ipu2_csi0:
> > > >  [fwnode] dev=21dc000.mipi,
> > > >  node=/soc/bus@2100000/mipi@21dc000/port@3/endpoint>
> > > > 
> > > > ipu1_csi1:
> > > >  [fwnode] dev=21dc000.mipi,
> > > >  node=/soc/bus@2100000/mipi@21dc000/port@2/endpoint>
> > > > 
> > > > ipu1_csi0:
> > > > imx6-mipi-csi2:
> > > > ipu2_csi1_mux:
> > > > 
> > > > ipu1_csi0_mux:
> > > >  [fwnode] dev=21dc000.mipi,
> > > >  node=/soc/bus@2100000/mipi@21dc000/port@1/endpoint>
> > > > 
> > > > With revert:
> > > > $ cat /sys/kernel/debug/v4l2-async/pending_async_subdevices
> > > > imx-media:
> > > > ipu2_csi1:
> > > > ipu2_csi0:
> > > > ipu1_csi1:
> > > > ipu1_csi0:
> > > > imx6-mipi-csi2:
> > > > ipu2_csi1_mux:
> > > > ipu1_csi0_mux:
> > > > 
> > > > I also see these messages:
> > > > > video-mux 20e0000.iomuxc-gpr:ipu2_csi1_mux: Consider updating driver
> > > > > video-
> > > > 
> > > > mux to match on endpoints
> > > > 
> > > > > imx6-mipi-csi2 21dc000.mipi: Consider updating driver imx6-mipi-csi2
> > > > > to
> > > > 
> > > > match on endpoints
> > > > 
> > > > > tc358743 0-000f: Consider updating driver tc358743 to match on
> > > > > endpoints
> > > > > video-mux 20e0000.iomuxc-gpr:ipu1_csi0_mux: Consider updating driver
> > > > > video-
> > > > 
> > > > mux to match on endpoints
> > > > 
> > > > But I'm unsure if this is related. As far as I can see
> > > > match_fwnode_one
> > > > does match some nodes, but I do not know if they are the correct ones.
> > > > Anyone has an idea what's wrong here?
> > > > 
> > > > Best regards,
> > > > Alexander
> > > > --
> > > > TQ-Systems GmbH | Mühlstraße 2, Gut Delling | 82229 Seefeld, Germany
> > > > Amtsgericht München, HRB 105018
> > > > Geschäftsführer: Detlef Schneider, Rüdiger Stahl, Stefan Schneider
> > > > http://www.tq-group.com/
> > 
> > --
> > TQ-Systems GmbH | Mühlstraße 2, Gut Delling | 82229 Seefeld, Germany
> > Amtsgericht München, HRB 105018
> > Geschäftsführer: Detlef Schneider, Rüdiger Stahl, Stefan Schneider
> > http://www.tq-group.com/


-- 
TQ-Systems GmbH | Mühlstraße 2, Gut Delling | 82229 Seefeld, Germany
Amtsgericht München, HRB 105018
Geschäftsführer: Detlef Schneider, Rüdiger Stahl, Stefan Schneider
http://www.tq-group.com/