From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id CE762C54EE9 for ; Thu, 1 Sep 2022 06:50:35 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S233404AbiIAGud (ORCPT ); Thu, 1 Sep 2022 02:50:33 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:59110 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S233358AbiIAGu2 (ORCPT ); Thu, 1 Sep 2022 02:50:28 -0400 Received: from NAM12-DM6-obe.outbound.protection.outlook.com (mail-dm6nam12on2045.outbound.protection.outlook.com [40.107.243.45]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 1C6B36B65F; Wed, 31 Aug 2022 23:50:27 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=IjqanZ55qW5/BprhanlVB9LP7mRvVxxFBdg8WX7Ql10KTNUWQY83GrxzQaba8j3yJaN54j4xWu/6luG+6U1zofKWf00bd56f62PTheVsk+oJ9pFaFFvmCQumnjuD/xkPY2I2tKHSGmB/8vOBKJTyx6i94c6jLD9GhqQ2uWVRe/oABfQ9dixptf12fg82yh0ibd3f+O3nKYFyZ3FYXQEFpgepqW0zIlAPcmsIxHFtAhdPAIT7QXNMbmIJ7ptQHnx0w7EeTfXeeCoIzspuG+WWNFfjYdN0wlnEFUScAwOy5KtneLfVg/VhLsGtW1QKHBppxE+OYq+NY84fsHmV0QrgiQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=BgyT2M/QOG12Qs0uYEkfkLK0upW7qST+TMjYAA1ALoY=; b=AIcKkDgltprrYGfS+IwQ2aglMbQL6gEEQ2SaXZ/FrDipRsisTp2SlEjkosNAYTIe63S+r+pn+PGmPJzysAIzbOC9CC4gOhvapdQFDYV8VUeT0L4gKtpt4XpkqU4ZEv4IIiVcOjAq2OzofLUf0liZD3xWNY0hCBPqOPFL64sdghFyaNsfafevGSSeHS8ulm4d1KfgaA9DByX3MhsefOBleHgJhhU6d+Avk5Tr9C9XTEKkmmm7RXai/SkDAaLBSQ0KKC8uhoVBfa4maC9NZVvedK+pMWjzS1uEBKVs28lo2T2UGoCgdru3r//oGcrLSqeB92q90Rq6iaMSGd/aiKW/Kg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=amd.com; dmarc=pass action=none header.from=amd.com; dkim=pass header.d=amd.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amd.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=BgyT2M/QOG12Qs0uYEkfkLK0upW7qST+TMjYAA1ALoY=; b=vnlYq+EcnbzeQtPf2ZO8kYSNBRVAvrEzYOQOT3RuERvaVYcNz5aAfL6bgx/5HctXIxcb1PRm4uO2ok+hMyV0Rdf0/Y4KMk/HP/AI3o52wm7P2TFNX+3pEe4TMT8CNyEilBuJSqIyK7WIXqvDOHVyRRrxf9EMqOQ5ddsicshTiVQ= Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=amd.com; Received: from BN8PR12MB3587.namprd12.prod.outlook.com (2603:10b6:408:43::13) by MN2PR12MB4360.namprd12.prod.outlook.com (2603:10b6:208:266::21) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5588.11; Thu, 1 Sep 2022 06:50:25 +0000 Received: from BN8PR12MB3587.namprd12.prod.outlook.com ([fe80::4524:eda6:873a:8f94]) by BN8PR12MB3587.namprd12.prod.outlook.com ([fe80::4524:eda6:873a:8f94%7]) with mapi id 15.20.5588.011; Thu, 1 Sep 2022 06:50:25 +0000 Message-ID: <641f372f-4a30-72bb-ec8b-4fd6ff825594@amd.com> Date: Thu, 1 Sep 2022 08:50:13 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.11.0 Subject: Re: [PATCH v4 09/21] drm/etnaviv: Prepare to dynamic dma-buf locking specification Content-Language: en-US To: Dmitry Osipenko , David Airlie , Gerd Hoffmann , Gurchetan Singh , Chia-I Wu , Daniel Vetter , Daniel Almeida , Gert Wollny , Gustavo Padovan , Daniel Stone , Tomeu Vizoso , Maarten Lankhorst , Maxime Ripard , Thomas Zimmermann , Rob Clark , Sumit Semwal , "Pan, Xinhui" , Thierry Reding , Tomasz Figa , Marek Szyprowski , Mauro Carvalho Chehab , Alex Deucher , Jani Nikula , Joonas Lahtinen , Rodrigo Vivi , Tvrtko Ursulin , =?UTF-8?Q?Thomas_Hellstr=c3=b6m?= , Qiang Yu , Srinivas Kandagatla , Amol Maheshwari , Jason Gunthorpe , Leon Romanovsky , Juergen Gross , Stefano Stabellini , Oleksandr Tyshchenko , Tomi Valkeinen , Russell King , Lucas Stach , Christian Gmeiner Cc: dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org, Dmitry Osipenko , linux-media@vger.kernel.org, linaro-mm-sig@lists.linaro.org, amd-gfx@lists.freedesktop.org, intel-gfx@lists.freedesktop.org, kernel@collabora.com, virtualization@lists.linux-foundation.org, linux-rdma@vger.kernel.org, linux-arm-msm@vger.kernel.org References: <20220831153757.97381-1-dmitry.osipenko@collabora.com> <20220831153757.97381-10-dmitry.osipenko@collabora.com> From: =?UTF-8?Q?Christian_K=c3=b6nig?= In-Reply-To: <20220831153757.97381-10-dmitry.osipenko@collabora.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit X-ClientProxiedBy: AS8P189CA0056.EURP189.PROD.OUTLOOK.COM (2603:10a6:20b:458::33) To BN8PR12MB3587.namprd12.prod.outlook.com (2603:10b6:408:43::13) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: e38163cc-49ab-4860-2151-08da8be63f53 X-MS-TrafficTypeDiagnostic: MN2PR12MB4360:EE_ X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: 4Qw3U1EYfNcrSQ87bm6Tu4B1uAOrXIyrW+XpocxvbZnWWfonykgGmcvXN6PXvlypl2DdMhkHKQRWEPueIv6D2+DmFytDHl7Krf3htjQKGmgQ2tGPtZzGaNRQdojH0m/T+f6BRTTsqCFSjtKq7xK9MJCJydqoOw+PfqmRcNKSeA12b9iVuIbrSTCwvx+KfdIRWslD38xomhB8v/1wYWXtGPfhnl5lex26bMYrfclz8f5vJLmx6CGURRj4akfvs4P4HW5jV79b2xE6G6Ivo7XjWM8rNHX8rdKM2tewD9NWQimGa6KTs8BObORW31tw1fQWadrJgbgUARH3WcV0Frebb7Ky9hE43R1yXDLEd0a8AyobpqJeTkdCM3MQCL4LPs8Rt/S5XsMZ8wW7d4XOfRdArL87vAPLoqNO0dZji18EAyVScEicWuYQ5ADLKHgJ8W7aP1WM+1ClXHfWrTlZMzJ+p/nfITxnsmwMZCWclvH113d0uI23F+KIfWdFH907ZrTAru2WmqH+WVS/qdv6s3Kpnj7y5gszXCdmGqF4qBI7DgzKXOjLJvfPS3i9Rdbx8EGpBZNma+OhpeztU/N9DH+YYGeFg8OdnNEsDsj6OjjV43FiehgML0WEw43IZZgJcTpjV+Ptt0RhVE+5GB8quqPgDCRWw5yL34RRpVRjKMOCBuv6HxMt70/LMdebszlkj8ixwlJC0jIvjDqsBbJ+qbOK9QeJ6E7tNo3mBri/Cu2EQmR+fo/GoQrSN6qU94b/bwVhuWGTdT2Kux4E3BLiUSiLRH41ZDHXffIHnXxNgcdL6Pvf0mFtovYhWBgCWlC/KgVe X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:BN8PR12MB3587.namprd12.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230016)(4636009)(396003)(346002)(376002)(136003)(39860400002)(366004)(83380400001)(38100700002)(66556008)(110136005)(316002)(66476007)(4326008)(8676002)(66946007)(478600001)(36756003)(6486002)(31686004)(6666004)(5660300002)(41300700001)(8936002)(921005)(31696002)(86362001)(2616005)(66574015)(186003)(7416002)(7406005)(26005)(6506007)(2906002)(6512007)(45980500001)(43740500002);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?dVZlVVhVdVRWcEFlU3BEQk1NZFVIS1pvRkt2LzlCTWxoY1JpT2V6a0h5N2xC?= =?utf-8?B?SmJ1elF3ZXBHRFJmdGVWdTF5Q1JwcDdycjVYN0VxTm4rTmlCOVpZczRNUVlm?= =?utf-8?B?NHBIWEVjMlhwZlFoR1RPK3VNZW11YXcrSVh1eFpXRlNjOXEzUWdGVG1zUFRS?= =?utf-8?B?K3F3MCt3eENiZ3N2NFJrTnBGaEhaQ3NOY0tvRWtTTDFIWEE5UkdSLzRmUy8w?= =?utf-8?B?SXdzQ0VJenVyUWMvWjNGZ1lqQ0Myc09mQkVvYWh2NWlJR3hGRDJzS1FoLzl1?= =?utf-8?B?Vzkva2RGVEJGOFlORUVPZTN0ZkEzQzloYlRPcmZKbk9lUnEzS0laNC9yMWhr?= =?utf-8?B?MFlvY2VHaGxZR0V3VktnZ21qZnY0bDhJUUEzbnd4MnZuZDVjVXl0ejZQbEk3?= =?utf-8?B?bWFwSG1ienEyS2NZcnBhS3hFSm8rdlVVaS9MY1lITTd2aXdSaEVQd282dHVT?= =?utf-8?B?dURkU2MrQ3ExN2FSdEUrV3BSaUw3aGJWZzdnNlBYbXIyZXpUelpWOVU5Y1VS?= =?utf-8?B?N1VBNzJHb29aUng1RjFCdjJlOFRscXQ1aGE0aTlQcUFnZVVlMEg2N1dqTFBX?= =?utf-8?B?My9laTI3NEtjSlpEekNhRWxIb2NWamdBZVVHdUVwK3RQR3c0QkhBWC81ZGYr?= =?utf-8?B?RUpRZ1JXM3VRMGkycFZUWjg4Y25MMFNERG5BN1lpQlBWY25DeCtrNlFWUzFm?= =?utf-8?B?NUQrK1hOSUpqV0ZWb283YmU5R0ZuOVlvODBzL1c4STJ4L04xNFhHcG9YcjRN?= =?utf-8?B?MGJKUWhkV0tBMWYvL0o0UThSNkJzS1dDZFN0NzhwanpNdGhObTFrc0c0Z1Jk?= =?utf-8?B?MVNQOHZqNjNYaDFvWGIwSlUrL1FrU080WllLQWU2cGJkdWlZQjJUUjdQMnlB?= =?utf-8?B?REZJaEI1RUEwYWNyc0FxZEU5QmZUR3VQVXZ3YmQ4NUlNa1Ewc3pSRnJqVmVM?= =?utf-8?B?SU1Hd3UwOFdMQlFrMU03NjdFQllVTy9BV29yQzUzY3k1U2hhVWpmRThjYkFE?= =?utf-8?B?WWkwODFXNndwRTVNUUdXVzQ3YnpzL0tucE1hNVd1MHU4U1JzRTZ4NDE4OTlW?= =?utf-8?B?ZExsWU5KY0NIMDl4aDZoS291WUR1dVVsTHpWY3FiRThuWWkwR3BCdm5iRVNa?= =?utf-8?B?eFBxRlpPNDBKTGVkSmdid1VxN3E4Vk5YNnFJOUxHbENYMVNEdXYwQnpDSDVP?= =?utf-8?B?UFp5RXJvanp6cEpYdmtLbWNyL0hBb29Wakhac016VEFBSkEzM3YrRFQyUW5G?= =?utf-8?B?c3VHa0tvcE91T2VFcTNJZ0pTeGZCR3dLZTBKVDI3ZG1rOTdwQklLMkJpUUxQ?= =?utf-8?B?U1k5NVR5N1NJaWVhTXczeXVnVk9qVHhoRWticWZvUEV5UmprelZKNDVtRldm?= =?utf-8?B?K2hBU2Jzc2VnS3hab3R1WVl0QTZBektpcy9YNnlBYUY1bitZUFZ6VDJxbWpU?= =?utf-8?B?WFBuTm10NW1aSjcvb2cyR3RZNjI5VjF6dVRKcENJalNrS24wRVdtMUl1UnR0?= =?utf-8?B?dVlHRHcvU3IvMmc5ZDFZaUIwbHprSEt0MDU5cjl0SlVYUFp3NUFQMlVidHlq?= =?utf-8?B?QVF0ek9oOHE2SWY0L3NIcmM4TENQT052MVJRMlprc2hJcWZNck91QXpaK1c1?= =?utf-8?B?MnBBcVFuNVROemhuai8yR0IxUTcwUkFwZUFPUE9saUlXS0M5ZHYzRFRFYnJk?= =?utf-8?B?ODFDUld2NHFFU3FaclFBN251cStGUkc4MzI2eDQ5OTVXYmQvMlFHNU85OXJJ?= =?utf-8?B?NlE4aldIRTg2N1FkTlFvU0NSL3VPc0dFUTROVmFlRHVFNUhlUk9XaUZkR3JI?= =?utf-8?B?QkZpNGlZZXB5b3lFb09GS3BGQUhYbzZXZllqVURVUHUzVlR3N0tMaGdJa05k?= =?utf-8?B?R2dJSGloTU4ybkN0aUVqVGxZNFIwVXhWTi9FamJFWk5PckNKTkRzdWFPVDRk?= =?utf-8?B?Wldab0FaY2F4aTh3anNKRTFUVmNwWDRUVzlLNm5ZYThpV2JPaUt6M3NMNWRr?= =?utf-8?B?SkJJSmVvU0ZOQjF0aVRURUtiRHY5NXlZSi9oa3JxSkk4dlZlMUROVXFaMkhr?= =?utf-8?B?dENnSGpzNjNkdlpwb2FqeG9jVThNT0JQaTdRc3NwNFB4SE1mSEpGdGFDRE5m?= =?utf-8?Q?tDO5VkcxVb0GesmHuui/cPbM2?= X-OriginatorOrg: amd.com X-MS-Exchange-CrossTenant-Network-Message-Id: e38163cc-49ab-4860-2151-08da8be63f53 X-MS-Exchange-CrossTenant-AuthSource: BN8PR12MB3587.namprd12.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 01 Sep 2022 06:50:25.1247 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: ZiB7fjshmml/8gQ3BPLMGftskJ3cHXzwcEscqW4ZWTzEK9456jizc6fobvHEeBjJ X-MS-Exchange-Transport-CrossTenantHeadersStamped: MN2PR12MB4360 Precedence: bulk List-ID: X-Mailing-List: linux-media@vger.kernel.org Am 31.08.22 um 17:37 schrieb Dmitry Osipenko: > Prepare Etnaviv driver to the common dynamic dma-buf locking convention > by starting to use the unlocked versions of dma-buf API functions. > > Signed-off-by: Dmitry Osipenko Interesting, where is the matching vmap()? Anyway, this patch is Acked-by: Christian König > --- > drivers/gpu/drm/etnaviv/etnaviv_gem_prime.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/gpu/drm/etnaviv/etnaviv_gem_prime.c b/drivers/gpu/drm/etnaviv/etnaviv_gem_prime.c > index 3fa2da149639..7031db145a77 100644 > --- a/drivers/gpu/drm/etnaviv/etnaviv_gem_prime.c > +++ b/drivers/gpu/drm/etnaviv/etnaviv_gem_prime.c > @@ -65,7 +65,7 @@ static void etnaviv_gem_prime_release(struct etnaviv_gem_object *etnaviv_obj) > struct iosys_map map = IOSYS_MAP_INIT_VADDR(etnaviv_obj->vaddr); > > if (etnaviv_obj->vaddr) > - dma_buf_vunmap(etnaviv_obj->base.import_attach->dmabuf, &map); > + dma_buf_vunmap_unlocked(etnaviv_obj->base.import_attach->dmabuf, &map); > > /* Don't drop the pages for imported dmabuf, as they are not > * ours, just free the array we allocated: