Re: [PATCH v3 07/13] media: ipu6: Close firmware streams on streaming enable failure

[Bingbu Cao <bingbu.cao@linux.intel.com>]

Sakari,

Thanks for the patch.

On 12/30/25 9:10 PM, Sakari Ailus wrote:
> When enabling streaming fails, the stream is stopped in firmware but not
> closed. Do this to release resources on firmware side.
> 
> Signed-off-by: Sakari Ailus <sakari.ailus@linux.intel.com>
> ---
>  drivers/media/pci/intel/ipu6/ipu6-isys-video.c | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/drivers/media/pci/intel/ipu6/ipu6-isys-video.c b/drivers/media/pci/intel/ipu6/ipu6-isys-video.c
> index dec8f5ffcfa5..919b77107cef 100644
> --- a/drivers/media/pci/intel/ipu6/ipu6-isys-video.c
> +++ b/drivers/media/pci/intel/ipu6/ipu6-isys-video.c
> @@ -1066,6 +1066,7 @@ int ipu6_isys_video_set_streaming(struct ipu6_isys_video *av, int state,
>  
>  out_media_entity_stop_streaming_firmware:
>  	stop_streaming_firmware(av);
> +	close_streaming_firmware(av);

It looks the close_streaming_firmware() has no chance to run if
v4l2_subdev_disable_streams() above failed. Beside, the
stop_streaming_firmware() is better called after subdev
disable_streams().

>  
>  	return ret;
>  }
> 

-- 
Best regards,
Bingbu Cao