Linux Media Controller development
 help / color / mirror / Atom feed
From: Steve Longerbeam <slongerbeam@gmail.com>
To: Fabio Estevam <festevam@gmail.com>
Cc: Philipp Zabel <p.zabel@pengutronix.de>,
	linux-media <linux-media@vger.kernel.org>,
	Tim Harvey <tharvey@gateworks.com>
Subject: Re: imx6: Cannot register mem2mem
Date: Mon, 6 Apr 2020 11:50:52 -0700	[thread overview]
Message-ID: <65b57718-a60e-66bf-61ba-348457fc524f@gmail.com> (raw)
In-Reply-To: <CAOMZO5Ask2GF7fA=K6_RYF7138YEhsg4ERqvyS5SRt6jkh8QvQ@mail.gmail.com>



On 4/6/20 11:39 AM, Fabio Estevam wrote:
> Hi Steve,
>
> On Mon, Apr 6, 2020 at 2:46 PM Fabio Estevam <festevam@gmail.com> wrote:
>
>>>    &mipi_csi {
>>> -       status = "okay";
>>> +       status = "disabled";
>> I tried this suggestion and then mem2mem is successfully probed.
> Ok, so now I connected the ov5640 module as per your suggestion and
> this is what I get with a clean 5.6.2:
>
> [    6.618296] imx-media: ov5640 1-003c:0 -> imx6-mipi-csi2:0
> [    6.644522] imx-media: Registered ipu_ic_pp csc/scaler as /dev/video8

This shows that imx-media completed probe (v4l2 core called its probe 
complete callback).

>
> However,  the v4l2video8convert Gstreamer element is not detected:
>
> # gst-inspect-1.0 | grep convert
> video4linux2:  v4l2convert: V4L2 Video Converter
> audioconvert:  audioconvert: Audio converter
>
> If I do the kernel hack I mentioned previously then I can get v4l2video8convert:
>
> --- a/drivers/media/v4l2-core/v4l2-async.c
> +++ b/drivers/media/v4l2-core/v4l2-async.c
> @@ -213,10 +213,6 @@ v4l2_async_notifier_try_complete(struct
> v4l2_async_notifier *notifier)
>          if (!notifier->v4l2_dev)
>                  return 0;
>
> -       /* Is everything ready? */
> -       if (!v4l2_async_notifier_can_complete(notifier))
> -               return 0;
> -
>          return v4l2_async_notifier_call_complete(notifier);

That's very odd, because v4l2_async_notifier_call_complete() was 
definitely called on the imx-media root notifier from above.

Is there is another v4l2 driver that is not completing?

Steve

>   }
>
> # gst-inspect-1.0 | grep convert
> video4linux2:  v4l2video11convert: V4L2 Video Converter
> video4linux2:  v4l2video10convert: V4L2 Video Converter
> video4linux2:  v4l2video9convert: V4L2 Video Converter
> video4linux2:  v4l2convert: V4L2 Video Converter
> audioconvert:  audioconvert: Audio converter
>
> What am I missing in order to get the v4l2videoXconvert Gstreamer
> element without hacking the kernel?
>
> Thanks


  reply	other threads:[~2020-04-06 18:50 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-04-06 13:37 imx6: Cannot register mem2mem Fabio Estevam
2020-04-06 14:41 ` Fabio Estevam
2020-04-07 12:00   ` Sakari Ailus
2020-04-06 17:36 ` Steve Longerbeam
2020-04-06 17:46   ` Fabio Estevam
2020-04-06 18:39     ` Fabio Estevam
2020-04-06 18:50       ` Steve Longerbeam [this message]
2020-04-06 19:39         ` Fabio Estevam
2020-04-06 21:26           ` Fabio Estevam
2020-04-07 19:51             ` Nicolas Dufresne

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=65b57718-a60e-66bf-61ba-348457fc524f@gmail.com \
    --to=slongerbeam@gmail.com \
    --cc=festevam@gmail.com \
    --cc=linux-media@vger.kernel.org \
    --cc=p.zabel@pengutronix.de \
    --cc=tharvey@gateworks.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox