From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-lf1-f45.google.com (mail-lf1-f45.google.com [209.85.167.45]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id D7E9E1898FC for ; Mon, 30 Sep 2024 09:15:37 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.167.45 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1727687739; cv=none; b=f8iKs8IKRRajDFZfzn7DkGM8FPM6Mv07QKX/p6hXRNDK0gEKF6sFevTdIBqiy1kzdUXVn2gLoO4XOFHHB/HKt0v0/dtresyAdgMSuuaeajvojFx2OmLaw8NFt6RSviht6iJ/a3knmid9Onr5O9CosXlwBsUFhpGPSuzx+Lw9mMg= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1727687739; c=relaxed/simple; bh=UbBHS64c6Wi8n1M3dVOKwos2H9V7LSNLZVx5hUr5kXw=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=N7RPY6nE+rf9SUEy6TAGQHzNzGqtHfYhYUCqXOKq6YqsezdRmG8G5YgK5xymGj6uiWfiCTDLucAkgbqRYoxEDMflSWiTIBzpQGBRIxAUbZEuZmyrgr7qfxAcmp1F11MuxaneczbTSHJJLY+UCZHjrbyJlYOba4DZSI1VYHuls6U= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org; spf=pass smtp.mailfrom=linaro.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b=KjHARq36; arc=none smtp.client-ip=209.85.167.45 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linaro.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="KjHARq36" Received: by mail-lf1-f45.google.com with SMTP id 2adb3069b0e04-5398cf0c328so246712e87.0 for ; Mon, 30 Sep 2024 02:15:37 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1727687736; x=1728292536; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=G7IuWb65l3XdqWv3HG68RFWkgEd17Jyp/g3HQMeyfnc=; b=KjHARq36sz4YS0CZ7rjcaWOcglRkv6ECH7OFu+EPRPQtIneoAgOQc3yXS4Ow4tkZrE a9XNAhlXNGfJpxcJGKKtHaphnBEJtJQkXLE28qG9UfM4yxr8mmdGN+JQTPvU75f8dALh x950iLSW3J+D97xxp2E8swv5EvIWMCWaFbBCuYzYuBB4VVvrimv/nyrs/kBkBlwhMm/f /j5/Eg0FFHUNH/McEn1mGlgfPIUBceV7/cMP2KQRx6LfmJ+QA3A0DIZAwWasFLJ4bDvT Svdz1k29NkBQRUDmePzyiTNFRrZUQEMqwvPqhuWdM4PsREbEzIp4EHFF8PAJEqba6Zmf LFtQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1727687736; x=1728292536; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=G7IuWb65l3XdqWv3HG68RFWkgEd17Jyp/g3HQMeyfnc=; b=m4Wn8iK5RFVmGMQOz72/wNlbJ/NCRvFyL8Bt8leBnpOnifllrYPxNjcnP8ynq/frEB FhhKSFRZtXTK0S9eNsQQGLDb6skK5mceL12/0NtjDgE2LWxLS2skFIdYgEL+c+7b6l/t Nl2oRx+kpR0JGKRjUOfbNf9tpCJ5rAWwIpv1OY2eQvonRzZviSYyC2Nqq6H6CoMaHFF3 pl9Lf6BFSwSf/1JQVuGGLDjFEjVAh5OQtAMAoZLiiIdet3dHEknlhVZ1AES/xiFrB5qU dqWKeOhzQrvVCYCedSg5PAVVyZrMHu+4jVJ6qcJcgRfGydRLOoMCVveaixOs0A+t8gxn Q0nw== X-Forwarded-Encrypted: i=1; AJvYcCVX+PwcUg7lmefnm3xFH+NRTkBoYJfy0Xr9KofWd7KILtwHn3axpQk7uCnP7rkEY8Zztfzu994Ki1ci0A==@vger.kernel.org X-Gm-Message-State: AOJu0YxmKtF5g6w4ARp5mS8TA7+ydjuAHrTmnrNTdLRpbD+NVvW+pQDc XMZa/nFizHmbFf3QWNIF29QbiObxDDUmahPFjVTZt4DGwE6Lr2bW4pX5YSExR5E= X-Google-Smtp-Source: AGHT+IHoDBM0F8HfaXei+pIBhMva3coZxKb4n2uikIXCUZY6Hd0eeV1ER5KctDKqMCKvJrm7sF515g== X-Received: by 2002:a05:6512:3d28:b0:536:9efb:bb19 with SMTP id 2adb3069b0e04-5398c2e4579mr908003e87.3.1727687735833; Mon, 30 Sep 2024 02:15:35 -0700 (PDT) Received: from [192.168.1.4] (88-112-131-206.elisa-laajakaista.fi. [88.112.131.206]) by smtp.gmail.com with ESMTPSA id 2adb3069b0e04-5389fd5df91sm1191807e87.82.2024.09.30.02.15.33 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 30 Sep 2024 02:15:35 -0700 (PDT) Message-ID: <65db109e-ae0b-4709-bbc4-4aad05cc846b@linaro.org> Date: Mon, 30 Sep 2024 12:15:33 +0300 Precedence: bulk X-Mailing-List: linux-media@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH 07/13] dt-bindings: media: camss: Add qcom,sm8550-camss binding Content-Language: en-US To: Bryan O'Donoghue , Krzysztof Kozlowski , Depeng Shao , rfoss@kernel.org, todor.too@gmail.com, mchehab@kernel.org, robh@kernel.org, krzk+dt@kernel.org, conor+dt@kernel.org Cc: linux-arm-msm@vger.kernel.org, linux-media@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, kernel@quicinc.com, Yongsheng Li References: <20240812144131.369378-1-quic_depengs@quicinc.com> <20240812144131.369378-8-quic_depengs@quicinc.com> <9ed92660-5f42-4a1a-9261-b8800133972a@linaro.org> <65e5796a-8b8d-44f0-aef4-e420083b9d52@kernel.org> <87419076-c355-4eb9-8bf4-a9f2064e3c0a@linaro.org> From: Vladimir Zapolskiy In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit On 9/30/24 11:55, Bryan O'Donoghue wrote: > On 30/09/2024 09:46, Vladimir Zapolskiy wrote: >> Hello Krzysztof, >> >> On 9/30/24 10:16, Krzysztof Kozlowski wrote: >>> On 25/09/2024 17:13, Depeng Shao wrote: >>>> Hi Vladimir, >>>> >>>> On 9/6/2024 11:56 PM, Vladimir Zapolskiy wrote: >>>> >>>>>> +            compatible = "qcom,sm8550-camss"; >>>>>> + >>>>>> +            reg = <0 0x0acb7000 0 0xd00>, >>>>>> +                  <0 0x0acb9000 0 0xd00>, >>>>>> +                  <0 0x0acbb000 0 0xd00>, >>>>>> +                  <0 0x0acca000 0 0xa00>, >>>>>> +                  <0 0x0acce000 0 0xa00>, >>>>>> +                  <0 0x0acb6000 0 0x1000>, >>>>>> +                  <0 0x0ace4000 0 0x2000>, >>>>>> +                  <0 0x0ace6000 0 0x2000>, >>>>>> +                  <0 0x0ace8000 0 0x2000>, >>>>>> +                  <0 0x0acea000 0 0x2000>, >>>>>> +                  <0 0x0acec000 0 0x2000>, >>>>>> +                  <0 0x0acee000 0 0x2000>, >>>>>> +                  <0 0x0acf0000 0 0x2000>, >>>>>> +                  <0 0x0acf2000 0 0x2000>, >>>>>> +                  <0 0x0ac62000 0 0xf000>, >>>>>> +                  <0 0x0ac71000 0 0xf000>, >>>>>> +                  <0 0x0ac80000 0 0xf000>, >>>>>> +                  <0 0x0accb000 0 0x2800>, >>>>>> +                  <0 0x0accf000 0 0x2800>; >>>>> >>>>> Please sort the list above in numerical order, this will change >>>>> positions >>>>> of "vfe_lite0", "vfe_lite1" etc. >>>>> >>>>> Another note, since it's not possible to map less than a page, so I >>>>> believe >>>>> it might make sense to align all sizes to 0x1000. >>>>> >>>> >>>> Sure, I previously sorted by the alphabetical order of reg_name. >>>> I will update it based on your suggestion. And will also make sure the >>>> align all sizes to 0x1000. >>> >>> If I understood correctly, you want to change the order from existing >>> devices, so no. You are supposed to keep the same order, as much as >>> possible. >> >> Please elaborate, what do you mean here by the "existing evices"? >> >> The list is not sorted by reg values, I ask to sort the list by reg values. >> >> -- >> Best wishes, >> Vladimir > > We always sort by address: > Thank you for the given confirmation that there is a need to make the change requested by me. -- Best wishes, Vladimir