Re: [PATCH 1/4] [media] ad5820: Define entity function

Laurent Pinchart
2018-09-21T02:07:57Z

Hi Ricardo,

Thank you for the patch.

On Thursday, 20 September 2018 19:19:09 EEST Ricardo Ribalda Delgado wrote:
> Without this patch, media_device_register_entity throws a warning:
>
> dev_warn(mdev->dev,
> "Entity type for entity %s was not initialized!\n",
> entity->name);
>
> Signed-off-by: Ricardo Ribalda Delgado <ricardo.ribalda@gmail.com>

Reviewed-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>

> ---
> drivers/media/i2c/ad5820.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/drivers/media/i2c/ad5820.c b/drivers/media/i2c/ad5820.c
> index 907323f0ca3b..22759aaa2dba 100644
> --- a/drivers/media/i2c/ad5820.c
> +++ b/drivers/media/i2c/ad5820.c
> @@ -317,6 +317,7 @@ static int ad5820_probe(struct i2c_client *client,
> v4l2_i2c_subdev_init(&coil->subdev, client, &ad5820_ops);
> coil->subdev.flags |= V4L2_SUBDEV_FL_HAS_DEVNODE;
> coil->subdev.internal_ops = &ad5820_internal_ops;
> + coil->subdev.entity.function = MEDIA_ENT_F_LENS;
> strscpy(coil->subdev.name, "ad5820 focus", sizeof(coil->subdev.name));
>
> ret = media_entity_pads_init(&coil->subdev.entity, 0, NULL);

--
Regards,

Laurent Pinchart