From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-ed1-f46.google.com (mail-ed1-f46.google.com [209.85.208.46]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 1A0B13B892D for ; Mon, 13 Apr 2026 10:02:54 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.208.46 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1776074579; cv=none; b=DS4i32rE9ci+YaKXhzMFEDsKGdXtQ8RiR8+t0JCTaAyegeGDIGftDymcphzOklPuahGzX2EwEqEJszeHYZ6hMRkVtAq9Q+tRlfHIaaZ4n0byas9gAmmXVJ0VPmSn/eattJvQxhp9Z4oDBFAhe3tIFuiKpmM0obZqQ3TterF/1x8= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1776074579; c=relaxed/simple; bh=kcFblZIautjwHK2Vy2J3AGSdQpVSXAg+nv5VyeOoIG0=; h=Message-ID:Date:Content-Type:MIME-Version:From:To:Cc:Subject: In-Reply-To:References; b=UxIhlnldOe+luMoUaAFzKjyPd98WmND9x1KAwWGKLYoEJZsOnsv6vp/c6dMeJKotOL3hqPOpKXkNhyrZRAkzSrni/3M6uuChlN4/mjGn9pM9b1cAvSutSZ2ATRG9i2kumZIanFW1Ruk+hhivLeUy841YRCJEAStMEzIZPAtgzYU= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=lVYWRSkf; arc=none smtp.client-ip=209.85.208.46 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="lVYWRSkf" Received: by mail-ed1-f46.google.com with SMTP id 4fb4d7f45d1cf-66ba9898ae8so6324021a12.1 for ; Mon, 13 Apr 2026 03:02:54 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1776074573; x=1776679373; darn=vger.kernel.org; h=references:in-reply-to:subject:cc:to:from:content-transfer-encoding :mime-version:date:message-id:from:to:cc:subject:date:message-id :reply-to; bh=09a3O6d1W+1rc2kx9Pz8OV5bGy+ArYt+o+cPEdWVuHE=; b=lVYWRSkfHe5q59cGnMsqB9WrjsW6BHINQrgyuXGUh1+uv74lf65Xd6WnJXJSYuqGil D/By5bCww61lwJUn9mZFql+9VTNvbv4i3KhK/PqbX/eUq19n2B8iDii+fbyYJNb4DKaD DQRT0vNCWRjgHyj9RNqDmUfMccF1B3FB1yxhBrcPq0jeZNa0CXfGlfNTFLzWD/csk0tA wEXbBc6uqTYrfAcuItuxT0uPTgJIjV/i+dAk/6ehtHh6POmXi7ZsLzDvnYPFQhewnlXK NYNE5fN8eF0o3lypOvU9ko1xcpkZy1NMErTtWC41AR6994bCK0ZQ1l43DcAYRWYhLPJ5 aaxw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1776074573; x=1776679373; h=references:in-reply-to:subject:cc:to:from:content-transfer-encoding :mime-version:date:message-id:x-gm-gg:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=09a3O6d1W+1rc2kx9Pz8OV5bGy+ArYt+o+cPEdWVuHE=; b=n5Fmr5p0MPctQWdtpk56LxPV+lVJjYkDjSM7oFvq9BIJ4pJWuJI5U6cpAiDfAQYfu3 ScSoJToBJjn49W9OYhwP0JcXhmBUrv2dQFvsJHgUogp42KM+6nU0xEPZVBnwvfqUMn/H jPIn5BTIkfFrEC7YJGsBM3ToXli+uOONi/uh/VPz6KEk3IxeZf7tOl3L4AlI7JNIScFe 4S4uYUI2XKkIvF1TnzSqhhLfRlUX46N4Q2MXDyH4ZT5BdmnKZF7cDVagXldUntRcbk3Z 5P2cCjFsOZSTTOqpOJkprl0wPJ6K39zM8EvnfBZ5+nbbTELfCljtIl/bEiCK7odj6KLS EwJQ== X-Gm-Message-State: AOJu0YxFORsEJd3A+wCXlNJj+VXm9Duf42+jUPipGR8wxQfFPuah1Lm+ OczfWHN33gN7zJBB7Z36+kjISSRVi1bsS7pXd62m+/DMg/1WAS3dl26i X-Gm-Gg: AeBDietUP/JgYASI7MAVTr5quQq5pvSfCb9vG5hjfQn4M/YwGiVPv+qwidEYXCYwX01 ITKKiJfemyGUEmkF5VQFB1S6OWfLRUejAHiPFVw3U2KujFfoKiJH2X9BRWpYNHtQtV7uN4cyhHs 8kpnew61hh4LtXiLN3IZ7lXOIpIB7glYXpWsnImLB/OVnXsg12OBWkw049FTd+u25cTDyYdPcCb G3sRdlauBLGqq/fzFDe+H2Btxcj6UmvUv0VFYxlb4UMn2dLnbzLG7NgurJhKHjAXrJfS3Dqnv3N tFXxN/JPHl+PHcymVJP91j/2sg8+ytYdYdMI972OPn28PrDFOetkq9HNDsg3Bv+/3GfAL/b4VL0 6wF+UtxQhP0BDNpL6nzO1a0uIeUzUNlnE1W3j+24esWCN+SxGg98JW2kz/yKgK1S1V6cp8ysqK7 eQ27sN2+5/h0g6DCZFRu7qSxqPYJNHxgXVrJdwmpjwXMcFSbH0k4xs76ARmY4tCrY9ibvCsTgCL k7b/CMZvmwpK4GmAWPaMYmNYO9QMtEvxkyY1IBbCmoqglpZdttZjwq36Em0wQ== X-Received: by 2002:a17:906:dc8e:b0:b9c:ba09:db7d with SMTP id a640c23a62f3a-b9d76d8e108mr590538266b.20.1776074573148; Mon, 13 Apr 2026 03:02:53 -0700 (PDT) Received: from ahossu.localdomain ([88.202.160.248]) by smtp.gmail.com with ESMTPSA id a640c23a62f3a-b9d6e7c8a78sm298786666b.50.2026.04.13.03.02.52 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 13 Apr 2026 03:02:52 -0700 (PDT) Message-ID: <69dcbf4c.170a0220.3ae28e.ec02@mx.google.com> Date: Mon, 13 Apr 2026 03:02:52 -0700 (PDT) Content-Type: text/plain; charset="us-ascii" Precedence: bulk X-Mailing-List: linux-media@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 7bit From: Alexandru Hossu To: Dan Carpenter Cc: linux-media@vger.kernel.org, sakari.ailus@linux.intel.com, bingbu.cao@intel.com, mchehab@kernel.org, gregkh@linuxfoundation.org, linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org Subject: Re: [PATCH 5/5] staging: media: ipu7: fix double-free of pdata in error paths In-Reply-To: <20260412205057.386856-5-hossu.alexandru@gmail.com> References: <20260412205057.386856-5-hossu.alexandru@gmail.com> On Mon, Apr 13, 2026, Dan Carpenter wrote: > We need a Fixes tag. > > The put_device() frees isys_adev as well so this is a use after free. > > ret = dev_err_probe(dev, PTR_ERR(isys_adev->mmu), ... > put_device(); > return ret; Good catch on the use-after-free in the return value. Will send v2 with: - Fixes: b7fe4c0019b1 ("media: staging/ipu7: add Intel IPU7 PCI device driver") - Save error code via ret = dev_err_probe() before put_device() in both ipu7_isys_init() and ipu7_psys_init(), then return ERR_PTR(ret) Alexandru