From: Krzysztof Kozlowski <krzk@kernel.org>
To: Vikash Garodia <vikash.garodia@oss.qualcomm.com>,
Dikshita Agarwal <dikshita.agarwal@oss.qualcomm.com>,
Abhinav Kumar <abhinav.kumar@linux.dev>,
Bryan O'Donoghue <bod@kernel.org>,
Mauro Carvalho Chehab <mchehab@kernel.org>,
Rob Herring <robh@kernel.org>,
Krzysztof Kozlowski <krzk+dt@kernel.org>,
Conor Dooley <conor+dt@kernel.org>,
Saravana Kannan <saravanak@kernel.org>,
Joerg Roedel <joro@8bytes.org>, Will Deacon <will@kernel.org>,
Robin Murphy <robin.murphy@arm.com>,
Stefan Schmidt <stefan.schmidt@linaro.org>,
Hans Verkuil <hverkuil@kernel.org>,
Vishnu Reddy <busanna.reddy@oss.qualcomm.com>,
Hans Verkuil <hverkuil+cisco@kernel.org>
Cc: linux-arm-msm@vger.kernel.org, linux-media@vger.kernel.org,
devicetree@vger.kernel.org, linux-kernel@vger.kernel.org,
iommu@lists.linux.dev,
Bryan O'Donoghue <bryan.odonoghue@linaro.org>
Subject: Re: [PATCH v2 1/7] media: dt-bindings: qcom-kaanapali-iris: Add kaanapali video codec binding
Date: Wed, 4 Mar 2026 16:07:02 +0100 [thread overview]
Message-ID: <6a610a7c-04f1-4023-82dc-e9cdf5673d55@kernel.org> (raw)
In-Reply-To: <68db6d61-640b-4eef-8ccd-ab2fbcb58427@oss.qualcomm.com>
On 03/03/2026 19:10, Vikash Garodia wrote:
>
>>
>> ...
>>
>>> + };
>>> diff --git a/include/dt-bindings/media/qcom,iris.h b/include/dt-bindings/media/qcom,iris.h
>>
>> Filename must match binding/compatible. I asked for this multiple times.
>>
>
> in this case, its applicable for other platforms as well. Naming it as
> qcom,kaanapali-iris.h would make it look like kaanapali specific.
I repeated that feedback way too many times.
NAK
Nacked-by: Krzysztof Kozlowski <krzysztof.kozlowski@oss.qualcomm.com
Best regards,
Krzysztof
next prev parent reply other threads:[~2026-03-04 15:07 UTC|newest]
Thread overview: 47+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-02-27 14:11 [PATCH v2 0/7] media: iris: add support for kaanapali platform Vikash Garodia
2026-02-27 14:11 ` [PATCH v2 1/7] media: dt-bindings: qcom-kaanapali-iris: Add kaanapali video codec binding Vikash Garodia
2026-02-27 15:42 ` Rob Herring (Arm)
2026-02-27 15:50 ` Krzysztof Kozlowski
2026-02-27 15:55 ` Krzysztof Kozlowski
2026-03-03 18:10 ` Vikash Garodia
2026-03-04 15:07 ` Krzysztof Kozlowski [this message]
2026-03-05 12:23 ` Vikash Garodia
2026-02-27 19:52 ` Dmitry Baryshkov
2026-03-03 18:13 ` Vikash Garodia
2026-03-03 23:53 ` Dmitry Baryshkov
2026-03-04 15:02 ` Vikash Garodia
2026-03-05 3:33 ` Dmitry Baryshkov
2026-02-27 14:11 ` [PATCH v2 2/7] media: iris: switch to hardware mode after firmware boot Vikash Garodia
2026-02-27 16:49 ` Konrad Dybcio
2026-03-03 18:15 ` Vikash Garodia
2026-03-04 8:57 ` Konrad Dybcio
2026-02-27 14:11 ` [PATCH v2 3/7] media: iris: add iris vpu bus support and register it with iommu_buses Vikash Garodia
2026-02-27 15:49 ` Krzysztof Kozlowski
2026-03-03 18:26 ` Vikash Garodia
2026-02-27 20:14 ` Dmitry Baryshkov
2026-02-27 14:11 ` [PATCH v2 4/7] media: iris: add context bank devices using iommu-map Vikash Garodia
2026-02-27 20:20 ` Dmitry Baryshkov
2026-03-03 18:46 ` Vikash Garodia
2026-03-03 22:25 ` Dmitry Baryshkov
2026-03-05 12:49 ` Vikash Garodia
2026-03-05 14:21 ` Dmitry Baryshkov
2026-03-05 17:26 ` Vikash Garodia
2026-03-05 18:32 ` Dmitry Baryshkov
2026-03-05 21:34 ` Vikash Garodia
2026-03-13 19:26 ` Dmitry Baryshkov
2026-02-27 14:11 ` [PATCH v2 5/7] media: iris: add helper to select context bank device Vikash Garodia
2026-02-27 20:27 ` Dmitry Baryshkov
2026-03-03 19:16 ` Vikash Garodia
2026-03-03 22:27 ` Dmitry Baryshkov
2026-03-04 15:29 ` Vikash Garodia
2026-03-05 3:40 ` Dmitry Baryshkov
2026-02-27 14:11 ` [PATCH v2 6/7] media: iris: add iris4 specific H265 line buffer calculation Vikash Garodia
2026-02-27 20:28 ` Dmitry Baryshkov
2026-03-03 18:48 ` Vikash Garodia
2026-03-03 22:28 ` Dmitry Baryshkov
2026-03-04 15:40 ` Vikash Garodia
2026-03-05 3:41 ` Dmitry Baryshkov
2026-02-27 14:11 ` [PATCH v2 7/7] media: iris: add platform data for kaanapali Vikash Garodia
2026-02-27 15:48 ` Krzysztof Kozlowski
2026-02-28 7:31 ` Dmitry Baryshkov
2026-02-27 15:42 ` [PATCH v2 0/7] media: iris: add support for kaanapali platform Bryan O'Donoghue
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=6a610a7c-04f1-4023-82dc-e9cdf5673d55@kernel.org \
--to=krzk@kernel.org \
--cc=abhinav.kumar@linux.dev \
--cc=bod@kernel.org \
--cc=bryan.odonoghue@linaro.org \
--cc=busanna.reddy@oss.qualcomm.com \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=dikshita.agarwal@oss.qualcomm.com \
--cc=hverkuil+cisco@kernel.org \
--cc=hverkuil@kernel.org \
--cc=iommu@lists.linux.dev \
--cc=joro@8bytes.org \
--cc=krzk+dt@kernel.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-media@vger.kernel.org \
--cc=mchehab@kernel.org \
--cc=robh@kernel.org \
--cc=robin.murphy@arm.com \
--cc=saravanak@kernel.org \
--cc=stefan.schmidt@linaro.org \
--cc=vikash.garodia@oss.qualcomm.com \
--cc=will@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox