From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wm1-f49.google.com (mail-wm1-f49.google.com [209.85.128.49]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 6B9C82E6125 for ; Mon, 30 Jun 2025 18:04:30 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.49 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1751306672; cv=none; b=tki3sz81IDqSuzmrOfdde4soNi+n98RMOiNCRqZMEfaMlZxi7NRZCQQQMKnSa9f4Mt+NQuAlpSa+JCJo9AhKzGONOiyiC0cwGlPbHU0sq/hd+1v8KW6TgrR+pCwNtff9bfN90Ber56RHDIYyKGBq/kAE+Nx3DfF1JdbvokW3d64= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1751306672; c=relaxed/simple; bh=ZKPRDHlzzHNCWDVJJNURpJpvT7hM8AuBE6fLXfb0op0=; h=Message-ID:Date:MIME-Version:From:Subject:To:Cc:References: In-Reply-To:Content-Type; b=pVc2XYSV6jZBTD6fOJUlsIQnw4vLvOkRPZQ3nEtVovEYRef8lnbH4+wpmKRbnwso+ehqUNooOqu4E5cCsuxTuVWKCllLdZSUQCUFr1sezZcxNv5IYKeqiHxjF2fZKlBTldGweNTkoLGDUI7okaa2EHCB4ydwrzK9pldzEaQ8qwE= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org; spf=pass smtp.mailfrom=linaro.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b=dNfo2goI; arc=none smtp.client-ip=209.85.128.49 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linaro.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="dNfo2goI" Received: by mail-wm1-f49.google.com with SMTP id 5b1f17b1804b1-451d41e1ad1so31725685e9.1 for ; Mon, 30 Jun 2025 11:04:30 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1751306669; x=1751911469; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:organization:autocrypt :content-language:references:cc:to:subject:reply-to:from:user-agent :mime-version:date:message-id:from:to:cc:subject:date:message-id :reply-to; bh=jzyLhIO2/dVrs9OAoxTRKyeEq4PGZq1spv/1YCsSOCU=; b=dNfo2goIpl5wV6V2veov662LG74KoaGqMj6A65ZDQ72YiIwaHRk9FxXqAXYcIXjWVs Rv3Aalv7Ob90lu7+vGPCopR6t41rd9oabuL3B315B6qTYwUPdOaOqxT4kwCNfo5fGl5M N31wquRT80OQfjK3K0S/PDe++PRwSRVrLhQdGf+j+vRLfCgfJe9kDFkNYTqux8L+eBIS P5j17dJRh6+rzpLfZBgwRP5jiy15p3ZBFH9PGxXpc2OpZdQ5trddANbv9ZGSGj5DgQed PnLo8EcnJlRDwJEC/GrNxiNlwScx6BwOQzu6ua23X/l4cmim8W/NzQQVLhnvN9Ug59t8 qqZA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1751306669; x=1751911469; h=content-transfer-encoding:in-reply-to:organization:autocrypt :content-language:references:cc:to:subject:reply-to:from:user-agent :mime-version:date:message-id:x-gm-message-state:from:to:cc:subject :date:message-id:reply-to; bh=jzyLhIO2/dVrs9OAoxTRKyeEq4PGZq1spv/1YCsSOCU=; b=gM7GE5+hEFAETEduhZERf0gq//R1SQU+PjKCRBfjxh4FZ5FYOr5ORNLvsElO17Ed2O o1k6aILgmF+DjkzIUIIkzYb/cIuPYQwy3/iOcEN/52EPisOQPxVldprJWEjQI84/CwWb kIaDqRIhuengR+iX4dE0GjRsYy8JbI6DhPQcPZLAhqiepAzmX+Rt2nOzwiBKxuSStq+d SBGNXdNS2Cr67xF8vjdfzi5DbeqAi1tvK9XOJUHnHMh5IMGZCYQy3wNpoDAehVvI1SD1 rOe/LYiy7nnoCyH55EmBVgaZEWIKeDduaTt5WcIrMl3NQ5PVEYVQWBhFl5PlXI5ZVLVt Lucw== X-Gm-Message-State: AOJu0YzhHQHWRpx/gCybjR3qKEIrlacXqeC90vTS0hJrf+44XTYei/dZ 2kdDFQSmZPkRUCDL1FHFskUrMA/F3Uyh+at2bRYkFpLSsepH1YdJSal6G/c0vQKGU3E= X-Gm-Gg: ASbGncsatnMZS4bA5/5GYxNQlPZIDXn1a3gUUTn7IsRTvQXzktrezOdjAsr5SFUZvE1 3OduEWvvCw6tZtwtSq9ARh2PdToJ4F76mw191f9w2HnQabtf5KNP4UH6ICvTJtcEJ8MTyMHgoli +n8Nax/IJX+jN0n82FRkow3y058pNz0YficIeU5Fmv7wqceGKuM9E4pdf6Tt8yjn57WQI+5/+4q 8FKMyyTt1VbJM2mj4Mgtl9Bg2m3TJpvOCBDgyKhZjQuFNZTQFA4PTiex/l4ep1lRQ7O2F2DbIU5 kcbLB0ajGWSgl287fJLyUu73SbbNCng9IyNxd1Ep/Sd96JE/rdVNQYNadvcSCpe/VUpjZSliZtb 25UiiFNTSU3cCYKHtfnj3WR6DRQ8/JsX7wnTroPQ= X-Google-Smtp-Source: AGHT+IHRSx5CGZmWRMNIAetHYhuZITQEsB0DhmQXeUhagKx55LzxJzkoo1AhHNRcIq8szEkLC4wGIw== X-Received: by 2002:a05:6000:2b0d:b0:3a4:dfc2:2a3e with SMTP id ffacd0b85a97d-3a90038b75bmr9898270f8f.39.1751306668625; Mon, 30 Jun 2025 11:04:28 -0700 (PDT) Received: from ?IPV6:2a01:e0a:3d9:2080:abe8:a49c:efe7:4dfb? ([2a01:e0a:3d9:2080:abe8:a49c:efe7:4dfb]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-3a892e5f8e1sm10875328f8f.88.2025.06.30.11.04.27 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 30 Jun 2025 11:04:28 -0700 (PDT) Message-ID: <6c5d9ff2-fa59-4151-99fe-3bddae46b507@linaro.org> Date: Mon, 30 Jun 2025 20:04:26 +0200 Precedence: bulk X-Mailing-List: linux-media@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird From: neil.armstrong@linaro.org Reply-To: Neil Armstrong Subject: Re: [PATCH v3 0/5] Introduce "non-pixel" sub node within iris video node To: Vikash Garodia , Dikshita Agarwal , Abhinav Kumar , Bryan O'Donoghue , Mauro Carvalho Chehab , Rob Herring , Krzysztof Kozlowski , Conor Dooley Cc: linux-media@vger.kernel.org, linux-arm-msm@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org References: <20250627-video_cb-v3-0-51e18c0ffbce@quicinc.com> Content-Language: en-US, fr Autocrypt: addr=neil.armstrong@linaro.org; keydata= xsBNBE1ZBs8BCAD78xVLsXPwV/2qQx2FaO/7mhWL0Qodw8UcQJnkrWmgTFRobtTWxuRx8WWP GTjuhvbleoQ5Cxjr+v+1ARGCH46MxFP5DwauzPekwJUD5QKZlaw/bURTLmS2id5wWi3lqVH4 BVF2WzvGyyeV1o4RTCYDnZ9VLLylJ9bneEaIs/7cjCEbipGGFlfIML3sfqnIvMAxIMZrvcl9 qPV2k+KQ7q+aXavU5W+yLNn7QtXUB530Zlk/d2ETgzQ5FLYYnUDAaRl+8JUTjc0CNOTpCeik 80TZcE6f8M76Xa6yU8VcNko94Ck7iB4vj70q76P/J7kt98hklrr85/3NU3oti3nrIHmHABEB AAHNKk5laWwgQXJtc3Ryb25nIDxuZWlsLmFybXN0cm9uZ0BsaW5hcm8ub3JnPsLAkQQTAQoA OwIbIwULCQgHAwUVCgkICwUWAgMBAAIeAQIXgBYhBInsPQWERiF0UPIoSBaat7Gkz/iuBQJk Q5wSAhkBAAoJEBaat7Gkz/iuyhMIANiD94qDtUTJRfEW6GwXmtKWwl/mvqQtaTtZID2dos04 YqBbshiJbejgVJjy+HODcNUIKBB3PSLaln4ltdsV73SBcwUNdzebfKspAQunCM22Mn6FBIxQ GizsMLcP/0FX4en9NaKGfK6ZdKK6kN1GR9YffMJd2P08EO8mHowmSRe/ExAODhAs9W7XXExw UNCY4pVJyRPpEhv373vvff60bHxc1k/FF9WaPscMt7hlkbFLUs85kHtQAmr8pV5Hy9ezsSRa GzJmiVclkPc2BY592IGBXRDQ38urXeM4nfhhvqA50b/nAEXc6FzqgXqDkEIwR66/Gbp0t3+r yQzpKRyQif3OwE0ETVkGzwEIALyKDN/OGURaHBVzwjgYq+ZtifvekdrSNl8TIDH8g1xicBYp QTbPn6bbSZbdvfeQPNCcD4/EhXZuhQXMcoJsQQQnO4vwVULmPGgtGf8PVc7dxKOeta+qUh6+ SRh3vIcAUFHDT3f/Zdspz+e2E0hPV2hiSvICLk11qO6cyJE13zeNFoeY3ggrKY+IzbFomIZY 4yG6xI99NIPEVE9lNBXBKIlewIyVlkOaYvJWSV+p5gdJXOvScNN1epm5YHmf9aE2ZjnqZGoM Mtsyw18YoX9BqMFInxqYQQ3j/HpVgTSvmo5ea5qQDDUaCsaTf8UeDcwYOtgI8iL4oHcsGtUX oUk33HEAEQEAAcLAXwQYAQIACQUCTVkGzwIbDAAKCRAWmrexpM/4rrXiB/sGbkQ6itMrAIfn M7IbRuiSZS1unlySUVYu3SD6YBYnNi3G5EpbwfBNuT3H8//rVvtOFK4OD8cRYkxXRQmTvqa3 3eDIHu/zr1HMKErm+2SD6PO9umRef8V82o2oaCLvf4WeIssFjwB0b6a12opuRP7yo3E3gTCS KmbUuLv1CtxKQF+fUV1cVaTPMyT25Od+RC1K+iOR0F54oUJvJeq7fUzbn/KdlhA8XPGzwGRy 4zcsPWvwnXgfe5tk680fEKZVwOZKIEuJC3v+/yZpQzDvGYJvbyix0lHnrCzq43WefRHI5XTT QbM0WUIBIcGmq38+OgUsMYu4NzLu7uZFAcmp6h8g Organization: Linaro In-Reply-To: <20250627-video_cb-v3-0-51e18c0ffbce@quicinc.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit On 27/06/2025 17:48, Vikash Garodia wrote: > This series introduces a sub node "non-pixel" within iris video node. > Video driver registers this sub node as a platform device and configure > it for DMA operations. All non pixel buffers, i.e bitstream, HFI queues > and internal buffers related to bitstream processing, would be managed > by this non_pixel device. > > Purpose to add this sub-node: > Iris device limits the IOVA to an addressable range of 4GiB, and even > within that range, some of the space is used by IO registers, thereby > limiting the available IOVA to even lesser. For certain video usecase, > this limited range in not sufficient enough, hence it brings the need to > extend the possibility of higher IOVA range. > > Video hardware is designed to emit different stream-ID for pixel and > non-pixel buffers, thereby introduce a non-pixel sub node to handle > non-pixel stream-ID into a separate platform device. > With this, both iris and non-pixel device can have IOVA range of > approximately 0-4GiB individually for each device, thereby doubling the > range of addressable IOVA. > > Tested on SM8550 and SA8775p hardwares. > > Signed-off-by: Vikash Garodia > --- > Changes in v3: > - Add info about change in iommus binding (Thanks Krzysztof) > - Link to v2: https://lore.kernel.org/r/20250627-video_cb-v2-0-3931c3f49361@quicinc.com > > Changes in v2: > - Add ref to reserve-memory schema and drop it from redefining it in > iris schema (Thanks Krzysztof) > - Drop underscores and add info about non pixel buffers (Thanks Dmitry) > - Link to v1: https://lore.kernel.org/r/20250620-video_cb-v1-0-9bcac1c8800c@quicinc.com > > --- > Vikash Garodia (5): > media: dt-bindings: add non-pixel property in iris schema > media: iris: register and configure non-pixel node as platform device > media: iris: use np_dev as preferred DMA device in HFI queue management > media: iris: select appropriate DMA device for internal buffers > media: iris: configure DMA device for vb2 queue on OUTPUT plane > > .../bindings/media/qcom,sm8550-iris.yaml | 40 ++++++++++++++++- > drivers/media/platform/qcom/iris/iris_buffer.c | 15 ++++++- > drivers/media/platform/qcom/iris/iris_core.h | 2 + > drivers/media/platform/qcom/iris/iris_hfi_queue.c | 20 ++++++--- > drivers/media/platform/qcom/iris/iris_probe.c | 50 +++++++++++++++++++++- > drivers/media/platform/qcom/iris/iris_vb2.c | 4 ++ > 6 files changed, 119 insertions(+), 12 deletions(-) > --- > base-commit: 8d2b7fde56597ca912f5daaf3ab58915458ba1fc > change-id: 20250619-video_cb-ea872d6e6627 > > Best regards, I tried the patchset on SM8550 QRD and SM8650 QRD/HDK and the system just reboots a few millisecond after probing iris, no error messages nor reboot to sahara mode. The DT changeset for reference: https://git.codelinaro.org/neil.armstrong/linux/-/commit/e1b3628469c038559a60d310386f006f353e3d59 Neil