From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-alma10-1.taild15c8.ts.net [100.103.45.18]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 6754A3CE083 for ; Thu, 8 Oct 2026 06:52:11 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=100.103.45.18 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1791442337; cv=none; b=cFs4+YBPk0aNxg+W0g1oAjE9EhZ+xE1/N9Q+1c+kaxNPqSX6aiy7WKGxBv85TwZTzJJCvH5MjnVX4kgUHPhxvRY8tj4PYj8PHfZuenTmd2GHzPH+RGWuiOeG4lUw2b9bRPEm9e6RCZBuN5fGsceo4XGrl3rjn8CL9F73Nz8+PvU= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1791442337; c=relaxed/simple; bh=GhJa/F78UTRptZUQ1OB3yE2E4H5g/nOrlu+LwUBdfCY=; h=Message-ID:Date:MIME-Version:From:Subject:To:Cc:References: In-Reply-To:Content-Type; b=t/pPKQapVIc+ePRASvGthEOT9EflgYPM5ieHrx59w7s/8IeUPqQ2N5LcMHRqEm96ARAA2yOBoD83qZm6HQjt5NQcoz6zuTz2uDTsK/caK5ptmQFKiMAeP6vyYQlagpuDy2Mft6r2pDkoPsQlfOW1Z7IVRKokTMGf/GFMtG8GNE4= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=huhfs0pZ; arc=none smtp.client-ip=100.103.45.18 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="huhfs0pZ" Received: by smtp.kernel.org (Postfix) with ESMTPSA id C88D31F000FF; Thu, 8 Oct 2026 06:52:03 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=kernel.org; s=k20260515; t=1791442330; bh=nHuCJkYlMUjG+oCR/j0/wkyMipE/7evMGhVbjJcCmJo=; h=Date:From:Subject:To:Cc:References:In-Reply-To; b=huhfs0pZNIZnFcEnUyaOhQSsCBQhGkWRnggkWlIBCUJJjsU0VW2ecdd6oV23kxehL ddqmxyhFo82/OSWlpp2OI/LNZwwKIM6ZvDZO/O3qxXGBjHeO980EDYP+IyyP3HbZBx iWvQyh0Ny3Xp+tbEzo0rcpTOnN0HcCR9OYiceyKkJdPxl1J6AaV2bLo+B0+ntbIUpu Kli7Hv0Ei4EVk+50E35ZE486Z6OgdsqR8AXkHn/f23ENgtbSKsUl2tf6arzLgwvKSi Ur8wc0WLNmI1LbRvdQL5aDAkSLpTzP6s0vVsnWReVUfwpz/ek40az4e93x1JnZztBi 5wBN+kznUEeJQ== Message-ID: <6dcd4951-d86b-4295-817b-ac4984284c16@kernel.org> Date: Thu, 8 Oct 2026 08:52:01 +0200 Precedence: bulk X-Mailing-List: linux-media@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird From: Hans Verkuil Subject: Re: [PATCH 1/2] media: mc: Keep INTERNAL pad flags just for the kernel, for now To: Sakari Ailus , linux-media@vger.kernel.org Cc: laurent.pinchart@ideasonboard.com, Prabhakar , Kate Hsuan , Dave Stevenson , Tommaso Merciai , Benjamin Mugnier , Sylvain Petinot , Christophe JAILLET , Julien Massot , Naushir Patuck , "Yan, Dongcheng" , Stefan Klug , Mirela Rabulea , =?UTF-8?Q?Andr=C3=A9_Apitzsch?= , Heimir Thor Sverrisson , Kieran Bingham , Mehdi Djait , Ricardo Ribalda Delgado , Hans de Goede , Jacopo Mondi , Tomi Valkeinen , David Plowman , "Yu, Ong Hock" , "Ng, Khai Wen" , Jai Luthra , Rishikesh Donadkar , Mattijs Korpershoek , Antti Laakso , Dumitru Ceclan , Martin Hecht , Andrian Suciu , Martin Hecht , Cosmin Tanislav , Vivekananda Dayananda , Quentin Freimanis , Cory Keitz References: <20261007204135.782415-1-sakari.ailus@linux.intel.com> <20261007204135.782415-2-sakari.ailus@linux.intel.com> Content-Language: en-US, nl In-Reply-To: <20261007204135.782415-2-sakari.ailus@linux.intel.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit On 07/10/2026 22:41, Sakari Ailus wrote: > Do not expose INTERNAL pads on UAPI as the documentation nor > v4l2-compliance changes to support MEDIA_PAD_FL_INTERNAL pads has not yet > been merged. > > Signed-off-by: Sakari Ailus Reviewed-by: Hans Verkuil Regards, Hans > --- > include/uapi/linux/media.h | 6 ++++++ > 1 file changed, 6 insertions(+) > > diff --git a/include/uapi/linux/media.h b/include/uapi/linux/media.h > index 80cfd12a43fc..63e69a517987 100644 > --- a/include/uapi/linux/media.h > +++ b/include/uapi/linux/media.h > @@ -208,7 +208,13 @@ struct media_entity_desc { > #define MEDIA_PAD_FL_SINK (1U << 0) > #define MEDIA_PAD_FL_SOURCE (1U << 1) > #define MEDIA_PAD_FL_MUST_CONNECT (1U << 2) > +#if defined(__KERNEL__) > +/* > + * Forgo INTERNAL pads until proper documentation and v4l2-compliance testing is > + * merged. > + */ > #define MEDIA_PAD_FL_INTERNAL (1U << 3) > +#endif /* __KERNEL__ */ > > struct media_pad_desc { > __u32 entity; /* entity ID */