Linux Media Controller development
 help / color / mirror / Atom feed
From: Haipeng Lin <jimmie.lin@gmail.com>
To: Sergey Lebedev <lsa.uz@pm.me>,
	Sakari Ailus <sakari.ailus@linux.intel.com>,
	Mauro Carvalho Chehab <mchehab@kernel.org>,
	Hans de Goede <hansg@kernel.org>
Cc: Daniel Scally <dan.scally@ideasonboard.com>,
	Jakob Berg Jespersen <dev@berg.pm>,
	George Neacsu <geocausa@gmail.com>,
	Bryan O'Donoghue <bod@kernel.org>,
	German Pablo Lindo <germanpapulindez@gmail.com>,
	Simon Kruse <simon0x+git@proton.me>,
	linux-media@vger.kernel.org, platform-driver-x86@vger.kernel.org,
	linux-kernel@vger.kernel.org
Subject: Re: [PATCH v4] media: i2c: ov13858: add regulator, clock and reset GPIO handling
Date: Sat, 21 Nov 2026 14:02:25 -0500	[thread overview]
Message-ID: <6f70f43f-4fc3-47ee-802d-50ebc0a8394f@gmail.com> (raw)
In-Reply-To: <20261016210246.58562-1-lsa.uz@pm.me>

On 10/16/26 5:02 PM, Sergey Lebedev wrote:
> The driver assumes the sensor is already powered when probe() reads its
> chip ID. That holds where the rails and clock are ACPI power resources,
> but not where an INT3472 companion device registers them as regulators, a
> clock and a reset GPIO for the sensor driver to consume, which this
> driver does not do.
> 
> Request the three supplies and the reset GPIO, and sequence them along
> with the clock the driver already looks up, in runtime PM callbacks.

[...]

Hi Sergey,

Tested on a Surface Pro 11 (X1P-64-100, LCD, 5G) on a v7.3.4-based tree
with out-of-tree CCI/CAMSS and SP11 camera DT nodes and George's DT v2
patch on top:

- avdd, dovdd, dvdd, clock (19.2 MHz) and reset GPIO all come from DT;
  the sensor probes and streams 4224x3136 at ~30 fps through CAMSS and
  libcamera 0.7.2;
- All three supply rails are off when idle, on when streaming.
- v4l2-compliance on the subdev passes 46/46.

I did not test system suspend while streaming.

Tested-by: Haipeng Lin <jimmie.lin@gmail.com> # Surface Pro 11 (LCD 5G)

Thanks,
Haipeng


      parent reply	other threads:[~2026-11-21 19:02 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-10-16 21:02 [PATCH v4] media: i2c: ov13858: add regulator, clock and reset GPIO handling Sergey Lebedev
2026-11-06  7:59 ` Sergey Lebedev
2026-11-12  1:15 ` Emfox Zhou
2026-11-21 19:02 ` Haipeng Lin [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=6f70f43f-4fc3-47ee-802d-50ebc0a8394f@gmail.com \
    --to=jimmie.lin@gmail.com \
    --cc=bod@kernel.org \
    --cc=dan.scally@ideasonboard.com \
    --cc=dev@berg.pm \
    --cc=geocausa@gmail.com \
    --cc=germanpapulindez@gmail.com \
    --cc=hansg@kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-media@vger.kernel.org \
    --cc=lsa.uz@pm.me \
    --cc=mchehab@kernel.org \
    --cc=platform-driver-x86@vger.kernel.org \
    --cc=sakari.ailus@linux.intel.com \
    --cc=simon0x+git@proton.me \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox