From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx0b-0031df01.pphosted.com (mx0b-0031df01.pphosted.com [205.220.180.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id ADEC421E082 for ; Fri, 25 Apr 2025 19:46:15 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.180.131 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1745610377; cv=none; b=GRN2f4/rbIFsglYcF8zRCUCdODGYDANkEWZ9zVQ7anij5EdXdtvx6HpdZEh4PqkpM9QLyQRyHJ0VAXIl7WxNYd9M4L34rOK1WZA9Ue4HUYxgd8yiiuliRaFyT3UM+Tj7wbTvF0+sI//PeqJ5lz3DxZ2RD7DVLLvkTddgnT7Sf/0= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1745610377; c=relaxed/simple; bh=EYcZpPG7yUxj0IQg4aPHSivcB8VujVtyuNfcH0lfOmU=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=ViIFgtM3VDCakRcuiyU2fhONBkwxJrcbqaNPvMTJ0x/YgSfCP8TD9IYEheKQOROH25gKRoVwGfZu7W5AE/gZ/3F6Kx9HD+W7Ae1u6mo7lgvhiKgiNd5eLsTkkZtout7LiN0u++6VifcBp66fbJulXrFurzNjF75RbHcibG0wBcE= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=PI/Y9YrB; arc=none smtp.client-ip=205.220.180.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="PI/Y9YrB" Received: from pps.filterd (m0279872.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.2/8.18.1.2) with ESMTP id 53PGJqbD004615 for ; Fri, 25 Apr 2025 19:46:14 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= txmHliBipjwwY9cKV5mXKNOg/d2+Wp0mSjYmxJVTnsM=; b=PI/Y9YrBc8rGKFbT t733tafROHEh/Y9AqmCOICnxHjlYji22H5+UEiBGeHwnJj8rX/kSl294VhxZPBvr mIg23ZHNpuze+yIIkPbe4WVodIqHwxp4BEbQm/igEohhHavOwE2PDHuQIjjUmfox waeio1RAKiocCkMR0ILCSRHcyAKAv7l2g03icBX4ikibmvqPseTkTEtRzf2wEthw QOk2h2zW3fZRy65qsG8jj4rqFisMzj6+BeR7INfPc83qYWRiHf0H9eiiZxFr/2Hg S+DdktGYEScPSATl8cMSAC5CTDqNg8GQFIYm2JQMyNDTuyGV8eGTIWQ/RD1NsmHl Ba16Jg== Received: from mail-qt1-f199.google.com (mail-qt1-f199.google.com [209.85.160.199]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 466jh0a5mb-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128 verify=NOT) for ; Fri, 25 Apr 2025 19:46:14 +0000 (GMT) Received: by mail-qt1-f199.google.com with SMTP id d75a77b69052e-4775bdbcdc3so6343961cf.2 for ; Fri, 25 Apr 2025 12:46:14 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1745610374; x=1746215174; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=txmHliBipjwwY9cKV5mXKNOg/d2+Wp0mSjYmxJVTnsM=; b=TlRefG4+jqFMu+sHTzeQ5nOpm6xkUDmtaXyALkDUdeJadeL2dgUZQIcsHLyXVsMb+/ zBRy2WaacEzpcjYz6e/9pZKP2e4MCrvRXu8UHq5Qe+XtkUsNSKY/8TxGVtTsaZ2W0Xml aIyweMlS1TF8ZciQeobA1NmsifuNRX40uySgj0VzbabTUIRiS0quhh+5JhxrhiYdWp41 U0JZOg/9KUnruXCh2BYpBdB/ZI37s0pDVsACBY5juWMH1azuAYPQz7Rj0aMR1FjQTblV QxvyxU3y/E7a2dqFgbWqnKkDfQRNK5ZB5eJt0wnAGc9BRj7q2HCYQoc5ptKsOdGA1Ddv KB5Q== X-Forwarded-Encrypted: i=1; AJvYcCVbyLeGSAQDPc/frw8ka7xER+yQoQKddYO0nJJcgfmO9egE4vCAXJJVmFdszcLpKjQ3z4nVnmoDWj3pUg==@vger.kernel.org X-Gm-Message-State: AOJu0YzNmEWIiR5C7euMdJTiadAo0MJJhNyab+Gm3KYFAeXu1TP6DybH m6p68JT57mncFiu81pn43OqhUBUsCpYtu7kwFBG+KIMXDFvpFdJFtbZHC6umiNn8gg3RgNh0CPY ne+ryRlZEKW9BFPzWd49pLQA7fOlCaUYmeiqtWH3Rb1TjDF57ekUCKcmXCSLZhA== X-Gm-Gg: ASbGncv67KJYZgu5Ae+duXm+F5gkX5dsJWLS0BqVmV7TwwoQ5fwfhOLt8Zn4ye7iKqX NhExLErTi72p0j1ol/pSCOEaKEJ00p4hJzwtr47w6K7htd+CCqU+uS//2cTwDL8gUCckk6w/v7v fJfUhv1cGWBEJ+Byy+kQv0ram00qVDHfBnrHbT+X5DxYBKCPPeO4KAOo4PrtZ6svpYNh1AXl04S fsDSTKUVOY7/z9PNjVxCV4PI8wVSIDueCoueNtExbWO95yp1G6oJ2hu2GagFqfg+xBaDFWEETDt He8kNn8PdXOGNd8lxRpljGdTHo3k9eQEMTjP9xrEwbESb0U2BwcQH0DqcsdQwszsLrc= X-Received: by 2002:ac8:7fd3:0:b0:472:15be:54ad with SMTP id d75a77b69052e-4801e6f120bmr20112841cf.14.1745610373886; Fri, 25 Apr 2025 12:46:13 -0700 (PDT) X-Google-Smtp-Source: AGHT+IFOzMshPGNoqCx2ULNNdKD/xPe4MbaDbP1omZuzKgujBuWwyI50zrrqVnQ3wtP40FpGp1u29g== X-Received: by 2002:ac8:7fd3:0:b0:472:15be:54ad with SMTP id d75a77b69052e-4801e6f120bmr20112651cf.14.1745610373572; Fri, 25 Apr 2025 12:46:13 -0700 (PDT) Received: from [192.168.65.156] (078088045245.garwolin.vectranet.pl. [78.88.45.245]) by smtp.gmail.com with ESMTPSA id a640c23a62f3a-ace6e578955sm183455366b.74.2025.04.25.12.46.11 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 25 Apr 2025 12:46:13 -0700 (PDT) Message-ID: <71190e3d-fa9b-4fdd-83ac-bf012031c836@oss.qualcomm.com> Date: Fri, 25 Apr 2025 21:46:11 +0200 Precedence: bulk X-Mailing-List: linux-media@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH 3/6] media: qcom: camss: csiphy-3ph: Add CSIPHY 2ph DPHY v2.0.1 init sequence To: Loic Poulain , Dmitry Baryshkov Cc: bryan.odonoghue@linaro.org, rfoss@kernel.org, konradybcio@kernel.org, andersson@kernel.org, krzk+dt@kernel.org, robh@kernel.org, linux-arm-msm@vger.kernel.org, linux-media@vger.kernel.org, devicetree@vger.kernel.org References: <20250416120908.206873-1-loic.poulain@oss.qualcomm.com> <20250416120908.206873-3-loic.poulain@oss.qualcomm.com> Content-Language: en-US From: Konrad Dybcio In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-Proofpoint-Spam-Details-Enc: AW1haW4tMjUwNDI1MDE0MSBTYWx0ZWRfXyhFWqDLct5kZ gMJZz/i2I1srqp8n0IuHthYLdMAEPc/ouRvE3K6M3LC3UdpLDMw9V6EQQNt1DuEoO5q+gLR5SlZ 1YdnkYMXLXnvK7ws2lkGoW70akO4d6A+7dPzl0Wu2TLQZJW/efTQBiNgDY4gsPT3Et/T8TBgtXc Cr1lJb73TqEW42b36PL6t2BjcfcNhprDoXFzeflkJAxnnK2jo/Dc/iQ7vOckhXGLFKa/QA0ikjP ZWFFJJRHrfanjaq/ituG5ra6IfP78ldbMcbCV3WKGsfWHiRYuZLSbDBsS5XRZne4I8FjkXsvb0y KLoLBGWRRoR35zeQx72AwbxkonJ3SL6ke56TXqVgG2O0k+Ke6iNhlURw8cZQkATxbyQ9NmgFHR6 S6yhvL/WynkOMIrsdX+ZLGl0T2J+nS271ciw8+VHxEkyjAaEH3QEWJMqcAY36VuEOfbvLFAf X-Proofpoint-GUID: pKA60UvpqoxPeVCB4cfnkulXiXUT76t_ X-Authority-Analysis: v=2.4 cv=ZuTtK87G c=1 sm=1 tr=0 ts=680be686 cx=c_pps a=WeENfcodrlLV9YRTxbY/uA==:117 a=FpWmc02/iXfjRdCD7H54yg==:17 a=IkcTkHD0fZMA:10 a=XR8D0OoHHMoA:10 a=EUspDBNiAAAA:8 a=wkiucLSIQwEx8sfLkT8A:9 a=3ZKOabzyN94A:10 a=QEXdDO2ut3YA:10 a=kacYvNCVWA4VmyqE58fU:22 X-Proofpoint-ORIG-GUID: pKA60UvpqoxPeVCB4cfnkulXiXUT76t_ X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1099,Hydra:6.0.736,FMLib:17.12.80.40 definitions=2025-04-25_06,2025-04-24_02,2025-02-21_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 phishscore=0 clxscore=1015 impostorscore=0 bulkscore=0 mlxscore=0 adultscore=0 lowpriorityscore=0 mlxlogscore=999 priorityscore=1501 malwarescore=0 suspectscore=0 spamscore=0 classifier=spam authscore=0 authtc=n/a authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.19.0-2504070000 definitions=main-2504250141 On 4/17/25 10:26 AM, Loic Poulain wrote: > Hi Dmitry, > > On Thu, Apr 17, 2025 at 12:36 AM Dmitry Baryshkov > wrote: >> >> On Wed, Apr 16, 2025 at 02:09:05PM +0200, Loic Poulain wrote: >>> This is the CSI PHY version found in QCS2290/QCM2290 SoCs. >>> The table is extracted from downstream camera driver. >>> >>> Signed-off-by: Loic Poulain >>> --- >>> .../qcom/camss/camss-csiphy-3ph-1-0.c | 89 +++++++++++++++++++ >>> drivers/media/platform/qcom/camss/camss.h | 1 + >>> 2 files changed, 90 insertions(+) >>> >>> diff --git a/drivers/media/platform/qcom/camss/camss-csiphy-3ph-1-0.c b/drivers/media/platform/qcom/camss/camss-csiphy-3ph-1-0.c >>> index f732a76de93e..0e314ff9292f 100644 >>> --- a/drivers/media/platform/qcom/camss/camss-csiphy-3ph-1-0.c >>> +++ b/drivers/media/platform/qcom/camss/camss-csiphy-3ph-1-0.c >>> @@ -319,6 +319,90 @@ csiphy_lane_regs lane_regs_sm8250[] = { >>> {0x0884, 0x01, 0x00, CSIPHY_DEFAULT_PARAMS}, >>> }; >>> >>> +/* GEN2 2.0.1 2PH DPHY mode */ >>> +static const struct >>> +csiphy_lane_regs lane_regs_qcm2290[] = { >>> + {0x0030, 0x02, 0x00, CSIPHY_DEFAULT_PARAMS}, >>> + {0x002C, 0x01, 0x00, CSIPHY_DEFAULT_PARAMS}, >> >> lowercase hex, please. > > I don't mind, but all other phy tables use upper case hex. Ugh, we've been trying to get some unity in place but that's an eternal WIP Konrad