Re: [PATCH 0/2] arm64: dts: imx8mp: Add support for the ISPs

Tommaso Merciai
2023-11-29T11:17:00Z

Hi Paul, Laurent,

On Wed, Nov 29, 2023 at 06:31:11PM +0900, Paul Elder wrote:
> This patch series adds support to the i.MX8MP device tree for the ISPs.
>
> Laurent Pinchart (1):
> arm64: dts: imx8mp: Add overlays for ISP instances
>
> Paul Elder (1):
> arm64: dts: imx8mp: Add DT nodes for the two ISPs

Tested also on my side with the following setup:

imx8mp-evk + ov5640
imx8mp-evk + alvium-1500c-500

Below some logs:

imx8mp-evk + ov5640
----------------------------------------------------------------------------------------------------------------
Media device information
--------------------
driver rkisp1
model rkisp1
serial
bus info platform:rkisp1
hw revision 0xe
driver version 6.7.0

Device topology
- entity 1: rkisp1_isp (4 pads, 4 links)
type V4L2 subdev subtype Unknown flags 0
device node name /dev/v4l-subdev0
pad0: Sink
[fmt:SRGGB10_1X10/800x600 field:none colorspace:raw xfer:none ycbcr:601 quantization:full-range
crop.bounds:(0,0)/800x600
crop:(0,0)/800x600]
<- "csis-32e40000.csi":1 [ENABLED]
pad1: Sink
[fmt:unknown/0x0 field:none]
<- "rkisp1_params":0 [ENABLED,IMMUTABLE]
pad2: Source
[fmt:YUYV8_2X8/800x600 field:none colorspace:srgb xfer:srgb ycbcr:601 quantization:lim-range
crop.bounds:(0,0)/800x600
crop:(0,0)/800x600]
-> "rkisp1_resizer_mainpath":0 [ENABLED]
pad3: Source
[fmt:unknown/0x0 field:none]
-> "rkisp1_stats":0 [ENABLED,IMMUTABLE]

- entity 6: rkisp1_resizer_mainpath (2 pads, 2 links)
type V4L2 subdev subtype Unknown flags 0
device node name /dev/v4l-subdev1
pad0: Sink
[fmt:YUYV8_2X8/800x600 field:none colorspace:srgb xfer:srgb ycbcr:601 quantization:lim-range
crop.bounds:(0,0)/800x600
crop:(0,0)/800x600]
<- "rkisp1_isp":2 [ENABLED]
pad1: Source
[fmt:YUYV8_2X8/800x600 field:none colorspace:srgb xfer:srgb ycbcr:601 quantization:lim-range]
-> "rkisp1_mainpath":0 [ENABLED,IMMUTABLE]

- entity 9: rkisp1_mainpath (1 pad, 1 link)
type Node subtype V4L flags 0
device node name /dev/video0
pad0: Sink
<- "rkisp1_resizer_mainpath":1 [ENABLED,IMMUTABLE]

- entity 13: rkisp1_stats (1 pad, 1 link)
type Node subtype V4L flags 0
device node name /dev/video1
pad0: Sink
<- "rkisp1_isp":3 [ENABLED,IMMUTABLE]

- entity 17: rkisp1_params (1 pad, 1 link)
type Node subtype V4L flags 0
device node name /dev/video2
pad0: Source
-> "rkisp1_isp":1 [ENABLED,IMMUTABLE]

- entity 29: csis-32e40000.csi (2 pads, 2 links)
type V4L2 subdev subtype Unknown flags 0
device node name /dev/v4l-subdev2
pad0: Sink
[fmt:UYVY8_1X16/640x480 field:none colorspace:smpte170m xfer:709 ycbcr:601 quantization:lim-range]
<- "ov5640 1-003c":0 []
pad1: Source
[fmt:UYVY8_1X16/640x480 field:none colorspace:smpte170m xfer:709 ycbcr:601 quantization:lim-range]
-> "rkisp1_isp":0 [ENABLED]

- entity 34: ov5640 1-003c (1 pad, 1 link)
type V4L2 subdev subtype Sensor flags 0
device node name /dev/v4l-subdev3
pad0: Source
[fmt:UYVY8_1X16/640x480@1/30 field:none colorspace:srgb xfer:srgb ycbcr:601 quantization:full-range
crop.bounds:(0,0)/2624x1964
crop:(16,14)/2592x1944]
-> "csis-32e40000.csi":0 []

root@imx8mp-lpddr4-evk:~#
root@imx8mp-lpddr4-evk:~# uname -a
Linux imx8mp-lpddr4-evk 6.7.0-rc2-gff66adbac1c2 #277 SMP PREEMPT Wed Nov 29 11:40:48 CET 2023 aarch64 GNU/Linux
----------------------------------------------------------------------------------------------------------------

imx8mp-evk + alvium 1500c-500:
----------------------------------------------------------------------------------------------------------------

Media device information
--------------------
driver rkisp1
model rkisp1
serial
bus info platform:rkisp1
hw revision 0xe
driver version 6.7.0

Device topology
- entity 1: rkisp1_isp (4 pads, 4 links)
type V4L2 subdev subtype Unknown flags 0
device node name /dev/v4l-subdev0
pad0: Sink
[fmt:SRGGB10_1X10/800x600 field:none colorspace:raw xfer:none ycbcr:601 quantization:full-range
crop.bounds:(0,0)/800x600
crop:(0,0)/800x600]
<- "csis-32e40000.csi":1 [ENABLED]
pad1: Sink
[fmt:unknown/0x0 field:none]
<- "rkisp1_params":0 [ENABLED,IMMUTABLE]
pad2: Source
[fmt:YUYV8_2X8/800x600 field:none colorspace:srgb xfer:srgb ycbcr:601 quantization:lim-range
crop.bounds:(0,0)/800x600
crop:(0,0)/800x600]
-> "rkisp1_resizer_mainpath":0 [ENABLED]
pad3: Source
[fmt:unknown/0x0 field:none]
-> "rkisp1_stats":0 [ENABLED,IMMUTABLE]

- entity 6: rkisp1_resizer_mainpath (2 pads, 2 links)
type V4L2 subdev subtype Unknown flags 0
device node name /dev/v4l-subdev1
pad0: Sink
[fmt:YUYV8_2X8/800x600 field:none colorspace:srgb xfer:srgb ycbcr:601 quantization:lim-range
crop.bounds:(0,0)/800x600
crop:(0,0)/800x600]
<- "rkisp1_isp":2 [ENABLED]
pad1: Source
[fmt:YUYV8_2X8/800x600 field:none colorspace:srgb xfer:srgb ycbcr:601 quantization:lim-range]
-> "rkisp1_mainpath":0 [ENABLED,IMMUTABLE]

- entity 9: rkisp1_mainpath (1 pad, 1 link)
type Node subtype V4L flags 0
device node name /dev/video0
pad0: Sink
<- "rkisp1_resizer_mainpath":1 [ENABLED,IMMUTABLE]

- entity 13: rkisp1_stats (1 pad, 1 link)
type Node subtype V4L flags 0
device node name /dev/video1
pad0: Sink
<- "rkisp1_isp":3 [ENABLED,IMMUTABLE]

- entity 17: rkisp1_params (1 pad, 1 link)
type Node subtype V4L flags 0
device node name /dev/video2
pad0: Source
-> "rkisp1_isp":1 [ENABLED,IMMUTABLE]

- entity 29: csis-32e40000.csi (2 pads, 2 links)
type V4L2 subdev subtype Unknown flags 0
device node name /dev/v4l-subdev2
pad0: Sink
[fmt:UYVY8_1X16/640x480 field:none colorspace:smpte170m xfer:709 ycbcr:601 quantization:lim-range]
<- "alvium-csi2 1-003c":0 []
pad1: Source
[fmt:UYVY8_1X16/640x480 field:none colorspace:smpte170m xfer:709 ycbcr:601 quantization:lim-range]
-> "rkisp1_isp":0 [ENABLED]

- entity 34: alvium-csi2 1-003c (1 pad, 1 link)
type V4L2 subdev subtype Sensor flags 0
device node name /dev/v4l-subdev3
pad0: Source
[fmt:UYVY8_1X16/640x480@1/10 field:none colorspace:srgb xfer:srgb ycbcr:601 quantization:full-range
crop.bounds:(0,0)/2592x1944
crop:(0,0)/640x480]
-> "csis-32e40000.csi":0 []

root@imx8mp-lpddr4-evk:~# uname -a
Linux imx8mp-lpddr4-evk 6.7.0-rc2-gff66adbac1c2 #277 SMP PREEMPT Wed Nov 29 11:40:48 CET 2023 aarch64 GNU/Linux

Hope this help.

Thanks & Regards,
Tommaso

>
> arch/arm64/boot/dts/freescale/Makefile | 2 +
> .../arm64/boot/dts/freescale/imx8mp-isp1.dtso | 36 +++++++++++++
> .../arm64/boot/dts/freescale/imx8mp-isp2.dtso | 36 +++++++++++++
> arch/arm64/boot/dts/freescale/imx8mp.dtsi | 50 +++++++++++++++++++
> 4 files changed, 124 insertions(+)
> create mode 100644 arch/arm64/boot/dts/freescale/imx8mp-isp1.dtso
> create mode 100644 arch/arm64/boot/dts/freescale/imx8mp-isp2.dtso
>
> --
> 2.39.2
>
>