From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-yw1-f175.google.com (mail-yw1-f175.google.com [209.85.128.175]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 621372FD1D0 for ; Sat, 18 Apr 2026 15:34:41 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.175 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1776526484; cv=none; b=HofloDzIcI8CJ668neh6ouIGSOe8kISoGYcdU0M4ivnc4ZclBIhFUnBTReFg1U5dL5eKrbIWB43Y1c3mlNrPxrNPb32Jth14c4AFB+xwXJJ07gM//n3szk2whVGnggqSXwCDCEPlPJercvjQ6B8uXMICvRSBfkkLCj+zhIZCuF0= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1776526484; c=relaxed/simple; bh=TPzN5DMU8T/18hixWg+6FbE+3zhkzJJf8xccVhqSMfU=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=FKrrzi5SmhTzB/NWZdGWIDC8cRdnVEItP+nOVSdp0M1SgARx1jt1QaTKo/Qrzei3MLah3vTJk87lO7iOfNr0YDuABcE8vRHmBvT0SL8DwpH1LZ0lpywxfEXxK4FYQTbwdtIjI8oec28rP1q4HQoIcdbdCnvdSNDd9xCk3o2OojI= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=e2sPNMUH; arc=none smtp.client-ip=209.85.128.175 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="e2sPNMUH" Received: by mail-yw1-f175.google.com with SMTP id 00721157ae682-7b248750279so15155317b3.0 for ; Sat, 18 Apr 2026 08:34:41 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1776526480; x=1777131280; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=NhKODv+ebTXJdAnj2Ac0AlyQFoZRAIerJIUSEYuuE+s=; b=e2sPNMUHwQKNFxBRt9bexCJ7KiZUbIjPEp2KZ0QTgLwoeUhdJAZDtlQ3wqLmm9ftq4 9AYQRdBbeOKzg2VMOaxw4iNCTkrADpJAY16VodX/oxhSX1kyXVRpTXSxPAUd5BCPhuJg sAH8Ee24NG+6UJyXveWJywzJiyz22ktRBQsD98lLstJ1+yTdVXMZYuXRpHA++lp8mdK1 TfcziVZqgAtU7Jd57bx46JWaW3FQxYl8LG6ywgiI+EN1jyzQAaaS2GQ4BHFxESFoLElc yaQiSwCXP/cqy3qlRAktz3Q+CuOx/uvso2i/HPRkQ8yh/a2auhOegn6U9ENP+FLKOvDQ GdjQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1776526480; x=1777131280; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-gg:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=NhKODv+ebTXJdAnj2Ac0AlyQFoZRAIerJIUSEYuuE+s=; b=mSkLFsw+ptaIxc7GGuklLdxnT9XvWhCMl816bxm4Vus7Ur//dTZnA/yaoLmHz62/vs dGti4rMZNdhPfRAh/QX2Hr8kA3oZcB6ghxTX74n+BJScuaQdgsYCj5tpDfg6BhHb6lLd qQmPCof/05lFwwiN6ayZoTx4lS/aKiFnRLgqZcn5kzegeFxIbDeep19MmPPC04kOvc8d r5AhCKsWh4AuQ/hiyAESGJu8HIkfmqKkHjbFZaFAeAqxWCuczJJtKWU3YEOUK00UIerC K6wj0PZ0el1irR4EYlJtX6bB0MNDQiS6WaImH7xc/N903vT3QL4ph3BViqRuf8GwsJX/ aXtA== X-Gm-Message-State: AOJu0YwOyCQ17f3s9drj6fz8dMv2D5uOFJLIDf8NWrMdPumAFw13b8k6 YGj7MWI+EP0ng7O3Gs8ATRWlMuOKHO7d06NcP78b/z1O2UxYNwWXx5E3 X-Gm-Gg: AeBDies64ryj3I5LGgtsh0QXb/CRt0SA7e2ElSAdVzfA76eW8QrO/4jOGn5MloKdOcm RAOJYFtAk9i6JTtFClFdR50w3CAlH0YmX4XCDpzlzdOLXKGA/7ER21GjY+p0Zt7VsmNixdsJ2eU eJ9PfHfD0nUxZ9CSyH1dGg6JflV9tJctHrypeG80fHQP9KlgO7ZZBofl0VZSdZbfA45SpBaJ/sK xp91CjF+ZWTCMeu7BGL9FthNEwSIu7YjDAzHKpjirxxwE0of/vTGWTgMIBUX1wEyySggoyyziMQ DUnI06FbNIjt0ern5PXIdOg19Z2+xb3FJY7s/F9MFv0TVa/EOR23QFrB8rCprgGg6m0FbLz7taP 7jABooLPTK6j4fnvFnXvWFq6pTCXUfsVjh6WZGLrjcOIaAC6tPk3K5lW2eH7aoNWbKRJSpijf90 NX/FtrBvdY2AWwRyPaj3H+3cZKUpmWVkypddet X-Received: by 2002:a05:690c:e3cb:b0:7b2:9347:7be1 with SMTP id 00721157ae682-7b9ecf86543mr73129417b3.29.1776526480099; Sat, 18 Apr 2026 08:34:40 -0700 (PDT) Received: from [192.168.0.39] ([79.133.247.80]) by smtp.gmail.com with ESMTPSA id 00721157ae682-7b9ee89aa91sm20380427b3.6.2026.04.18.08.34.35 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Sat, 18 Apr 2026 08:34:39 -0700 (PDT) Message-ID: <717459db-479a-4a68-84d1-a718c8ba5a54@gmail.com> Date: Sat, 18 Apr 2026 18:34:33 +0300 Precedence: bulk X-Mailing-List: linux-media@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH RFC 04/10] arm64: dts: qcom: msm8939: Add venus node To: Bryan O'Donoghue , Vikash Garodia , Dikshita Agarwal , Mauro Carvalho Chehab , Rob Herring , Krzysztof Kozlowski , Conor Dooley , =?UTF-8?Q?Andr=C3=A9_Apitzsch?= , Bjorn Andersson , Konrad Dybcio , Michael Turquette , Stephen Boyd Cc: linux-media@vger.kernel.org, linux-arm-msm@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-clk@vger.kernel.org, ~postmarketos/upstreaming@lists.sr.ht, phone-devel@vger.kernel.org References: <20260416-msm8939-venus-rfc-v1-0-a09fcf2c23df@gmail.com> <20260416-msm8939-venus-rfc-v1-4-a09fcf2c23df@gmail.com> Content-Language: en-US From: Erikas Bitovtas In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit On 4/16/26 5:31 PM, Bryan O'Donoghue wrote: > On 16/04/2026 14:43, Erikas Bitovtas wrote: >> +            video-decoder { >> +                compatible = "venus-decoder"; >> +                clocks = <&gcc GCC_VENUS0_CORE0_VCODEC0_CLK>, >> +                     <&gcc GCC_VENUS0_CORE1_VCODEC0_CLK>; >> +                clock-names = "core0", "core1"; >> +                power-domains = <&gcc VENUS_CORE0_GDSC>, >> +                        <&gcc VENUS_CORE1_GDSC>; > > This doesn't make sense. > > You have two cores => assign one to encoder and the other to decoder. > This way during decode only one of the cores gets powered up instead of both, resulting in power collapse fails. Core clocks and power domains can be moved into Venus node instead of sub-nodes, like this: venus: video-codec@1d00000 { compatible = "qcom,msm8939-venus"; reg = <0x01d00000 0xff000>; interrupts = ; clocks = <&gcc GCC_VENUS0_VCODEC0_CLK>, <&gcc GCC_VENUS0_AHB_CLK>, <&gcc GCC_VENUS0_AXI_CLK>, <&gcc GCC_VENUS0_CORE0_VCODEC0_CLK>, <&gcc GCC_VENUS0_CORE1_VCODEC0_CLK>; clock-names = "core", "iface", "bus", "core0", "core1"; power-domains = <&gcc VENUS_GDSC>, <&gcc VENUS_C0RE0_GDSC>, <&gcc VENUS_CORE1_GDSC>; power-domain-names = "venus", "core0", "core1"; }; And then they can be powered up regardless if the session is for encoding or decoding. My first question was actually about this - whether these cores should be powered up only decoding or for encoding as well. Bus configs downstream signify they are only for decoding: https://github.com/msm8916-mainline/linux-downstream/blob/b20608408caff817ec874f325127b07609fbaeb8/arch/arm/boot/dts/qcom/msm8939-common.dtsi#L1589 https://github.com/msm8916-mainline/linux-downstream/blob/b20608408caff817ec874f325127b07609fbaeb8/Documentation/devicetree/bindings/media/video/msm-vidc.txt#L35 Unfortunately, I couldn't test encoding on my device. It appears to be broken.