Linux Media Controller development
 help / color / mirror / Atom feed
From: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
To: Sean Young <sean@mess.org>, linux-media@vger.kernel.org
Cc: Sicelo <absicsz@gmail.com>, "Rob Herring" <robh+dt@kernel.org>,
	"Krzysztof Kozlowski" <krzysztof.kozlowski+dt@linaro.org>,
	"Conor Dooley" <conor+dt@kernel.org>,
	devicetree@vger.kernel.org,
	"Ivaylo Dimitrov" <ivo.g.dimitrov.75@gmail.com>,
	"Pali Rohár" <pali.rohar@gmail.com>,
	"Pavel Machek" <pavel@ucw.cz>,
	"Timo Kokkonen" <timo.t.kokkonen@iki.fi>,
	"Tony Lindgren" <tony@atomide.com>
Subject: Re: [PATCH v2 2/2] media: dt-bindings: media: remove nokia,n900-ir as pwm-ir-tx is compatible
Date: Tue, 22 Aug 2023 11:36:00 +0200	[thread overview]
Message-ID: <720259b1-1f7f-fa86-2480-3b3d8d3fca33@linaro.org> (raw)
In-Reply-To: <590a7e74-5af1-1aa3-366b-4fef039e5f66@linaro.org>

On 22/08/2023 11:28, Krzysztof Kozlowski wrote:
> On 22/08/2023 11:12, Sean Young wrote:
>> The generic pwm-ir-tx driver works for the Nokia n900, so nokia,n900-ir
>> can be removed.
>>
>> Cc: Sicelo <absicsz@gmail.com>
>> Cc: Rob Herring <robh+dt@kernel.org>
>> Cc: Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>
>> Cc: Conor Dooley <conor+dt@kernel.org>
>> Cc: devicetree@vger.kernel.org
>> Cc: Ivaylo Dimitrov <ivo.g.dimitrov.75@gmail.com>
>> Cc: Pali Rohár <pali.rohar@gmail.com>
>> Cc: Pavel Machek <pavel@ucw.cz>
>> Cc: Timo Kokkonen <timo.t.kokkonen@iki.fi>
>> Cc: Tony Lindgren <tony@atomide.com>
>> Signed-off-by: Sean Young <sean@mess.org>
> 
> Unfortunately not much improved here, so:
> 1. Please use scripts/get_maintainers.pl to get a list of necessary
> people and lists to CC. It might happen, that command when run on an
> older kernel, gives you outdated entries. Therefore please be sure you
> base your patches on recent Linux kernel.
> 
> You missed at least DT list (maybe more), so this won't be tested by
> automated tooling. Performing review on untested code might be a waste
> of time, thus I will skip this patch entirely till you follow the
> process allowing the patch to be tested.
> 
> Please kindly resend and include all necessary To/Cc entries.

Ykes, my bad, the DT list is there. Therefore you can expect Rob's bot
with complains.

> 
> 2. Test your bindings before sending. Especially if you decide to
> opt-out from automatic testing :/

Testing before sending is still needed, though.


Best regards,
Krzysztof


  reply	other threads:[~2023-08-22  9:36 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-08-22  9:12 [PATCH v2 0/2] Remove ir-rx51 driver Sean Young
2023-08-22  9:12 ` [PATCH v2 1/2] media: rc: remove ir-rx51 in favour of generic pwm-ir-tx Sean Young
2023-08-22  9:12 ` [PATCH v2 2/2] media: dt-bindings: media: remove nokia,n900-ir as pwm-ir-tx is compatible Sean Young
2023-08-22  9:28   ` Krzysztof Kozlowski
2023-08-22  9:36     ` Krzysztof Kozlowski [this message]
2023-08-22  9:56     ` Sean Young
2023-08-22 11:37       ` Krzysztof Kozlowski
2023-08-22 14:18         ` Sean Young
2023-08-22 10:14   ` Rob Herring

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=720259b1-1f7f-fa86-2480-3b3d8d3fca33@linaro.org \
    --to=krzysztof.kozlowski@linaro.org \
    --cc=absicsz@gmail.com \
    --cc=conor+dt@kernel.org \
    --cc=devicetree@vger.kernel.org \
    --cc=ivo.g.dimitrov.75@gmail.com \
    --cc=krzysztof.kozlowski+dt@linaro.org \
    --cc=linux-media@vger.kernel.org \
    --cc=pali.rohar@gmail.com \
    --cc=pavel@ucw.cz \
    --cc=robh+dt@kernel.org \
    --cc=sean@mess.org \
    --cc=timo.t.kokkonen@iki.fi \
    --cc=tony@atomide.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox