From: Dan Scally <dan.scally@ideasonboard.com>
To: Sakari Ailus <sakari.ailus@linux.intel.com>, linux-media@vger.kernel.org
Cc: "Rafael J. Wysocki" <rafael@kernel.org>,
linux-acpi@vger.kernel.org, "Len Brown" <lenb@kernel.org>,
"Hans de Goede" <hansg@kernel.org>,
"Ilpo Järvinen" <ilpo.jarvinen@linux.intel.com>,
platform-driver-x86@vger.kernel.org
Subject: Re: [PATCH v3 1/3] platform/x86: int3472: Address Coccinelle warning on an error print
Date: Thu, 27 Aug 2026 09:25:20 +0100 [thread overview]
Message-ID: <7356012b-b5aa-4d11-8dbe-30cd82dfe3b8@ideasonboard.com> (raw)
In-Reply-To: <20260825203553.3725132-2-sakari.ailus@linux.intel.com>
Hi Sakari - thanks for the patches
On 25/08/2026 21:35, Sakari Ailus wrote:
> Fix the following Coccinelle warning:
>
> ./tps68470.c:164:58-65: WARNING: Consider using %pe to print PTR_ERR()
>
> by using %pe specifier for printing an error code.
>
> Signed-off-by: Sakari Ailus <sakari.ailus@linux.intel.com>
> Reviewed-by: Ilpo Järvinen <ilpo.jarvinen@linux.intel.com>
> ---
Reviewed-by: Daniel Scally <dan.scally@ideasonboard.com>
> drivers/platform/x86/intel/int3472/tps68470.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/platform/x86/intel/int3472/tps68470.c b/drivers/platform/x86/intel/int3472/tps68470.c
> index a77ed32abe55..dc777dbac61f 100644
> --- a/drivers/platform/x86/intel/int3472/tps68470.c
> +++ b/drivers/platform/x86/intel/int3472/tps68470.c
> @@ -161,7 +161,7 @@ static int skl_int3472_tps68470_probe(struct i2c_client *client)
>
> regmap = devm_regmap_init_i2c(client, &tps68470_regmap_config);
> if (IS_ERR(regmap)) {
> - dev_err(&client->dev, "Failed to create regmap: %ld\n", PTR_ERR(regmap));
> + dev_err(&client->dev, "Failed to create regmap: %pe\n", regmap);
> return PTR_ERR(regmap);
> }
>
next prev parent reply other threads:[~2026-08-27 8:25 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-08-25 20:35 [PATCH v3 0/3] Fix static analyser and compiler warnings in int3472 Sakari Ailus
2026-08-25 20:35 ` [PATCH v3 1/3] platform/x86: int3472: Address Coccinelle warning on an error print Sakari Ailus
2026-08-25 21:01 ` Ricardo Ribalda Delgado
2026-08-27 8:25 ` Dan Scally [this message]
2026-08-25 20:35 ` [PATCH v3 2/3] platform/x86: int3472: Fix uninitialised variable warning Sakari Ailus
2026-08-25 21:04 ` Ricardo Ribalda Delgado
2026-08-26 7:04 ` Sakari Ailus
2026-08-27 11:16 ` Dan Scally
2026-08-25 20:35 ` [PATCH v3 3/3] platform/x86: int3472: Clean up GPIO parsing Sakari Ailus
2026-08-27 11:39 ` Dan Scally
2026-08-26 10:41 ` [PATCH v3 0/3] Fix static analyser and compiler warnings in int3472 Rafael J. Wysocki (Intel)
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=7356012b-b5aa-4d11-8dbe-30cd82dfe3b8@ideasonboard.com \
--to=dan.scally@ideasonboard.com \
--cc=hansg@kernel.org \
--cc=ilpo.jarvinen@linux.intel.com \
--cc=lenb@kernel.org \
--cc=linux-acpi@vger.kernel.org \
--cc=linux-media@vger.kernel.org \
--cc=platform-driver-x86@vger.kernel.org \
--cc=rafael@kernel.org \
--cc=sakari.ailus@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).