From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 3E6BEC678D5 for ; Thu, 9 Mar 2023 02:23:04 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229999AbjCICXD (ORCPT ); Wed, 8 Mar 2023 21:23:03 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:47748 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229484AbjCICXB (ORCPT ); Wed, 8 Mar 2023 21:23:01 -0500 Received: from fd01.gateway.ufhost.com (fd01.gateway.ufhost.com [61.152.239.71]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 219C23595; Wed, 8 Mar 2023 18:22:55 -0800 (PST) Received: from EXMBX166.cuchost.com (unknown [175.102.18.54]) (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits)) (Client CN "EXMBX166", Issuer "EXMBX166" (not verified)) by fd01.gateway.ufhost.com (Postfix) with ESMTP id E813724E2B2; Thu, 9 Mar 2023 10:22:52 +0800 (CST) Received: from EXMBX073.cuchost.com (172.16.6.83) by EXMBX166.cuchost.com (172.16.6.76) with Microsoft SMTP Server (TLS) id 15.0.1497.42; Thu, 9 Mar 2023 10:22:52 +0800 Received: from [192.168.60.132] (180.164.60.184) by EXMBX073.cuchost.com (172.16.6.83) with Microsoft SMTP Server (TLS) id 15.0.1497.42; Thu, 9 Mar 2023 10:22:49 +0800 Message-ID: <738921f2-0ec6-9418-2b6a-8df2a2e95130@starfivetech.com> Date: Thu, 9 Mar 2023 10:22:49 +0800 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.8.0 Subject: Re: [PATCH v1 10/11] media: uapi: add user space interfaces Content-Language: en-US To: Krzysztof Kozlowski , "Mauro Carvalho Chehab" , Robert Foss , Todor Tomov , Rob Herring , Krzysztof Kozlowski , Maxime Ripard , Philipp Zabel CC: , , , References: <20230302091921.43309-1-jack.zhu@starfivetech.com> <20230302091921.43309-11-jack.zhu@starfivetech.com> <58f7f327-5328-8c03-4a0f-783588705972@linaro.org> From: Jack Zhu In-Reply-To: <58f7f327-5328-8c03-4a0f-783588705972@linaro.org> Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 7bit X-Originating-IP: [180.164.60.184] X-ClientProxiedBy: EXCAS061.cuchost.com (172.16.6.21) To EXMBX073.cuchost.com (172.16.6.83) X-YovoleRuleAgent: yovoleflag Precedence: bulk List-ID: X-Mailing-List: linux-media@vger.kernel.org On 2023/3/3 16:44, Krzysztof Kozlowski wrote: > On 02/03/2023 10:19, jack.zhu wrote: >> This patch adds user space interfaces for ISP. > > Do not use "This commit/patch". > https://elixir.bootlin.com/linux/v5.17.1/source/Documentation/process/submitting-patches.rst#L95 > OK, I will fix it. > > Why this is a separate commit? User-space API is usually added with its > implementation. Otherwise how does your code even compile? > OK, I will merge them. thank you for your comments. > Best regards, > Krzysztof >