From: "David Härdeman" <david@hardeman.nu>
To: Mauro Carvalho Chehab <mchehab@osg.samsung.com>
Cc: "David Cimbůrek" <david.cimburek@gmail.com>,
"Luis de Bethencourt" <luis@debethencourt.com>,
"Antti Palosaari" <crope@iki.fi>,
linux-media@vger.kernel.org
Subject: Re: [PATCH] media: Pinnacle 73e infrared control stopped working since kernel 3.17
Date: Tue, 24 Feb 2015 14:47:08 +0100 [thread overview]
Message-ID: <743019811e24099226b55a708d7699af@hardeman.nu> (raw)
In-Reply-To: <20150224104438.53bcfd59@recife.lan>
On 2015-02-24 14:44, Mauro Carvalho Chehab wrote:
> Em Tue, 24 Feb 2015 11:15:53 +0100
> David Härdeman <david@hardeman.nu> escreveu:
>> The output that you gave (the actual scancodes that are generated) is
>> what I was looking for, not the keymap. If I remember correctly my
>> patch
>> wasn't supposed to change the generated scancodes (or the keymap would
>> have to be changed as well).
>>
>> The question is whether the right thing to do is to change back the
>> scancode calculation or to update the keymap. I'll try to have a
>> closer
>> look as soon as possible (which might take a few days more, sorry).
>
> I suspect we should change back the scancode calculation, as I think
> that
> the scancode table is right, but I need to do some tests with some
> other
> driver to be certain.
>
> I have a few devices here that I can use for testing, including a PCTV
> remote, just lacking the time.
I've exchanged a few more emails with David. I think I know what the
problem is now. It's not the NEC scancode generation, it's that my patch
accidentally broke the RC5 case (his remote is an RC5 one). I'll post a
patch later.
next prev parent reply other threads:[~2015-02-24 13:47 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-02-10 10:38 [PATCH] media: Pinnacle 73e infrared control stopped working since kernel 3.17 David Cimbůrek
2015-02-10 10:45 ` Antti Palosaari
2015-02-11 13:24 ` David Härdeman
2015-02-11 13:53 ` David Cimbůrek
2015-02-11 14:40 ` David Härdeman
2015-02-11 16:41 ` David Cimbůrek
2015-02-12 11:50 ` Mauro Carvalho Chehab
2015-02-12 17:34 ` David Cimbůrek
2015-02-12 21:57 ` Luis de Bethencourt
2015-02-13 19:58 ` David Cimbůrek
2015-02-24 10:08 ` David Cimbůrek
2015-02-24 10:15 ` David Härdeman
2015-02-24 13:44 ` Mauro Carvalho Chehab
2015-02-24 13:47 ` David Härdeman [this message]
2015-02-12 0:10 ` Luis de Bethencourt
2015-02-12 7:15 ` David Cimbůrek
2015-02-12 11:11 ` Luis de Bethencourt
-- strict thread matches above, loose matches on Subject: below --
2014-12-20 13:36 David Cimbůrek
2015-01-07 12:51 ` David Cimbůrek
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=743019811e24099226b55a708d7699af@hardeman.nu \
--to=david@hardeman.nu \
--cc=crope@iki.fi \
--cc=david.cimburek@gmail.com \
--cc=linux-media@vger.kernel.org \
--cc=luis@debethencourt.com \
--cc=mchehab@osg.samsung.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox