From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-oi1-f180.google.com (mail-oi1-f180.google.com [209.85.167.180]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 76FC527F75C for ; Wed, 15 Apr 2026 16:01:58 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.167.180 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1776268919; cv=none; b=drlkMOXcBcU7rMWEqc4r1DZDdGOg7tbKfFNxNl5Q/LGH/+sr2RFz4Go2qTuPIb62YF7mtOi9ycZMYkpjYx1S92QGwzf/Zo4/KE7PG1FCtR05kzte7j/QsgPlIArf5+2CYlRUwnjbho0GefT0g5gVeWqXDx7zz1A9HBOotkB3ABs= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1776268919; c=relaxed/simple; bh=9OQwdJAaUqJEWEM4yhSQg/nq0hBQ795EFYvkQdzYMYg=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=ljIjQm8kMw6zAnDugtUjwbqqAhWal7Yqav80MBk0dyNPo8pttIT610r9wx7taAOQ4LMkaNWFG9nVSVq+XiTB4JBdr/NxRng4zWuydVk9dqwdjGgNiLfjo6kgeaXdDFmis8rF+CiBmUznhnMzIY2LIOgyEBopW68AgvGiq9VEUjc= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linuxfoundation.org; spf=pass smtp.mailfrom=linuxfoundation.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b=TQGvhbpo; arc=none smtp.client-ip=209.85.167.180 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linuxfoundation.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linuxfoundation.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b="TQGvhbpo" Received: by mail-oi1-f180.google.com with SMTP id 5614622812f47-47952229034so2285024b6e.3 for ; Wed, 15 Apr 2026 09:01:58 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linuxfoundation.org; s=google; t=1776268917; x=1776873717; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=D245EE3tu0Tw+g3J8OtImxCPrOp3WNwVc9jRN+bNI/w=; b=TQGvhbpo+iZh34S5ubWWgOD3k51t5b5dg4xXdHOrn0K8qR7WTthctxESrYg4JY9sce aKEl3dT9kOh88f6lF0yZIA1Dpml9UJXOO4Of2qhwkmkOMtvd9sayFeXwClPHXYb0qokA AxyDX8fARQ+FLekt4vWjtNnVy34PLZVpAfGdQ= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1776268917; x=1776873717; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-gg:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=D245EE3tu0Tw+g3J8OtImxCPrOp3WNwVc9jRN+bNI/w=; b=qL7tZyNaIRe9T5tqqoeU8eBwrPCUrNJFbl/Plkh/tfjLfswMFV5EisY3zRmgOW7kqn nMH/81q+Shrwb4p619rJZQJ3SS8+ozPziq8Ad15xQVs41Du/4Atn9GeACRrDxpTnhNmU bo52fSFJizt80dpX3U7Pq0J3AeqQKgV6eHqPJIsSGXklzIECbQ1BS2w3waiXvnQWN7hf C5MhpKkMOInngm0miCWEbLfGanI3YQxk4a+wVXM79uLnP3MSTFyD5w4VC6KLsWEzsG9A OV5ViO6HwbjmeMTT9t1ya+Ua8IJzWMSQ5sjniUt3ZuNT2JrzDoWWPcrQNMHOM3U3PuEO t6lw== X-Forwarded-Encrypted: i=1; AFNElJ+wwLqVif0hwBhD0IcmbYY17s6JHcpPT72PeeEi/0SZirSTwe4e3zargbdeqn4eVQECCYpu1uQST8I0hw==@vger.kernel.org X-Gm-Message-State: AOJu0YwuVEqWKxGKX70Vt9ayIH9QCsc+GxOD+AuI/ldbzk8WRmUbfEOu QbZs3QFjd0z2gov4jothltEYcOlmY1iTqJC+U/9gmPoZrucLXpfqHzQQqFfQ80T2DWo= X-Gm-Gg: AeBDievuPfAVovdXfUJxM5vxaaEvoT5tvayHRgKR++5uz3I1r3roKS4BR16SSgN6lKI azU+Rx7SMNX7C/1kUwLlDpJs1ovqKQ8t7rwuJXA1QmJbyifUMk0dNk4OXlkblcmR/VD6Q3ad4JJ 2sjutnlYhL5D8eWrH9DWHYsISSS9jXFtGvomLJvSrUMswfHbkS98v3zjxv02wyQ8bZgWQt/QjuZ pLTtCYHors4gfjzJCWwJ5Yq73C6oPJoFNzA93qOPl3SDkoBppVG8TeX9AwcaPW9c0ownkQCJi7O eIZmTsBlfAjylxaxoasaKt46A3sNPNdQ1mqO+IGJG+hQNQdHey+fi/kdHwgWKinEf5dstHj6CnK +y3t0wP0dxd579v5JnSvGcbxy5YjVhMKfFJCCACmWH0y8SUb8bHLIgZixrWbByO9xnlopBo+b+a BBQitq+yZIngYhkpHmGOas42Ln9ljoIGU= X-Received: by 2002:a05:6808:23d6:b0:475:be2f:e1d1 with SMTP id 5614622812f47-4789f20ff8amr11366587b6e.39.1776268913811; Wed, 15 Apr 2026 09:01:53 -0700 (PDT) Received: from [192.168.1.14] ([38.15.57.99]) by smtp.gmail.com with ESMTPSA id 5614622812f47-4797a235f6bsm1063781b6e.4.2026.04.15.09.01.52 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 15 Apr 2026 09:01:52 -0700 (PDT) Message-ID: <75275f6e-8314-4dd6-a54e-95320c2224e2@linuxfoundation.org> Date: Wed, 15 Apr 2026 10:01:51 -0600 Precedence: bulk X-Mailing-List: linux-media@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH] media: vimc: fix reference leak on failed device registration To: Guangshuo Li , Kieran Bingham , Mauro Carvalho Chehab , Hans Verkuil , Dafna Hirschfeld , linux-media@vger.kernel.org, linux-kernel@vger.kernel.org Cc: stable@vger.kernel.org, Shuah Khan References: <20260415154537.3451732-1-lgs201920130244@gmail.com> Content-Language: en-US From: Shuah Khan In-Reply-To: <20260415154537.3451732-1-lgs201920130244@gmail.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit On 4/15/26 09:45, Guangshuo Li wrote: > When platform_device_register() fails in vimc_init(), the embedded > struct device in vimc_pdev has already been initialized by > device_initialize(), but the failure path returns the error without > dropping the device reference for the current platform device: > > vimc_init() > -> platform_device_register(&vimc_pdev) > -> device_initialize(&vimc_pdev.dev) > -> setup_pdev_dma_masks(&vimc_pdev) > -> platform_device_add(&vimc_pdev) > > This leads to a reference leak when platform_device_register() fails. > Fix this by calling platform_device_put() before returning the error. > > The issue was identified by a static analysis tool I developed and > confirmed by manual review. Can you share your manual review? Can other static analysis tools for example scripts/coccinelle support your findings? > > Fixes: 4babf057c143f ("media: vimc: allocate vimc_device dynamically") > Cc: stable@vger.kernel.org > Signed-off-by: Guangshuo Li > --- > drivers/media/test-drivers/vimc/vimc-core.c | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/drivers/media/test-drivers/vimc/vimc-core.c b/drivers/media/test-drivers/vimc/vimc-core.c > index 15167e127461..fee0c7a09c4f 100644 > --- a/drivers/media/test-drivers/vimc/vimc-core.c > +++ b/drivers/media/test-drivers/vimc/vimc-core.c > @@ -421,6 +421,7 @@ static int __init vimc_init(void) > if (ret) { > dev_err(&vimc_pdev.dev, > "platform device registration failed (err=%d)\n", ret); > + platform_device_put(&vimc_pdev); Where does platform_device_get() happen when platform_device_register() fails? thanks, -- Shuah