From mboxrd@z Thu Jan 1 00:00:00 1970 Return-path: Received: from galahad.ideasonboard.com ([185.26.127.97]:44347 "EHLO galahad.ideasonboard.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751895AbbDLOsi (ORCPT ); Sun, 12 Apr 2015 10:48:38 -0400 From: Laurent Pinchart To: Sakari Ailus Cc: linux-media@vger.kernel.org, Arnd Bergmann , Mauro Carvalho Chehab , Tony Lindgren , Tero Kristo , linux-arm-kernel@lists.infradead.org, linux-omap@vger.kernel.org Subject: Re: [PATCH] v4l: omap4iss: Replace outdated OMAP4 control pad API with syscon Date: Sun, 12 Apr 2015 17:48:56 +0300 Message-ID: <7568783.Noo5L2SBz3@avalon> In-Reply-To: <20150412143109.GP20756@valkosipuli.retiisi.org.uk> References: <3292592.cickJMVhRq@wuerfel> <1428841693-15109-1-git-send-email-laurent.pinchart@ideasonboard.com> <20150412143109.GP20756@valkosipuli.retiisi.org.uk> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Sender: linux-media-owner@vger.kernel.org List-ID: Hi Sakari, Thank you for the review. On Sunday 12 April 2015 17:31:09 Sakari Ailus wrote: > On Sun, Apr 12, 2015 at 03:28:13PM +0300, Laurent Pinchart wrote: > > diff --git a/drivers/staging/media/omap4iss/iss_csiphy.c > > b/drivers/staging/media/omap4iss/iss_csiphy.c index 7c3d55d..748607f > > 100644 > > --- a/drivers/staging/media/omap4iss/iss_csiphy.c > > +++ b/drivers/staging/media/omap4iss/iss_csiphy.c > > @@ -13,6 +13,7 @@ > > > > #include > > #include > > +#include > > > > #include "../../../../arch/arm/mach-omap2/control.h" > > > > @@ -140,9 +141,11 @@ int omap4iss_csiphy_config(struct iss_device *iss, > > * - bit [18] : CSIPHY1 CTRLCLK enable > > * - bit [17:16] : CSIPHY1 config: 00 d-phy, 01/10 ccp2 > > */ > > - cam_rx_ctrl = omap4_ctrl_pad_readl( > > - OMAP4_CTRL_MODULE_PAD_CORE_CONTROL_CAMERA_RX); > > - > > + /* > > + * TODO: When implementing DT support specify the CONTROL_CAMERA_RX > > + * register offset in the syscon property instead of hardcoding it. > > + */ > > + regmap_read(iss->syscon, 0x68, &cam_rx_ctrl); > > Do you use platform data now? I guess the address is the same on all SoCs > that use the OMAP 4 ISS? Yes I use platform data for now. The address is the same on all SoCs on which I've tested the driver, which is a single SoC :-) I'll research that when implementing DT bindings. > Acked-by: Sakari Alius Thank you. -- Regards, Laurent Pinchart