Re: [PATCH v5] media: Driver for Toshiba et8ek8 5MP sensor

Pavel Machek
2016-12-20T22:42:44Z

[-- Attachment #1: Type: text/plain, Size: 1121 bytes --]

Hi!

> On Tue, Dec 20, 2016 at 01:37:56PM +0100, Pavel Machek wrote:
> > Hi!
> >
> > > I think WARN() is good. It's a driver bug and it deserves to be notified.
> > ...
> > > I guess it's been like this since 2008 or so. I guess the comment could be
> > > simply removed, it's not a real problem.
> > ...
> > > AFAIR the module is called Stingray.
> >
> > Ok, so it seems we are pretty good? Can you take the patch now? Device
>
> Did you see this:
>
> <URL:http://www.spinics.net/lists/linux-media/msg109426.html>

Yes, I did. I did add the WARN_ON() we discussed, and we are now using
the native units. Adjusting the userspace was "fun", but I agree that
native interface has some advantages, so lets keep it that way. I
truly believe we are ready now :-).

> > tree documentation is in
> >
> > Subject: [PATCH v6] media: et8ek8: add device tree binding documentation
> >
> > and we have
> >
> > Acked-by: Rob Herring <robh@kernel.org>
>

--
(english) http://www.livejournal.com/~pavelmachek
(cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html

[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 181 bytes --]