From: David Howells <dhowells@redhat.com>
To: unlisted-recipients:; (no To-header on input)@casper.infradead.org
Cc: dhowells@redhat.com,
Mauro Carvalho Chehab <mchehab@osg.samsung.com>,
mkrufky@linuxtv.org, linux-media@vger.kernel.org
Subject: Re: [PATCH] cxusb: Use enum to represent table offsets rather than hard-coding numbers
Date: Tue, 17 Feb 2015 13:52:48 +0000 [thread overview]
Message-ID: <7664.1424181168@warthog.procyon.org.uk> (raw)
In-Reply-To: <28064.1424180750@warthog.procyon.org.uk>
David Howells <dhowells@redhat.com> wrote:
> That should really be:
>
> [VID_MEDION_MD95700] = {USB_VID_MEDION, USB_PID_MEDION_MD95700},
>
> since the index number is the model, not the vendor, which brings me to:
>
> [DVICO_BLUEBIRD_DVB_T_NANO_2_NFW_WARM] = {USB_VID_DVICO, USB_PID_DVICO_BLUEBIRD_DVB_T_NANO_2_NFW_WARM},
>
> which would be excessively long.
In fact, they're both wrong, since there needs to be a USB_DEVICE() wrapper.
David
next prev parent reply other threads:[~2015-02-17 13:53 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-02-16 15:33 [PATCH] cxusb: Use enum to represent table offsets rather than hard-coding numbers David Howells
2015-02-17 11:57 ` Mauro Carvalho Chehab
2015-02-17 13:45 ` David Howells
2015-02-17 13:52 ` David Howells [this message]
2015-02-17 13:57 ` Mauro Carvalho Chehab
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=7664.1424181168@warthog.procyon.org.uk \
--to=dhowells@redhat.com \
--cc=linux-media@vger.kernel.org \
--cc=mchehab@osg.samsung.com \
--cc=mkrufky@linuxtv.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).