From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id A8AEECE7A81 for ; Mon, 25 Sep 2023 06:52:58 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232278AbjIYGxC (ORCPT ); Mon, 25 Sep 2023 02:53:02 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:60172 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232333AbjIYGws (ORCPT ); Mon, 25 Sep 2023 02:52:48 -0400 Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 85F15CFB for ; Sun, 24 Sep 2023 23:52:13 -0700 (PDT) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 936BFC433C8; Mon, 25 Sep 2023 06:52:12 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1695624732; bh=3SKQZCiHJg1YqrPxw8jbB+5GpD+nHTfXK74ByvhhNGM=; h=In-Reply-To:References:Date:From:To:Cc:Subject:From; b=uE6B4FtykgILzfAYmlV5URyZoY3IvsFzyNKdivwSBmmKltIlOMe0hq+VvpzeIzMDz CYpXnJty9dFQBhqEihvA83JmctBERppI5kTlBxnVpC449PNr/cYWyj+GkwkyJrTnuu p7GbkxGegBzy9QrejNLGRBwhAHKtXbmDOMLp9EWnh3bk8gHkxkKJ/0maDF/jI48wkd nMPCSC4O1zgtZDNHMTMYC13Ww9XYXmhisy8hYLzmqcsKvp/3Sz86/ntJ57nS3PEfwx MU5Afk3VipMMhYeHblkQbFdYZE4BWrly5eUrAVmYOmRmpI9aZNQ2mhpQ4PH1sfLt73 fzlaiJTCIsFHQ== Received: from compute6.internal (compute6.nyi.internal [10.202.2.47]) by mailauth.nyi.internal (Postfix) with ESMTP id 7482927C005B; Mon, 25 Sep 2023 02:52:11 -0400 (EDT) Received: from imap51 ([10.202.2.101]) by compute6.internal (MEProxy); Mon, 25 Sep 2023 02:52:11 -0400 X-ME-Sender: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedviedrudelfedgudduhecutefuodetggdotefrod ftvfcurfhrohhfihhlvgemucfhrghsthforghilhdpqfgfvfdpuffrtefokffrpgfnqfgh necuuegrihhlohhuthemuceftddtnecunecujfgurhepofgfggfkjghffffhvfevufgtse httdertderredtnecuhfhrohhmpedftehrnhguuceuvghrghhmrghnnhdfuceorghrnhgu sehkvghrnhgvlhdrohhrgheqnecuggftrfgrthhtvghrnhepvdeviefgtedugeevieelvd fgveeuvdfgteegfeeiieejjeffgeeghedugedtveehnecuvehluhhsthgvrhfuihiivgep tdenucfrrghrrghmpehmrghilhhfrhhomheprghrnhguodhmvghsmhhtphgruhhthhhpvg hrshhonhgrlhhithihqdduvdekhedujedtvdegqddvkeejtddtvdeigedqrghrnhgupeep khgvrhhnvghlrdhorhhgsegrrhhnuggsrdguvg X-ME-Proxy: Feedback-ID: i36794607:Fastmail Received: by mailuser.nyi.internal (Postfix, from userid 501) id CCB05B60089; Mon, 25 Sep 2023 02:52:10 -0400 (EDT) X-Mailer: MessagingEngine.com Webmail Interface User-Agent: Cyrus-JMAP/3.9.0-alpha0-761-gece9e40c48-fm-20230913.001-gece9e40c MIME-Version: 1.0 Message-Id: <76aed346-e1e3-4262-aafa-974e6934b0d0@app.fastmail.com> In-Reply-To: References: <20230923152107.283289-1-hverkuil-cisco@xs4all.nl> <20230923152107.283289-13-hverkuil-cisco@xs4all.nl> <20230923181128.GA22193@pendragon.ideasonboard.com> Date: Mon, 25 Sep 2023 08:51:49 +0200 From: "Arnd Bergmann" To: "Hans Verkuil" , "laurent.pinchart" Cc: linux-media@vger.kernel.org Subject: Re: [PATCHv2 12/23] media: v4l2-subdev.h: increase struct v4l2_subdev name size Content-Type: text/plain Precedence: bulk List-ID: X-Mailing-List: linux-media@vger.kernel.org On Mon, Sep 25, 2023, at 08:26, Hans Verkuil wrote: > On 23/09/2023 20:11, Laurent Pinchart wrote: >>> >>> -#define V4L2_SUBDEV_NAME_SIZE 32 >>> +#define V4L2_SUBDEV_NAME_SIZE 52 >> >> Can we allocate it dynamically instead ? > > Anything is possible :-) > > But that's a separate issue and, I think, should be part of a larger > uAPI discussion. Right now it is just to squash those annoying warnings. Agreed, and I don't think that dynamic allocation here would help either on saving memory (because of the slab overhead) or for correctness (making it even harder for uapi to if there is no upper bound on the name length). Arnd