Linux Media Controller development
 help / color / mirror / Atom feed
From: "Hans Verkuil" <hverkuil@xs4all.nl>
To: "Andy Walls" <awalls@radix.net>
Cc: linux-media@vger.kernel.org,
	"Mauro Carvalho Chehab" <mchehab@infradead.org>,
	"Jean Delvare" <khali@linux-fr.org>
Subject: Re: bttv, tvaudio and ir-kbd-i2c probing conflict
Date: Mon, 16 Mar 2009 12:56:06 +0100 (CET)	[thread overview]
Message-ID: <7898.62.70.2.252.1237204566.squirrel@webmail.xs4all.nl> (raw)


> On Sun, 2009-03-15 at 13:44 +0100, Hans Verkuil wrote:
>> Hi Mauro, Jean,
>>
>> When converting the bttv driver to v4l2_subdev I found one probing
>> conflict
>> between tvaudio and ir-kbd-i2c: address 0x96 (or 0x4b in 7-bit
>> notation).
>>
>> It turns out that this is one and the same PIC16C54 device used on the
>> ProVideo PV951 board. This chip is used for both audio input selection
>> and
>> for IR handling.
>
>
> Hans,
>
> Just a thought: have you confirmed with i2cdetect that the PIC16C54
> microcontroller code only responds at one I2C address?

I don't have this board, so I can't test it. Everything points to this
being a multifunction device responding to one i2c address. It's one of
those programmable devices, so that seems perfectly reasonably to me.

In general I'm not inclined to worry about this case. As Jean said, the
core problem is not so much the perceived lack of i2c support for such
devices, but that the IR and (to a lesser extent) tvaudio modules are
badly designed. The IR module should really become a v4l2_subdev as well,
loaded on command by the adapter driver, and v4l2_subdev should acquire
one or more ops to handle IR stuff. With that in place it is easy to move
the pic support from tvaudio and the IR module into a module of its own.

Simple and effective it solves this whole issue elegantly.

Regards,

       Hans

-- 
Hans Verkuil - video4linux developer - sponsored by TANDBERG


             reply	other threads:[~2009-03-16 11:56 UTC|newest]

Thread overview: 27+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-03-16 11:56 Hans Verkuil [this message]
  -- strict thread matches above, loose matches on Subject: below --
2009-03-15 12:44 bttv, tvaudio and ir-kbd-i2c probing conflict Hans Verkuil
2009-03-15 17:12 ` Jean Delvare
2009-03-15 17:42   ` Trent Piepho
2009-03-15 17:53     ` Jean Delvare
2009-03-16  9:08       ` Mauro Carvalho Chehab
2009-03-16  9:34       ` Mauro Carvalho Chehab
2009-03-16 11:18         ` Jean Delvare
2009-03-16 12:52           ` Mauro Carvalho Chehab
2009-03-16 14:28             ` Jean Delvare
2009-03-16 15:31               ` Mauro Carvalho Chehab
2009-03-16 19:43               ` Trent Piepho
2009-03-16 21:40                 ` Jean Delvare
2009-03-16 21:58                   ` Hans Verkuil
2009-03-16 22:47                   ` Trent Piepho
2009-03-17  9:31                     ` Jean Delvare
2009-03-17 20:23                       ` Trent Piepho
2009-03-15 19:34   ` Andy Walls
2009-03-15 22:09     ` Hans Verkuil
2009-03-15 22:28       ` Jean Delvare
2009-03-15 22:26     ` Jean Delvare
2009-03-16  0:52       ` Andy Walls
2009-03-16  4:26         ` hermann pitton
2009-03-16 12:58         ` Jean Delvare
2009-03-15 23:46     ` Trent Piepho
2009-03-16  8:35       ` Jean Delvare
2009-03-16 11:35 ` Andy Walls

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=7898.62.70.2.252.1237204566.squirrel@webmail.xs4all.nl \
    --to=hverkuil@xs4all.nl \
    --cc=awalls@radix.net \
    --cc=khali@linux-fr.org \
    --cc=linux-media@vger.kernel.org \
    --cc=mchehab@infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox