From mboxrd@z Thu Jan 1 00:00:00 1970 Return-path: Received: from perceval.ideasonboard.com ([95.142.166.194]:47306 "EHLO perceval.ideasonboard.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750709AbaFCJpu (ORCPT ); Tue, 3 Jun 2014 05:45:50 -0400 From: Laurent Pinchart To: Hans Verkuil Cc: linux-media@vger.kernel.org, Hans Verkuil Subject: Re: [PATCH 0/2] v4l-utils: Add missing v4l2-mediabus.h header Date: Tue, 03 Jun 2014 11:46:15 +0200 Message-ID: <7921712.MU9v3dyUpo@avalon> In-Reply-To: <538D70AD.8090800@xs4all.nl> References: <1401756292-27676-1-git-send-email-laurent.pinchart@ideasonboard.com> <538D70AD.8090800@xs4all.nl> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Sender: linux-media-owner@vger.kernel.org List-ID: Hi Hans, On Tuesday 03 June 2014 08:52:29 Hans Verkuil wrote: > On 06/03/2014 02:44 AM, Laurent Pinchart wrote: > > Hello, > > > > This patch set adds the missing v4l2-mediabus.h header, required by > > media-ctl. Please see individual patches for details, they're pretty > > straightforward. > > Nack. > > The kernel headers used in v4l-utils are installed via 'make > sync-with-kernel'. So these headers shouldn't be edited, instead > Makefile.am should be updated. In particular, that's where the missing > header should be added. I had seen mentions of sync-with-kernel and for some reason thought it was a script. As I couldn't find it in the repository I decided to sync the headers manually :-/ Thanks for fixing the problem. By the way, what would you think about modifying sync-with-kernel to use installed kernel headers ? > > Laurent Pinchart (2): > > Use installed kernel headers instead of raw kernel headers > > Add the missing v4l2-mediabus.h kernel header > > > > include/linux/dvb/dmx.h | 8 +-- > > include/linux/dvb/frontend.h | 4 -- > > include/linux/dvb/video.h | 12 ++-- > > include/linux/fb.h | 8 +-- > > include/linux/ivtv.h | 6 +- > > include/linux/v4l2-mediabus.h | 147 +++++++++++++++++++++++++++++++++++++ > > include/linux/videodev2.h | 16 ++--- > > 7 files changed, 168 insertions(+), 33 deletions(-) > > create mode 100644 include/linux/v4l2-mediabus.h -- Regards, Laurent Pinchart